Dean Herbert
c9a492a6eb
Merge pull request #32075 from Gennadiyev/patch-result-screen-volume-adjust
...
Add Alt + mousewheel volume adjustment on result screens
2025-03-04 16:06:46 +09:00
Dan Balasescu
d3c4afe65d
Fix typo
2025-02-27 13:16:51 +09:00
Dan Balasescu
c2875423ee
Cleanup score fetching a bit
2025-02-26 18:58:29 +09:00
Dan Balasescu
3dde024650
Replace error handling with logs
...
- Handling all errors matches master a little bit better. Logging
exceptions in any case.
- Not throwing when beatmaps are missing simplifies tests.
2025-02-26 18:02:13 +09:00
Dan Balasescu
c7fd7cf9cd
Add missing ConfigureAwait
2025-02-26 17:39:56 +09:00
Dan Balasescu
90290997a7
Fix score panel difficulty depending on local beatmap
...
This is a very special case where online beatmap/ruleset models are
being ferried via `ScoreInfo` in what appear to `BeatmapDifficultyCache`
as local `BeatmapInfo`/`RulesetInfo` models. Here, BDC will incorrectly
attempt to proceed with calculating true difficulty where it cannot, and
return 0.
This is fixed locally because `ScoreInfo` is a very weird model, and I'm
not sure whether BDC should contain logic to work around this.
2025-02-26 14:49:00 +09:00
Dan Balasescu
bb457ca8e2
Clean up completion handling
2025-02-25 23:17:02 +09:00
Dan Balasescu
116b5a335a
ConfigureAwait(false) everywhere
2025-02-25 22:56:38 +09:00
Dan Balasescu
3b5bf391da
Arrays instead of enumerables
2025-02-25 22:55:55 +09:00
Dan Balasescu
8a27b6689e
Replace virtual async method with better abstraction
2025-02-25 22:51:36 +09:00
Dan Balasescu
13ca8c20f6
Make results screens use tasks to fetch scores
2025-02-25 21:54:16 +09:00
Kunologist
543ad5b2a4
Add alt+wheel volume adjustment on result screen
2025-02-24 14:16:33 +08:00
Dean Herbert
4f4d2b3b3f
Fix results screen applause playing too loud during multiplayer spectating
2025-02-20 23:42:32 +09:00
Bartłomiej Dach
288851c606
Fix score position not being displayed in solo results screen
...
Closes https://github.com/ppy/osu/issues/31842 .
To be honest, I recall this working too, but I don't recall when it
might have broken, nor do I want to go look for the point of breakage
because it might be borderline impossible to find it now. So I'm just
fixing as if it was just a straight omission.
Opting for a client-side fix because server-side inclusion of the score
position for an entire leaderboard has been previously rejected as too
expensive:
https://github.com/ppy/osu-web/pull/11354#discussion_r1689217450
2025-02-10 12:17:52 +01:00
Dean Herbert
975c35f5ac
Also add difficulty icon to contracted panel
2025-02-07 14:27:37 +09:00
Dean Herbert
25846b2327
Adjust results screen designs and tests slightly
2025-02-07 14:21:43 +09:00
Dan Balasescu
5b8b9589d8
Add ruleset icon to expanded score panel
2025-02-06 15:25:38 +09:00
Dan Balasescu
9033a4d480
Remove unused using
2025-02-03 14:20:56 +09:00
Dan Balasescu
210fa14759
Play sound via results screen instead
2025-02-03 14:15:46 +09:00
Dan Balasescu
cf2d0e6911
Fix results screen sounds persisting after exit
2025-01-31 16:22:37 +09:00
Dean Herbert
94ea003d90
Update game ScrollContainer usage in line with framework changes
...
See https://github.com/ppy/osu-framework/pull/6467 .
2025-01-11 01:42:59 +09:00
Dean Herbert
9025103b8b
Reword comment to hopefully be more understandable
2024-12-13 20:02:17 +09:00
Dean Herbert
d00bc4bdd1
Also allow using "quick retry" for other replays
2024-12-13 18:14:45 +09:00
Dean Herbert
0e0d96829f
Fix "quick retry" hotkey not working for autoplay
2024-12-13 18:08:29 +09:00
Huo Yaoyuan
d92ea910cf
Merge branch 'master' into netcore-analyzer
2024-12-05 17:18:56 +08:00
Dean Herbert
a4d58648e2
Fix quick retry transition from results screen
2024-12-04 14:31:39 +09:00
Huo Yaoyuan
f5a7716509
Apply minor performance rules
2024-11-28 20:41:44 +08:00
Dean Herbert
573aaf6637
Merge pull request #27128 from frenzibyte/user-statistics-provider
...
Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset
2024-11-27 13:13:47 +09:00
Dean Herbert
5668258182
Add incremental processing
2024-11-25 21:13:17 +09:00
Dean Herbert
33d725e889
Address unstable rate calculations as a list for marginal gains
2024-11-25 19:44:11 +09:00
Dean Herbert
605fe71f46
Make empty hitwindows readonly static and slightly improve comparison performance
2024-11-25 19:17:32 +09:00
Dean Herbert
6a0ac4c29e
Merge pull request #29640 from smoogipoo/mania-imperfect-ss
...
Make mania award SS even if there are GREAT judgements
2024-11-22 14:42:32 +09:00
Salman Alshamrani
4a628287e2
Decouple game-wide ruleset bindable and refactor LocalUserStatisticsProvider
...
This also throws away the logic of updating
`API.LocalUser.Value.Statistics`. Components should rely on
`LocalUserStatisticsProvider` instead for proper behaviour and ability
to update on statistics updates.
2024-11-17 18:13:37 -05:00
Dean Herbert
88d220f4c5
Fix crash when resetting offset after a play with no hit events
...
Closes https://github.com/ppy/osu/issues/30573 .
2024-11-14 16:03:15 +09:00
Dan Balasescu
d195a69447
Compute maximum performance along with difficulty
2024-10-17 19:26:19 +09:00
Bartłomiej Dach
20e7ade3b0
Fix statistics update not being shown on results screen if it arrives too fast
...
As reported in
https://discord.com/channels/188630481301012481/1097318920991559880/1288160137286258799 .
2024-09-24 17:52:19 +02:00
schiavoanto
ed044d5b85
Fix proposal for #29736
2024-09-06 22:58:18 +02:00
Bartłomiej Dach
9f834ca1a2
Silence beatmap retrieval failures from results screen favourite button
...
As reported (very poorly) in
https://github.com/ppy/osu/pull/28991#issuecomment-2331854970 .
I believe this is a total edge case and is mostly visible on dev due to
some beatmaps existing on `osu.ppy.sh` and not on `dev.ppy.sh`, but I
tend to agree in general that these types of failures should not be
firing very loud error notifications; logging to network and disabling
the button with a tooltip adjustment should be enough.
2024-09-06 10:29:23 +02:00
Dan Balasescu
d97a94aadd
Change accuracy circle to show badges based on score rank
2024-08-29 20:22:54 +09:00
Bartłomiej Dach
28d0a24555
Fix the fix
...
The more proper way to do this would be to address the underlying issue,
which is https://github.com/ppy/osu/issues/29546 , but let's do this
locally for now.
2024-08-21 12:27:56 +02:00
Layendan
59ba48bc81
Fix crash if favourite button api request fails
2024-08-19 07:58:20 -07:00
Bartłomiej Dach
7693d4c039
Merge branch 'master' into master
2024-08-19 14:30:20 +02:00
Joseph Madamba
c3600467bf
Make collection button test less broken
2024-08-15 11:49:15 -07:00
Dan Balasescu
136cdcfb29
Merge pull request #29059 from frenzibyte/fix-results-fetching-twice
...
Fix results screen fetching scores twice when scrolled to edge
2024-08-05 14:23:47 +09:00
Layendan
19a4cef113
update var names and test logic
2024-08-01 02:52:41 -07:00
Layendan
36bd83bb80
Update collection state when users add/remove from collection
2024-07-30 15:22:41 -07:00
Joseph Madamba
bc25e5d706
Remove unnecessary depth and padding set
2024-07-27 19:13:11 -07:00
Joseph Madamba
850bcaef7a
Merge remote-tracking branch 'upstream/master' into pr/28991
2024-07-27 19:09:02 -07:00
Joseph Madamba
334f5fda2d
Remove direct margin set in popover that was causing positioning offset
2024-07-27 19:02:57 -07:00
Joseph Madamba
04b15d0d38
Remove unnecessary ReceivePositionalInputAt
...
Results is not even using the new footer.
2024-07-27 19:02:43 -07:00
