75694 Commits

This Branch

This Branch

All Branches

• Fix quick play notification not setting "accepted" state
  Dan Balasescu · 2025-11-02 12:44:01 +09:00
  1ab017d4e2
• Fix file and class name mismatch
  Dan Balasescu · 2025-11-02 11:58:09 +09:00
  2413e98108
• Merge pull request #35545 from bdach/switch-active-carousel-group

  Switch active carousel group if current selection no longer exists in the previous group

  Dean Herbert · 2025-11-01 18:42:25 +09:00
  9a393f912b
• Merge pull request #35543 from bdach/fix-thing

  Fix bad performance when moving mouse to left side of song select forcibly expands group with current selection

  Dean Herbert · 2025-10-31 18:35:53 +09:00
  8e0c9281d3
• Merge pull request #35484 from glacc/show-hud-while-editing-skin-layout

  Always show HUD while editing skin layout

  Dean Herbert · 2025-10-31 08:48:59 +09:00
  25a1a1ba37
• Switch active carousel group if current selection no longer exists in the previous group

  This was primarily written to fix
  https://github.com/ppy/osu/issues/35538, but also incidentally targets
  some other scenarios, such as:
  
  - When switching from artist filtering to title filtering, selection
    sometimes would stay at the group under which the selection's artist
    was filed, rather than moving to the group under which the selection's
    title is filed (in other words, the group that *the selection is
    currently under*).
  
  - When simply assigning a beatmap to a collection such that it would
    be moved out of the current group, the selection will now follow to
    the new collection's group rather than staying at its previous
    position.
  
    Whether this is desired is highly likely to be extremely situational,
    but I don't want to introduce complications unless it's absolutely
    necessary.
  
  This has a significant performance overhead because
  `CheckModelEquality()` isn't free, but it doesn't seem horrible in
  profiling.

  Bartłomiej Dach · 2025-10-30 14:54:10 +01:00
  73e05e3fae
• Add failing test case
  Bartłomiej Dach · 2025-10-30 14:54:08 +01:00
  2a01e3d148
• Fix bad performance when moving mouse to left side of song select forcibly expands group with current selection

  Calling `HandleItemActivated()` rather than its intended 'parent method'
  of `Activate()` meant that selection state was not correctly
  invalidated:
  
  	https://github.com/ppy/osu/blob/819da1bc38dbc9676f8f1ee3924bfd8d9cb50347/osu.Game/Graphics/Carousel/Carousel.cs#L157
  
  which in turn meant that carousel item Y positions would not be
  recalculated correctly after the group was expanded, which meant that
  the items would become
  
  - visible,
  - stuck to the bottom of the expanded group,
  - one on top of another.
  
  Which is not something that's going to perform well.
  
  Certified OOP moment.

  Bartłomiej Dach · 2025-10-30 13:25:38 +01:00
  ea1798d731
• Merge pull request #35537 from smoogipoo/qp-fix-view-beatmap

  Fix quick play "view beatmap" showing incorrect difficulty

  Bartłomiej Dach · 2025-10-30 11:04:46 +01:00
  5c1171f358
• Merge pull request #35511 from smoogipoo/qp-fix-empty-sequence

  Fix potential sources of empty sequence errors

  Bartłomiej Dach · 2025-10-30 10:49:12 +01:00
  3fcc626e29
• Fix quick play "view beatmap" showing incorrect difficulty
  Dan Balasescu · 2025-10-30 15:27:28 +09:00
  7ff6edeb64
• Fix potential sources of empty sequence errors
  Dan Balasescu · 2025-10-29 23:06:28 +09:00
  657bc31539
• Add failing test
  Dan Balasescu · 2025-10-29 23:06:28 +09:00
  f9f7740acb
• Merge branch 'master' into show-hud-while-editing-skin-layout
  Bartłomiej Dach · 2025-10-29 14:27:28 +01:00
  5e4dd77e64
• Merge extremely similar setting-enforcing flows in skin editor
  Bartłomiej Dach · 2025-10-29 14:24:18 +01:00
  ce96c0b037
• Merge pull request #35495 from Joehuu/fix-drawable-date-update

  Fix `DrawableDate` not updating

  Dean Herbert · 2025-10-29 20:17:15 +09:00
  2025.1029.1-lazer 5af9bb784b
• Fix DrawableDate not updating

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2025-10-29 11:51:31 +01:00
  4c60df21db
• Merge pull request #35501 from peppy/more-quick-play-notification-improvements

  More quick play notification improvements

  Bartłomiej Dach · 2025-10-29 11:33:34 +01:00
  3c6fb14a32
• Remove redundant default value
  Dan Balasescu · 2025-10-29 17:27:33 +09:00
  3afc7b045c
• Merge pull request #35498 from smoogipoo/qp-add-helpers

  Add quick play helpers to add users/rounds

  Bartłomiej Dach · 2025-10-29 09:13:03 +01:00
  2025.1029.0 2f2847f1dd
• Allow queue completion notification to show even during gameplay
  Dean Herbert · 2025-10-29 16:58:18 +09:00
  ee7c52465b
• Use better iconography and colour for queue completion notification
  Dean Herbert · 2025-10-29 16:58:17 +09:00
  beb977892e
• Merge branch 'master' into qp-add-helpers
  Bartłomiej Dach · 2025-10-29 08:13:51 +01:00
  7203f419a2
• Replace indexers with GetOrAdd()

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2025-10-29 16:07:46 +09:00
  722cfb72d8
• Merge pull request #35482 from smoogipoo/qp-fix-initial-placement-display

  Ensure to never display "0th" placement

  Bartłomiej Dach · 2025-10-29 07:47:35 +01:00
  5da132cc2f
• Merge pull request #35499 from smoogipoo/qp-fix-beatmap-nullref

  Fix potential quick play crash if beatmap lookup fails

  Dean Herbert · 2025-10-29 15:43:31 +09:00
  9fac96cf07
• Merge pull request #35483 from smoogipoo/qp-fix-results-no-scores-crash

  Fix quick play results screen crash when no one plays

  Bartłomiej Dach · 2025-10-29 07:30:59 +01:00
  0610781c6c
• Fix potential nullref if beatmap lookup fails
  Dan Balasescu · 2025-10-29 15:15:36 +09:00
  e9260de56f
• Add failing test
  Dan Balasescu · 2025-10-29 15:08:40 +09:00
  2d177226fd
• Add quick play helpers to add users/rounds
  Dan Balasescu · 2025-10-29 14:49:22 +09:00
  bd912710f1
• Play sound when match is available even when queueing in background (#35496)
  Dean Herbert · 2025-10-29 13:58:20 +09:00
  4e76bd0f24
• Ensure all invocations of spectator server hub methods have their errors observed (#35488)

  Fell out when attempting
  https://github.com/ppy/osu-server-spectator/pull/346.
  
  Functionally, if a true non-`HubException` is produced via an invocation
  of a spectator server hub method, this doesn't really do much - the
  error will still log as 'unobserved' due to the default handler, it will
  still show up on sentry, etc. The only difference is that it'll get
  handled via the continuation installed in `FireAndForget()` rather than
  the `TaskScheduler.UnobservedTaskException` event.
  
  The only real case where this is relevant is when the server throws
  `HubException`s, which will now instead bubble up to a more
  human-readable form. Which is relevant to the aforementioned PR because
  that one makes any hub method potentially throw a `HubException` if the
  client version is too old.
  
  Obviously this does nothing for the existing old clients.

  Bartłomiej Dach · 2025-10-29 12:18:23 +09:00
  2025.1029.0-tachyon 050c10cec2
• Add a keycounter that has been actually used in Triangles skin (#35491)
  De4n · 2025-10-29 12:18:00 +09:00
  b4fd7ec10f
• Fix screen footer overlay content being pushed to right during fade-out (#35481)

  * Apply some renames & drawable names for visualiser
  
  Optional but really helps me make heads of tails as to what anything is
  here.
  
  Like really, multiple variations of `footerContent` inside a
  `ScreenFooter` class, with zero elaboration that it's really content to
  do with *overlays*...
  
  * Fix screen footer overlay content being pushed to right during fade-out
  
  - Closes https://github.com/ppy/osu/issues/35203
  - Supersedes / closes https://github.com/ppy/osu/pull/35468

  Bartłomiej Dach · 2025-10-29 12:14:37 +09:00
  cbe7da99ad
• Add failing drawable date seconds update test
  Joseph Madamba · 2025-10-28 19:39:07 -07:00
  9a965a2546
• Fix quick play results screen when no one plays
  Dan Balasescu · 2025-10-29 11:18:25 +09:00
  7b0121a430
• Add failing test case
  Dan Balasescu · 2025-10-29 11:18:25 +09:00
  627fec2e3a
• Code quality fix.
  Glacc · 2025-10-28 23:04:09 +08:00
  c779e142e6
• Code quality fix.
  Glacc · 2025-10-28 22:54:07 +08:00
  89fffa5a1a
• Null check for configVisibilityMode.
  Glacc · 2025-10-28 21:51:21 +08:00
  6d597fc815
• Revert value after closing editor.
  Glacc · 2025-10-28 21:42:34 +08:00
  a78b456e20
• And make HUD visibility mode lease when Skin Layout Editor is visible.
  Glacc · 2025-10-28 21:38:28 +08:00
  9237c76942
• Only set HUD visibility mode to non-Never when skin layout editor is visible by saving and restoring HUD visibility mode setting.
  Glacc · 2025-10-28 21:21:07 +08:00
  378c64b7f8
• Always show HUD while editing skin layout.
  Glacc · 2025-10-28 19:42:47 +08:00
  87b66685d6
• Make MachmakingUser.Placement nullable
  Dan Balasescu · 2025-10-28 20:39:09 +09:00
  c524bf5432
• Ensure to never display "0th" placement
  Dan Balasescu · 2025-10-28 19:35:15 +09:00
  a40230da4b
• Merge pull request #35470 from smoogipoo/qp-show-quit-users
  Dean Herbert · 2025-10-28 19:26:10 +09:00
  b1a421c22b
• Fix quit text on avatar only mode, fix avatar fade
  Dean Herbert · 2025-10-28 18:29:05 +09:00
  9601708087
• Update test in line with new quit panel behaviour
  Dean Herbert · 2025-10-28 16:30:31 +09:00
  22f11b6fa5
• Merge pull request #35474 from peppy/fix-wasapi-setting-text

  Fix WASAPI settings notice text not displaying on startup

  Bartłomiej Dach · 2025-10-28 08:23:03 +01:00
  f95d0d214e