69512 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	2d993645af	Add test coverage of judgements not being synced when resuming a replay	2024-09-18 15:28:10 +09:00
Joseph Madamba	fd6b3b6b36	Fix searching by clicking title/artist in beatmap overlay not following original language setting	2024-09-17 22:34:06 -07:00
Dean Herbert	76c5e743d7	Remove opacity from old style dropdown menus ... These aren't used in many places, but we've since moved away from opacity in UI elements like this, so let's just nuke it here for legibility. Addresses https://github.com/ppy/osu/discussions/29906.	2024-09-18 13:49:27 +09:00
Bartłomiej Dach	20b1d76269	Ensure selection is preserved when moving selection between columns ... Closes https://github.com/ppy/osu/issues/29793. I believe that the sequence of events that makes this happens is as follows: - User selects a range of objects. Some of those objects are off-screen, and thus would be presumed to be not alive - except the blueprint container forces them to remain alive, because they're part of the selection. - User moves the selection to another column, which is implemented by temporarily removing the objects from the playfield, changing their column, and re-adding them. This sort of pattern is supposed to kick off the `HitObjectUsageTransferred` flow in `HitObjectUsageEventBuffer` - and it does... for objects that are *currently visible on screen* and thus would be alive regardless of `SetKeepAlive()`. However, this does not hold for objects that are off-screen - nothing ensures they are kept alive again after re-adding, and thus they inadvertently become dead. - Thus, this doesn't kick off the `BlueprintContainer` flows associated with transferring objects to another column, and instead fires the removal flows, which ensure that the off-screen objects that were being moved are instead deselected. I tried a few other options but found no better resolution than this - calling `SetKeepAlive()` directly would require making it public, which seems like a bad idea. There's really no good way to generically handle this either, because it is the ruleset that decides that its way of implementing this operation will be a removal and re-add of objects, so...	2024-09-17 13:18:18 +02:00
Bartłomiej Dach	e0f92bab6a	Add test case covering failure	2024-09-17 13:07:52 +02:00
Bartłomiej Dach	1b17231da4	Implement "form" slider bar control	2024-09-17 11:40:57 +02:00
Bartłomiej Dach	ea94f903c1	Merge pull request #29894 from peppy/fix-fruit-rotation ... Fix osu!catch fruit rotation being applied too late	2024-09-17 10:26:21 +02:00
Dean Herbert	f8fff4074d	Fix rotation not being updated correctly on start time change	2024-09-17 16:18:29 +09:00
Dean Herbert	c1c0d49bfe	Add comments and fix bananas stopping still if not caught	2024-09-17 16:15:45 +09:00
Dean Herbert	a1fa132ddb	Merge pull request #29893 from bdach/slider-end-drag-marker-broken-by-stacking ... Fix slider end drag marker being in incorrect position for stacked sliders	2024-09-17 16:03:38 +09:00
Dean Herbert	3f4422429d	*Also* fix droplets	2024-09-17 15:38:51 +09:00
Dean Herbert	2ccdad41e7	Also fix banana showers	2024-09-17 15:31:00 +09:00
Bartłomiej Dach	67a7f608f1	Fix slider end drag marker being in incorrect position for stacked sliders ... Closes https://github.com/ppy/osu/issues/29884.	2024-09-17 08:23:46 +02:00
Bartłomiej Dach	3e63fe399f	Enable NRT in test scene	2024-09-17 08:22:37 +02:00
Bartłomiej Dach	a99dbfa768	Add failing test step demonstrating incorrect end drag marker position	2024-09-17 08:21:58 +02:00
Dean Herbert	785a725507	Fix osu!catch fruit rotation being applied too late	2024-09-17 15:12:02 +09:00
Dean Herbert	d34e8ea69e	Update framework	2024-09-16 16:15:09 +09:00
OliBomby	30096c1c71	clean up code	2024-09-14 17:26:04 +02:00
Olivier Schipper	f7503ee2c8	Merge pull request #107 from kongehund/master ... Rewrite GetConvexHull using the clean room method	2024-09-14 17:05:33 +02:00
kongehund	385eb5eed5	Rewrite GetConvexHull	2024-09-14 16:32:51 +02:00
Dean Herbert	18ab4ee929	Merge pull request #29812 from smallketchup82/add-beatmap-icon ... Add beatmap icon to windows beatmap files	2024-09-14 10:14:30 +09:00
Dean Herbert	eb102479f4	Use beatmap icon for .osr and .osk for now	2024-09-14 02:47:19 +09:00
Dean Herbert	1204136af8	Update icon file with new design	2024-09-14 02:46:19 +09:00
Dean Herbert	5ea7061d5a	Merge pull request #29712 from bdach/editor/setup-screen-checkbox ... Implement "form" check box control	2024-09-14 02:26:59 +09:00
Dean Herbert	369c913272	Merge pull request #29862 from bdach/backpopulate-rank-submission-dates ... Backpopulate missing ranked/submitted dates using new local metadata cache	2024-09-14 02:20:22 +09:00
Dean Herbert	562a5006ea	Change log output to only output when matches are found (in line with other methods)	2024-09-14 02:19:52 +09:00
Bartłomiej Dach	a4f6d4a300	Backpopulate missing ranked/submitted dates using new local metadata cache ... People keep asking why https://github.com/ppy/osu/pull/29553 didn't fix their databases (as stated in the PR, it didn't intend to), so this should do it for them.	2024-09-13 16:00:49 +02:00
Bartłomiej Dach	7f71ef4547	Only allow seek to next/previous object via keybinding if there is no selection	2024-09-13 15:14:09 +02:00
Bartłomiej Dach	f71ce8869e	Limit width of test scene controls ... To better reflect what the widths should be in actual usage.	2024-09-13 14:54:10 +02:00
Bartłomiej Dach	929ea87975	Revert to checkbox on right	2024-09-13 14:53:59 +02:00
Dan Balasescu	6f143091d1	Merge pull request #29291 from Givikap120/pp_refactoring_osustrainskill ... Pp Refactoring: Removing `DEFAULT_DIFFICULTY_MULTIPLIER` from `OsuStrainSkill`	2024-09-13 20:13:15 +09:00
Bartłomiej Dach	2ccb4a48eb	Add test coverage for seeking between objects in editor	2024-09-13 11:40:01 +02:00
Bartłomiej Dach	1292a34b9d	Add failing test coverage for object nudging	2024-09-13 11:39:56 +02:00
Bartłomiej Dach	652a590611	Attempt to address design concerns	2024-09-13 09:59:20 +02:00
Dan Balasescu	d54c6aefbe	Merge branch 'master' into pp_refactoring_osustrainskill	2024-09-12 17:28:24 +09:00
Dan Balasescu	1beae4b71a	Merge pull request #29293 from Givikap120/pp_refactoring_merge_multipliers ... Pp Refactoring: Merged multipliers that do the same thing	2024-09-12 17:22:23 +09:00
Dan Balasescu	c7a2e79b6e	Merge branch 'master' into pp_refactoring_merge_multipliers	2024-09-12 16:22:55 +09:00
Dean Herbert	e16769f4c9	Merge pull request #29848 from peppy/update-framework ... Update framework	2024-09-12 15:46:09 +09:00
Dean Herbert	77c3cb6504	Update framework	2024-09-12 14:38:51 +09:00
Dean Herbert	a8365202d9	Merge pull request #29841 from bdach/replay-analysis-mod-woes ... Fix several issues in interactions between playfield-altering mods and the replay analysis feature	2024-09-12 13:52:09 +09:00
Dan Balasescu	91fc476b0e	Merge pull request #29294 from Givikap120/pp_refactoring_speed_eval_change ... Pp Refactoring: `SpeedEvaluator` refactoring	2024-09-12 00:25:10 +09:00
Dan Balasescu	d935ed949c	Merge branch 'master' into pp_refactoring_speed_eval_change	2024-09-11 23:45:10 +09:00
Bartłomiej Dach	f38ae5f239	Fix replay analysis overlay being affected by visibility impairing mods ... Closes https://github.com/ppy/osu/issues/29748.	2024-09-11 15:55:02 +02:00
Bartłomiej Dach	4a39873e2a	Fix replay analysis overlay not rotating with Barrel Roll enabled ... Closes https://github.com/ppy/osu/issues/29839.	2024-09-11 15:54:30 +02:00
Bartłomiej Dach	b78ef81bf1	Fix Flashlight not appearing on top of bubbles from Bubbles mod ... Inadvertently regressed in 44d0dc6113.	2024-09-11 15:54:07 +02:00
Dean Herbert	b5afca98f1	Merge pull request #29838 from bdach/do-not-use-abstract-do-NOT-use-abstract-DO-NOT-USE-ABSTRACT ... Remove poorly-fitted "legacy combo counter" abstraction	2024-09-11 20:13:00 +09:00
Bartłomiej Dach	0e663d1801	Revert default combo counter code to pre-abstractification (and nuke eldritch abstract entity)	2024-09-11 11:44:59 +02:00
Bartłomiej Dach	d8a745ec04	Decouple legacy mania combo counter from abstract eldritch entity	2024-09-11 11:44:57 +02:00
Dan Balasescu	fd887b24fa	Merge pull request #29805 from smallketchup82/complete-disable-velopack ... Completely disable Velopack when using an external updater	2024-09-11 16:27:24 +09:00
Dean Herbert	02f8f226f8	Merge pull request #29787 from peppy/fix-restart-notifications ... Fix restart notifications appearing every 30 minutes in some cases	2024-09-11 02:59:59 +09:00