Merge pull request #29805 from smallketchup82/complete-disable-velopack

Completely disable Velopack when using an external updater

osu.Desktop/OsuGameDesktop.cs

@@ -95,11 +95,11 @@ namespace osu.Desktop
                 return key?.OpenSubKey(WindowsAssociationManager.SHELL_OPEN_COMMAND)?.GetValue(string.Empty)?.ToString()?.Split('"')[1].Replace("osu!.exe", "");
         }
 
+        public static bool IsPackageManaged => !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("OSU_EXTERNAL_UPDATE_PROVIDER"));
+
         protected override UpdateManager CreateUpdateManager()
         {
-            string? packageManaged = Environment.GetEnvironmentVariable("OSU_EXTERNAL_UPDATE_PROVIDER");
-
-            if (!string.IsNullOrEmpty(packageManaged))
+            if (IsPackageManaged)
                 return new NoActionUpdateManager();
 
             return new VelopackUpdateManager();

osu.Desktop/Program.cs

@@ -169,6 +169,12 @@ namespace osu.Desktop
 
         private static void setupVelopack()
         {
+            if (OsuGameDesktop.IsPackageManaged)
+            {
+                Logger.Log("Updates are being managed by an external provider. Skipping Velopack setup.");
+                return;
+            }
+
             var app = VelopackApp.Build();
 
             if (OperatingSystem.IsWindows())