1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-12 12:37:29 +08:00
Commit Graph

45711 Commits

Author SHA1 Message Date
Dan Balasescu
14a7b00f58
Merge pull request #15242 from peppy/fix-low-pass-sticking-after-fail
Fix low-pass filter continuing to take effect after fail animation has already ended
2021-10-22 19:04:03 +09:00
Dan Balasescu
5b9eb52d44
Merge pull request #15243 from peppy/remove-beatmap-set-online-info-setters
Remove unnecessary setters from `IBeatmapSetOnlineInfo` interface
2021-10-22 18:45:11 +09:00
Dean Herbert
cc1d759290 Remove unnecessary setters from IBeatmapSetOnlineInfo interface 2021-10-22 17:48:09 +09:00
Dean Herbert
91cc77407d Fix low-pass filter continuing to take effect after fail animation has already ended 2021-10-22 17:02:02 +09:00
Dan Balasescu
e0e3d1643b
Merge pull request #15239 from peppy/fix-incorrect-length-mapping
Fix incorrect length mapping in `APIBeatmap`
2021-10-22 16:24:28 +09:00
Dean Herbert
ea473428e8 Fix incorrect length mapping in APIBeatmap 2021-10-22 15:54:40 +09:00
Dean Herbert
de33b2f45a Return set metadata if available before falling back to empty object 2021-10-22 15:00:31 +09:00
Dean Herbert
eef9949a0a Remove unnecessary branching around EF logic 2021-10-22 14:48:20 +09:00
Dean Herbert
93482414d6 Remove SkinConfiguration subclasses and allow configuration parsing for all skin types 2021-10-22 14:42:23 +09:00
Dean Herbert
82d0a6515f Fix incorrect conditional for checking whether import (would fail for default skin) 2021-10-22 14:08:12 +09:00
Dean Herbert
9cdc1ba592 Fix default legacy skin not being able to read from stored skin.ini 2021-10-22 13:43:45 +09:00
Dean Herbert
e5b73f25cd Ensure newly created skin.ini files are set to latest version 2021-10-22 12:56:05 +09:00
Dean Herbert
08971ff8f2
Fix typo in region spedc
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-10-22 11:03:28 +09:00
Dean Herbert
fb7cf35481 Remove BeatmapMetadata base class from APIBeatmap 2021-10-21 21:48:14 +09:00
Dean Herbert
6dd54a417f Remove BeatmapMetadata base class from APIBeatmapSet 2021-10-21 21:32:07 +09:00
Dean Herbert
9e0d839ef3
Merge branch 'master' into fix-skin-layout-editor-crash 2021-10-21 20:33:47 +09:00
Dean Herbert
02d1cf31cb
Merge pull request #15223 from peppy/api-beatmap-set-is-i-beatmap-set
Implement `IBeatmapInfo`/`IBeatmapSetInfo` from API beatmap types
2021-10-21 20:33:26 +09:00
Dean Herbert
c580ec865f APIBeatmapSet.Covers is never null 2021-10-21 19:34:01 +09:00
Dean Herbert
0fe0b5dc09 APIBeatmap implements IBeatmapInfo 2021-10-21 19:14:31 +09:00
Dean Herbert
40a176e86e APIBeatmapSet implements IBeatmapSetInfo 2021-10-21 19:14:19 +09:00
Dean Herbert
69e7810dad Enable nullable and switch classes to structs 2021-10-21 18:54:36 +09:00
Dan Balasescu
12620fcf78
Merge pull request #15222 from peppy/online-info-as-interface
Move online beatmap set info to interface
2021-10-21 17:49:05 +09:00
Dan Balasescu
8ae05ee8f7
Merge branch 'master' into online-info-as-interface 2021-10-21 17:14:57 +09:00
Dean Herbert
0335ed6f27 Add missing licence header 2021-10-21 17:14:29 +09:00
Dan Balasescu
4434e55480
Merge pull request #15221 from peppy/remove-playlist-api-beatmap-
Remove `APIPlaylistBeatmap` subclass
2021-10-21 17:11:05 +09:00
Dean Herbert
ff674ca913 Remove unnecessary access modifiers from interface 2021-10-21 17:01:57 +09:00
Dean Herbert
b73bd54ab2 Split out individual pieces into own files 2021-10-21 16:58:42 +09:00
Dean Herbert
32d01f022f Rename usages which rely on online backing 2021-10-21 16:58:42 +09:00
Dean Herbert
0706ad70fb Move BeatmapSetOnlineInfo to an interface type 2021-10-21 16:58:42 +09:00
Dean Herbert
a5c155bc87 Remove APIPlaylistBeatmap subclass 2021-10-21 16:43:46 +09:00
Dean Herbert
a5088cac27 Fix default metadata propagation when no files are present 2021-10-21 13:43:42 +09:00
Dean Herbert
59b7210efa Revert disallowing imports with no files
While it is logical that we want this, from a testing perspective this is a bit of a nightmare to fix. Let's revisit at a later point in time.
2021-10-21 13:43:42 +09:00
Dean Herbert
ea2b2a3beb
Merge pull request #15212 from bdach/text-box-colour-updates
Use colour provider theming in text boxes
2021-10-21 13:30:47 +09:00
Dean Herbert
7a1be99999 Merge branch 'master' into fix-skin-layout-editor-crash 2021-10-21 13:05:05 +09:00
Dean Herbert
7bc8f5cd5c Change selection colour to also match the colour provider scheme 2021-10-21 13:01:13 +09:00
Bartłomiej Dach
9ad9465020
Remove online-screen-local textbox recolours 2021-10-20 22:49:25 +02:00
Bartłomiej Dach
1ec881ce1d
Recolour focused text box variant 2021-10-20 22:49:25 +02:00
Bartłomiej Dach
addcef4f5d
Recolour text box using OverlayColourProvider 2021-10-20 22:49:25 +02:00
Bartłomiej Dach
a7f3beabe3
Modify OsuTextBox test scene to test against colour provider 2021-10-20 22:49:23 +02:00
Dean Herbert
fd01a226db
Remove redundant parenthesis
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-10-20 18:11:33 +09:00
Dean Herbert
e9a35cbe7e
Merge pull request #15202 from EVAST9919/prev-username-test-fix
Fix and improve TestSceneUserProfilePreviousUsernames
2021-10-20 18:03:25 +09:00
Dean Herbert
68c01fc204 Fix infinite loop on default skin (it can't have a skin.ini) 2021-10-20 17:56:45 +09:00
Dean Herbert
9e6e41d7c0 Add migration to reset and repopulate existing skin hashes 2021-10-20 17:56:45 +09:00
Dean Herbert
5f53dd8021 Rename test variable for legibility 2021-10-20 17:56:45 +09:00
Dean Herbert
602303e947 Add test coverage for skin.ini contents 2021-10-20 17:56:45 +09:00
Dean Herbert
a95c754fd3 Fix multiple issues and make metadata fallback process more logical 2021-10-20 17:56:45 +09:00
Dean Herbert
19f30177ea Rewrite tests completely 2021-10-20 17:45:06 +09:00
Dean Herbert
439e90fce3 Disallow archive imports with no hashable files 2021-10-20 17:45:06 +09:00
Dean Herbert
fa542f2547 Include json files in skin hashing
This covers the new layout storage we are doing.
2021-10-20 17:45:06 +09:00
Dean Herbert
789c715f13 Add skin.ini write support to allow for more correct hashing 2021-10-20 17:45:06 +09:00