Dean Herbert
175eb82ccf
Split out beatmaps and set panels into two separate classes
2025-01-24 20:10:41 +09:00
Dean Herbert
0164a2e4dc
Move pool item preparation / cleanup duties to Carousel
2025-01-24 20:10:41 +09:00
Bartłomiej Dach
2d46da1520
Merge pull request #31634 from peppy/beatmap-carousel-v2-selection
...
Add selection support to beatmap carousel v2
2025-01-24 11:43:17 +01:00
Dean Herbert
9366bfbf0d
Move activation drawable flow portion to ICarouselPanel
2025-01-24 18:40:48 +09:00
Dean Herbert
92429b2ed9
Adjust comments on ICarouselPanel to imply external use
2025-01-24 18:34:04 +09:00
Bartłomiej Dach
2f84aec88d
Merge pull request #31644 from peppy/fix-beatmap-offset-crash
...
Fix potential crash when adjusting offset
2025-01-24 10:20:29 +01:00
Dean Herbert
721b2dfbba
Fix average button not correctly becoming disabled where it previously would
2025-01-24 17:17:34 +09:00
Dean Herbert
28a59f4e29
Move line to correct location
2025-01-24 16:45:14 +09:00
Dean Herbert
8f8a6455b4
Bypass offset disallowed status when handling realm callbacks
...
Hopefully don't need to overthink this one.
2025-01-24 15:49:47 +09:00
Dean Herbert
ee78e1b223
Add safeties against attempting to apply previous play while offset adjust is not allowed
...
This should theoretically not be possible, but while we are sharing this
control's implementation between gameplay and non-gameplay usages, let's
ensure nothing weird can occur.
2025-01-24 15:49:47 +09:00
Dean Herbert
4ae6dfd790
Merge pull request #31640 from frenzibyte/discord-rpc-ux
...
Hide Discord RPC error messages away from user attention
2025-01-24 14:36:13 +09:00
Salman Alshamrani
61a818e4ed
Hide Discord RPC error messages away from user attention
2025-01-23 21:22:35 -05:00
Dean Herbert
c3269013d9
Merge pull request #31633 from bdach/thanks-for-nothing-github-actions
...
Roll back windows build image to 2019 on android build job
2025-01-24 00:35:58 +09:00
Dean Herbert
f4270ab3b9
Simplify selection handling logic
2025-01-23 23:58:51 +09:00
Dean Herbert
d5369d3508
Add regions to BeatmapCarousel
2025-01-23 23:53:09 +09:00
Dean Herbert
0716b73d2a
ActivateSelection -> TryActivateSelection
2025-01-23 22:44:39 +09:00
Dean Herbert
2feab31426
Adjust inline commentary based on review feedback
2025-01-23 22:41:20 +09:00
Dean Herbert
eaea053c7d
Add test coverage of various selection examples
...
Where possible I've tried to match the test and method names of
`TestSceneBeatmapCarousel` for easy coverage comparison.
2025-01-23 18:51:25 +09:00
Dean Herbert
ffca90779f
Fix sort direction being flipped
2025-01-23 18:51:24 +09:00
Dean Herbert
9ab045495d
Tidy up tests in preparation for adding more
2025-01-23 18:51:24 +09:00
Dean Herbert
2f94456a06
Add selection and activation flow
2025-01-23 18:51:24 +09:00
Dean Herbert
ecef5e5d71
Add set-difficulty tracking in BeatmapCarouselFilterGrouping
...
Rather than tracking inside individual items, let's just maintain a
single dictionary which is refreshed every time we regenerate filters.
2025-01-23 18:48:44 +09:00
Dean Herbert
980f6cf18e
Make CarouselItem sealed and remove BeatmapCarouselItem concept
...
Less abstraction is better. As far as I can tell, we don't need a custom
model for this. If there's any tracking to be done, it should be done
within `BeatmapCarousel`'s implementation (or a filter).
2025-01-23 18:48:44 +09:00
Dean Herbert
c67c0a7fc0
Move Selected status to drawables
...
Basically, I don't want bindables in `CarouselItem`. It means there
needs to be a bind-unbind process on pooling. By moving these to the
drawable and just updating every frame, we can simplify things a lot.
2025-01-23 18:48:43 +09:00
Bartłomiej Dach
beaadfa1fa
Merge pull request #31632 from peppy/beatmap-carousel-v2-cleanups
...
Initial carousel additions in preparation for selection logic
2025-01-23 10:43:12 +01:00
Bartłomiej Dach
b4e8a17f03
Roll back windows build image to 2019 on android build job
...
Per workaround suggested in
https://github.com/actions/runner-images/issues/11402#issuecomment-2596473501 .
Applying this now as my hopes for a swift resolution without changes on
our side are slim to none (read thread linked above in full to learn
why).
2025-01-23 10:12:30 +01:00
Dean Herbert
ded1d9f019
displayedCarouselItems -> carouselItems
2025-01-23 15:58:35 +09:00
Dean Herbert
d526835627
Only show loading when doing a user triggered filter
2025-01-23 15:51:54 +09:00
Dean Herbert
6ac2dbc818
Reorder carousel methods into logical regions
2025-01-23 15:50:57 +09:00
Dean Herbert
8657576210
Show selection defaults in test scene (and make prettier)
2025-01-23 15:50:40 +09:00
Dean Herbert
bf23c67603
Merge pull request #31509 from bdach/local-metadata-cache-corruption
...
Refetch local metadata cache if corruption is detected
2025-01-23 02:43:14 +09:00
Dan Balasescu
11e84f325c
Merge pull request #31616 from bdach/fix-new-combo-button-crash
...
Fix crash from new combo colour selector when there are no combo colours present
2025-01-22 20:48:02 +09:00
Bartłomiej Dach
3da220b8f6
Fix crash from new combo colour selector when there are no combo colours present
...
Closes https://github.com/ppy/osu/issues/31615 .
2025-01-22 11:39:32 +01:00
Dean Herbert
218720bca5
Merge pull request #31588 from minetoblend/feature/paste-snapped
...
Snap to beat divisor when pasting hitobjects in editor
2025-01-22 18:38:12 +09:00
Dean Herbert
c94b8bf051
Apply NRT to new class
2025-01-22 18:36:13 +09:00
Dean Herbert
6ceb348cf6
Adjust code again to avoid weird throw mishandling
2025-01-22 18:24:01 +09:00
Dan Balasescu
63e6b0e050
Merge pull request #31603 from peppy/input-amendments
...
Tidy up various input handling anomalies
2025-01-22 18:05:06 +09:00
Bartłomiej Dach
2623d8dcac
Merge pull request #31604 from peppy/fix-song-select-right-click-handling
...
Fix song select right click handling
2025-01-22 10:00:03 +01:00
Dan Balasescu
631ae90130
Merge pull request #31613 from peppy/friend-notifications-bug-less
...
Make friend notifications less prominent
2025-01-22 17:34:23 +09:00
Dean Herbert
26ef23c9a9
Remove outdated ef related catch-when usage
2025-01-22 17:04:30 +09:00
Dean Herbert
910c0022e3
Adjust code style slightly
2025-01-22 17:03:01 +09:00
Dean Herbert
9e023340b0
Mark friend notifications as non-important
2025-01-22 16:41:27 +09:00
Dean Herbert
4cf4b8c73d
Switch IsImportant to init property isntead of virtual
2025-01-22 16:41:26 +09:00
Dean Herbert
fde2b22bbc
Add transient flag for notifications which shouldn't linger in history
2025-01-22 16:41:26 +09:00
Marvin Schürz
cc7c549468
Add test scene for clipboard snapping
2025-01-21 11:02:41 +01:00
Dan Balasescu
8f8246278a
Merge pull request #31527 from bdach/spectator-list-ready
...
Show spectating users during gameplay
2025-01-21 18:54:11 +09:00
Bartłomiej Dach
0265a29000
Move bindings to LoadComplete()
2025-01-21 10:02:16 +01:00
Dean Herbert
704c2ea0cc
Merge pull request #31026 from frenzibyte/ios-system-file-import
...
Add special handling for file import button on iOS
2025-01-21 17:33:03 +09:00
Dean Herbert
6c27e87714
Add back explicit right click handling of carousel absolute scrolling
2025-01-21 17:24:42 +09:00
Dean Herbert
66be9f2d1b
Remove right click default for absolute scroll
2025-01-21 17:24:41 +09:00
