49498 Commits

This Branch

This Branch

All Branches

• Merge pull request #17153 from hlysine/osu-random-mod-logic-changes

  Separate randomization and object positioning logic in osu random mod

  Dan Balasescu · 2022-03-09 20:52:33 +09:00
  1646e9d64c
• Merge pull request #17054 from hlysine/mod-adaptive-speed

  Implement Adaptive Speed mod

  Dean Herbert · 2022-03-09 17:56:34 +09:00
  8bb07f83cd
• Attempt to merge conditional expression

  Hoping to fix CI error, caused by older R# version.

  Dan Balasescu · 2022-03-09 17:46:42 +09:00
  353b251d38
• Merge pull request #17188 from peppy/fix-carousel-item-interaction-when-not-visible

  Fix beatmap carousel panels accepting input while marked as not-visible

  Dan Balasescu · 2022-03-09 17:43:30 +09:00
  d847f5874c
• Merge branch 'master' into osu-random-mod-logic-changes
  Dean Herbert · 2022-03-09 16:58:59 +09:00
  e689973de5
• Apply nullable to OsuModRandom rather than using jetbrains annotations
  Dean Herbert · 2022-03-09 16:58:36 +09:00
  75c6a676b4
• Fix beatmap carousel panels accepting input while marked as not-visible

  This is an issue as carousel panels manage their own animated state. If
  they are marked as not-visible (done at a higher level, from filtering
  or update pathways) but clicked while fading out, they will animate back
  to a visible state but not be marked as visible.
  
  No tests for this one as it's probably not worthwhile to test (and hard
  to do so). Manual testing can be done with the following patch:
  
  ```diff
  diff --git a/osu.Game/Screens/Select/BeatmapCarousel.cs
  b/osu.Game/Screens/Select/BeatmapCarousel.cs
  index c3d340ac61..3372242acc 100644
  --- a/osu.Game/Screens/Select/BeatmapCarousel.cs
  +++ b/osu.Game/Screens/Select/BeatmapCarousel.cs
  @@ -255,7 +255,7 @@ private void
  beatmapSetsChanged(IRealmCollection<BeatmapSetInfo> sender, ChangeS
               }
  
               foreach (int i in changes.NewModifiedIndices)
  -                UpdateBeatmapSet(sender[i].Detach());
  +                Scheduler.AddDelayed(() =>
                   UpdateBeatmapSet(sender[i].Detach()), 100, true);
  
               foreach (int i in changes.InsertedIndices)
                   UpdateBeatmapSet(sender[i].Detach());
  
  ```
  
  - Enter gameplay and adjust beatmap offset then return to song select
    and click the flashing panel.
  OR
  - Enter editor and save then return to song select and click the
    flashing panel.
  
  Closes https://github.com/ppy/osu/discussions/17171.

  Dean Herbert · 2022-03-09 16:08:52 +09:00
  520d2d6cfa
• Merge pull request #17185 from smoogipoo/fix-local-score-linking

  Fix avatar not clickable after watching replay

  Dean Herbert · 2022-03-09 15:39:54 +09:00
  aad9e856b1
• Fix avatar not clickable after watching replay
  Dan Balasescu · 2022-03-09 14:39:02 +09:00
  ad0ca5673a
• Merge getAbsoluteAngle into computeRandomisedPosition
  Henry Lin · 2022-03-09 13:27:33 +08:00
  e3cf2c6acd
• Rename Distance to DistanceFromPrevious
  Henry Lin · 2022-03-09 13:09:33 +08:00
  3ced5e7904
• Merge pull request #17161 from smoogipoo/fix-listing-score-conversion

  Fix scores not being recalculated in beatmap overlay

  Dean Herbert · 2022-03-09 13:32:45 +09:00
  affcf5180b
• Merge pull request #17152 from bdach/mod-overlay/difficulty-multiplier

  Implement difficulty multiplier display for new mod select design

  Dean Herbert · 2022-03-09 12:11:16 +09:00
  58aef25ad5
• Merge pull request #17158 from peppy/realm-recover-from-newer-database-version

  Add flow to allow recovery after running an older release (with a different realm database version)

  Dan Balasescu · 2022-03-09 11:30:58 +09:00
  b3fd156f10
• Merge pull request #17170 from peppy/fix-top-local-rank-test-failures-realm-callback

  Refactor top local rank test method to be more resilient to slow realm callbacks

  Dan Balasescu · 2022-03-09 11:14:37 +09:00
  810cbd745d
• Merge pull request #17169 from peppy/fix-song-select-test-failures-realm-callback

  Refactor song select test methods to be resilient to slow realm callbacks

  Dan Balasescu · 2022-03-09 11:14:26 +09:00
  af4423959c
• Merge pull request #17167 from peppy/fix-download-button-test-failure

  Fix potential test failure on slow realm callback in `TestSceneBeatmapDownloadButton`

  Dan Balasescu · 2022-03-09 01:49:23 +09:00
  714789f726
• Merge pull request #17166 from peppy/fix-realm-skin-dropdown-failure

  Fix potential crash on rare incorrect firing of skin dropdown update methods

  Dan Balasescu · 2022-03-09 01:46:31 +09:00
  74fe1e8e47
• Fix TestSceneTopLocalRank.TestHighScoreSet not waiting for potentially slow realm callback

  As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847.

  Dean Herbert · 2022-03-09 01:22:01 +09:00
  233c8232d3
• Refactor multiple TestScenePlaySongSelect test methods to be resilient to slow realm callbacks
  Dean Herbert · 2022-03-09 01:18:53 +09:00
  286bafe326
• Merge pull request #17165 from smoogipoo/fix-intermittent-test

  Fix intermittent multiplayer ready button test failures

  Dean Herbert · 2022-03-09 01:16:38 +09:00
  821de83e54
• Fix potential test failure on slow realm callback in TestSceneBeatmapDownloadButton

  As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847.

  Dean Herbert · 2022-03-09 01:11:46 +09:00
  56ad684f5b
• Fix potential crash on rare incorrect firing of skin dropdown update methods

  As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847.
  
  There's a chance that the dropdown is not populated by the time
  `updateSelectedSkinFromConfig` is fired via an external means (config
  changes).

  Dean Herbert · 2022-03-09 01:08:13 +09:00
  a2ef086c1f
• Fix intermittent test failure
  Dan Balasescu · 2022-03-09 00:48:12 +09:00
  729af28a64
• Fix test failure ripple through entire TestScene
  Dan Balasescu · 2022-03-09 00:48:03 +09:00
  94d5e2f264
• Fix score order related test failure
  Dan Balasescu · 2022-03-08 23:35:35 +09:00
  e9a2d23542
• Merge pull request #17157 from peppy/fix-statistics-json-serialisation

  Fix incorrect serialisation of submitted scores

  Dan Balasescu · 2022-03-08 20:20:31 +09:00
  a352a140bc
• Rework test scene by only relying on OnlineID
  Dan Balasescu · 2022-03-08 20:11:56 +09:00
  d13a66a96c
• Merge pull request #17160 from peppy/remove-unnecessary-user-submittable-score

  Remove `user` from `SubmittableScore`

  Dan Balasescu · 2022-03-08 19:34:47 +09:00
  4603e082f5
• Fix scores not being recalculated in beatmap listing
  Dan Balasescu · 2022-03-08 19:07:39 +09:00
  f5cd967635
• Merge pull request #17159 from smoogipoo/add-hitresult-helper

  Add IsBasic() and IsTick() extensions on HitResult

  Dean Herbert · 2022-03-08 18:46:39 +09:00
  e0dc3a04f3
• Remove user from SubmittableScore

  This wasn't being used by osu-web, and included far too much unnecessary
  data. Of note, `pp` and `ruleset_id` are also not strictly required, but
  there's no harm in sending them so I've left them be for now.

  Dean Herbert · 2022-03-08 18:38:24 +09:00
  b0f40d9e45
• Remove unused variable
  Dean Herbert · 2022-03-08 18:19:54 +09:00
  6565c95b17
• Add IsBasic() and IsTick() extensions on HitResult
  Dan Balasescu · 2022-03-08 18:19:12 +09:00
  a172fc6cb8
• Add flow to allow recovery after running an older release (with a different realm database version)

  As brought up in https://github.com/ppy/osu/discussions/17148

  Dean Herbert · 2022-03-08 18:15:28 +09:00
  0718a55ad0
• Add test coverage of SubmittableScore serialisation to (roughly) match spec
  Dean Herbert · 2022-03-08 17:58:52 +09:00
  9a347af5c7
• Add EnumMember naming to HitResult to allow for correct json serialisation
  Dean Herbert · 2022-03-08 17:58:37 +09:00
  589a40ca2d
• Merge pull request #17155 from peppy/beatmap-leaderboard-dont-handle-offset-changes

  Fix `BeatmapLeaderboard` refreshing on changes in local offset setting

  Dan Balasescu · 2022-03-08 15:38:05 +09:00
  719331420c
• Fix BeatmapLeaderboard refreshing on unrelated changes to a beatmap
  Dean Herbert · 2022-03-08 14:50:47 +09:00
  622ec53130
• Add extension method to detect and isolate realm collection-level changes
  Dean Herbert · 2022-03-08 14:50:47 +09:00
  2a55c5e02e
• Add xmldoc
  Henry Lin · 2022-03-08 12:07:10 +08:00
  ae1c65c38d
• Extract a major part of ApplyToBeatmap to a new method
  Henry Lin · 2022-03-08 11:50:30 +08:00
  8cfeffc085
• Separate randomisation and object positioning logic
  Henry Lin · 2022-03-08 11:45:16 +08:00
  ded84cab3f
• Better annotate initial rolling counter value set
  Bartłomiej Dach · 2022-03-07 23:11:20 +01:00
  643f68e844
• Show two decimal digits on mod multiplier rather than one
  Bartłomiej Dach · 2022-03-07 22:55:55 +01:00
  019f4d965d
• Use rolling counter for multiplier display
  Bartłomiej Dach · 2022-03-07 22:50:51 +01:00
  c25d7a1c75
• Implement basic difficulty multiplier display
  Bartłomiej Dach · 2022-03-07 22:50:51 +01:00
  78a3b5961e
• Merge pull request #17046 from peppy/clowd-squirrel

  Replace squirrel fork with `Clowd.Squirrel`

  Dan Balasescu · 2022-03-07 16:25:40 +09:00
  e0d2c8ca5e
• Merge pull request #17075 from peppy/realm-property-watching

  Add ability to watch properties via a `RealmAccess` helper method

  Dan Balasescu · 2022-03-07 14:38:23 +09:00
  51f6eb4028
• Merge branch 'master' into realm-property-watching
  Dean Herbert · 2022-03-07 13:53:17 +09:00
  31d6c75f40