33506 Commits

This Branch

This Branch

All Branches

• Resolve more CA1805 inspections
  Bartłomiej Dach · 2020-11-01 20:51:23 +01:00
  164370bc7d
• Resolve CA2249 inspections

  "Use `string.Contains` instead of `string.IndexOf` to improve
  readability"

  Bartłomiej Dach · 2020-11-01 18:54:44 +01:00
  3090b6ccb5
• Resolve CA1835 inspection

  "Change the `ReadAsync` method call to use the
  `Stream.ReadAsync(Memory<byte>, CancellationToken)` overload"

  Bartłomiej Dach · 2020-11-01 18:51:39 +01:00
  89bf7b1bd6
• Resolve CA1834 inspection

  "Use `StringBuilder.Append(char)` instead of
  `StringBuilder.Append(string)` when the input is a constant unit string"

  Bartłomiej Dach · 2020-11-01 18:50:13 +01:00
  ca5de22ca5
• Resolve CA1805 inspections

  "Member is explicitly initialized to its default value"

  Bartłomiej Dach · 2020-11-01 18:47:40 +01:00
  2b0bea535e
• Bump Microsoft.CodeAnalysis.FxCopAnalyzers from 3.0.0 to 3.3.1

  Bumps [Microsoft.CodeAnalysis.FxCopAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.0.0 to 3.3.1.
  - [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
  - [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md)
  - [Commits](https://github.com/dotnet/roslyn-analyzers/compare/v3.0.0...v3.3.1)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2020-11-01 17:14:13 +00:00
  6ff13e399a
• Merge pull request #10647 from bdach/beatmap-import-ensure-correct

  Ensure LoadOszIntoOsu returns actual imported map

  Dean Herbert · 2020-11-01 23:49:34 +09:00
  106bac1c6c
• Merge pull request #10634 from bdach/fix-leftover-selection-box-tooltip

  Fix selection box action tooltips still being visible after object deletion

  Dean Herbert · 2020-11-01 23:02:29 +09:00
  e1b8875553
• Ensure LoadOszIntoOsu returns actual imported map
  Bartłomiej Dach · 2020-11-01 14:25:33 +01:00
  8a54fdd4e6
• Merge pull request #10637 from peppy/fix-seasonal-backgrounds-nullref

  Fix potential null reference when loading background

  Bartłomiej Dach · 2020-10-31 17:36:16 +01:00
  7d090e0d2e
• Simplify test case
  Bartłomiej Dach · 2020-10-31 17:01:45 +01:00
  2065680e9d
• Fix potential null reference when loading background

  As seen in
  https://discordapp.com/channels/188630481301012481/188630652340404224/772094427342569493.
  Caused due to async load of the loader, which means it may not be ready
  before Next() is called.

  Dean Herbert · 2020-10-31 22:51:35 +09:00
  a9a3489e92
• Schedule visibility update once per frame
  Bartłomiej Dach · 2020-10-31 14:45:11 +01:00
  007c27d3ff
• Shorten show/hide code
  Bartłomiej Dach · 2020-10-31 13:54:02 +01:00
  d74c19e2d7
• Run OnSelectionChanged() on each change
  Bartłomiej Dach · 2020-10-31 13:54:02 +01:00
  3322b8a7ea
• Bind UpdateVisibility() directly to source of truth
  Bartłomiej Dach · 2020-10-31 13:54:02 +01:00
  003994ab75
• Merge pull request #10586 from hbnrmx/seasonal-backgrounds

  Add Seasonal backgrounds

  Dean Herbert · 2020-10-31 15:28:43 +09:00
  2020.1031.0 ea007af572
• Improve look & behaviour of background transitions
  Bartłomiej Dach · 2020-10-30 22:40:24 +01:00
  78842ab95a
• Fix typo in comment
  Bartłomiej Dach · 2020-10-30 22:39:34 +01:00
  391dd73843
• Change background to seasonal right after login
  Bartłomiej Dach · 2020-10-30 22:03:26 +01:00
  38cf90a69b
• Allow to fetch if going online after launch
  Bartłomiej Dach · 2020-10-30 21:49:14 +01:00
  29ad099902
• Add test coverage
  Bartłomiej Dach · 2020-10-30 21:48:09 +01:00
  8632f0d77f
• Move config setting logic to background loader
  Bartłomiej Dach · 2020-10-30 21:22:22 +01:00
  67a325f47d
• Document nullability of seasonal backgrounds
  Bartłomiej Dach · 2020-10-30 20:00:59 +01:00
  cf0e8e0a62
• Add xmldoc to SeasonalBackgroundMode
  Bartłomiej Dach · 2020-10-30 19:56:52 +01:00
  aeab2be5d1
• Rename lookup & field
  Bartłomiej Dach · 2020-10-30 19:55:22 +01:00
  20c27c6943
• Fix nullref when querying IsInSeason before request completion
  Bartłomiej Dach · 2020-10-30 19:35:08 +01:00
  82ef85569b
• Insert optional parentheses
  Max Hübner · 2020-10-30 18:07:07 +01:00
  d5dfd1dffe
• Fix nullref in case of successfull request but no backgrounds available
  Max Hübner · 2020-10-30 17:57:29 +01:00
  51a58269ad
• Move seasonalBackgroundMode check up and early return if available
  Max Hübner · 2020-10-30 17:16:51 +01:00
  0b46c19b23
• Save full api response in SessionStatics
  Max Hübner · 2020-10-30 16:43:18 +01:00
  f6eb5680ec
• Convert switch to if
  Max Hübner · 2020-10-30 16:06:48 +01:00
  6f6a8e2a8f
• IsInSeason() -> IsInSeason
  Max Hübner · 2020-10-30 15:56:19 +01:00
  d19dd4eef6
• Rename "SeasonalBackgrounds" to "SeasonalBackgroundMode"
  Max Hübner · 2020-10-30 15:54:10 +01:00
  4e3fb615d2
• Merge branch 'master' into seasonal-backgrounds
  Dean Herbert · 2020-10-30 22:53:51 +09:00
  1db8dfd03e
• Merge pull request #10622 from smoogipoo/fix-hud-test

  Fix HUD test having out of date value

  Dean Herbert · 2020-10-30 20:48:23 +09:00
  da54e9f591
• Make "Sometimes" setting depend on season end date, rather than chance
  Max Hübner · 2020-10-30 10:27:43 +01:00
  f27ce7521d
• Fix HUD test having out of date value
  smoogipoo · 2020-10-30 18:26:38 +09:00
  43f9c1ebea
• Merge pull request #10621 from peppy/hud-momentary-visibility

  Add momentary HUD toggle

  Dan Balasescu · 2020-10-30 15:40:54 +09:00
  0ef1459f4b
• Merge pull request #10620 from peppy/tracked-hud-visibility-settings

  Change shift-tab to cycle between available HUD visibility modes

  Dan Balasescu · 2020-10-30 15:40:39 +09:00
  fb6c88d39f
• Merge branch 'master' into tracked-hud-visibility-settings
  Dan Balasescu · 2020-10-30 14:58:45 +09:00
  b14291a312
• Add skinnable test scene for HUD overlay
  Dean Herbert · 2020-10-30 14:24:16 +09:00
  984a243eff
• Merge pull request #10370 from peppy/fix-test-beatmap-virtual-clock

  Ensure virtual track time is long enough for test beatmaps

  Dan Balasescu · 2020-10-30 14:23:06 +09:00
  8be16bd4ed
• Merge pull request #10614 from peppy/results-screen-animate-once

  Only play results panel animation once (and only for the local user)

  Dan Balasescu · 2020-10-30 14:21:05 +09:00
  45b8af5391
• Update test scene to be non-skinnable (and add test covering momentary display)
  Dean Herbert · 2020-10-30 14:20:00 +09:00
  bd7871d9f5
• Add key binding to show HUD while held
  Dean Herbert · 2020-10-30 14:19:40 +09:00
  8928aa6d92
• Commit missing test pieces
  Dean Herbert · 2020-10-30 14:00:07 +09:00
  53bd31c69e
• Commit missing pieces
  Dean Herbert · 2020-10-30 13:53:51 +09:00
  b4eda65383
• Remove "hide during breaks" option

  Probably wouldn't be used anyway.

  Dean Herbert · 2020-10-30 13:49:45 +09:00
  c72017a7db
• Change shift-tab to cycle available HUD visibility modes
  Dean Herbert · 2020-10-30 13:09:22 +09:00
  9bb86ccb83