66577 Commits

This Branch

This Branch

All Branches

• Fix #27105: Mod search box doesnt track external focus changes

  In the Mod selection area, the search bar's focus could be changed by pressing TAB.
  However, when clicking outside of the search bar, the focus would be killed but two TABs were required to get the focus back on the search bar.
  This happened because the action of clicking in an empty area would trigger the search bar to change its appearence, but not its internal state.
  In my solution, I made the OnClick function aware of the search bar's state, so it would not only change its appearance, but also its state.
  Now, after clicking in an empty area, there is only needed one TAB to select the search box again, as expected.

  Mafalda Fernandes · 2024-04-03 14:06:11 +01:00
  16276dfcd6
• Merge pull request #27779 from smoogipoo/fix-skineditor-external-event-bind

  Fix SkinEditor binding event to external bindable

  Bartłomiej Dach · 2024-04-03 12:05:41 +02:00
  ca525f6a91
• Merge branch 'master' into fix-skineditor-external-event-bind
  Bartłomiej Dach · 2024-04-03 11:42:15 +02:00
  6d6412afdf
• Only interact with clipboard via bound copy
  Bartłomiej Dach · 2024-04-03 11:39:12 +02:00
  05fe8968d8
• Merge pull request #27778 from smoogipoo/fix-spectator-player-rentention

  Fix SpectatorClient holding references to Player

  Bartłomiej Dach · 2024-04-03 11:30:34 +02:00
  3b7d427c52
• Fix SkinEditor binding event to external bindable
  Dan Balasescu · 2024-04-03 17:46:26 +09:00
  ce68f6adb7
• Fix SpectatorClient holding references to Player
  Dan Balasescu · 2024-04-03 17:32:02 +09:00
  b5adcf2e0e
• Merge pull request #27747 from smoogipoo/mania-key-count-mod-query

  Consider keymods in beatmap filtering + panel display

  Bartłomiej Dach · 2024-04-03 09:49:35 +02:00
  fd9b890a94
• Merge branch 'master' into mania-key-count-mod-query
  Bartłomiej Dach · 2024-04-03 09:29:32 +02:00
  cb82fb0487
• Replace usages of is null with == null
  Dean Herbert · 2024-04-03 01:50:39 +08:00
  94cbe1838f
• Merge pull request #27768 from 64ArthurAraujo/editor-fix-sliders-same-start-time-merge

  Fix merging sliders with the same `StartTime` causing a Unhandled Exception

  Dean Herbert · 2024-04-03 01:45:55 +08:00
  aa7b357063
• Fix remove additional blank line
  Arthur Araujo · 2024-04-02 08:48:01 -03:00
  9315aefe41
• Check if blueprint is in SelectionBlueprints before changing its depth
  Arthur Araujo · 2024-04-02 07:45:27 -03:00
  2a2a372595
• Merge pull request #26702 from honguyenminh/fix-rotate-editor-button-disabled

  Fix rotate tool button in editor disabled when selecting 1 circle

  Dean Herbert · 2024-04-02 14:31:43 +08:00
  51e9348d27
• Update plurals in editor rotate button tooltip

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Nguyên Minh Hồ · 2024-04-02 12:36:44 +07:00
  6642702fa9
• Change tooltip text slightly
  Dean Herbert · 2024-04-02 13:17:16 +08:00
  eca242c1c7
• Bind using local bindables to avoid potentially event pollution
  Dean Herbert · 2024-04-02 13:04:34 +08:00
  ed5dd5c8cd
• Fully qualify LegacyBeatmapConversionDifficultyInfo
  Dan Balasescu · 2024-04-01 17:02:32 +09:00
  8e0ca11d1c
• Replace schedule with SequenceEqual()
  Dan Balasescu · 2024-04-01 17:02:02 +09:00
  d12a2e7df7
• Merge pull request #27698 from bdach/banish-rulesets-that-do-stupid-crap-to-the-BLAGOLE

  Attempt to disable custom rulesets that can be linked to an unhandled crash

  Dean Herbert · 2024-04-01 15:47:47 +08:00
  95b50576bd
• Merge pull request #27761 from 64ArthurAraujo/editor-fix-control-points-update-on-stacking

  Update Slider path control points and connections after stacking application

  Dan Balasescu · 2024-04-01 16:17:51 +09:00
  8160ffa353
• Use local bindable instead

  Binding events directly to an external bindable will cause that
  bindable to hold a permanent reference to the current object.
  
  We use `GetBoundCopy()` or otherwise a local bindable + `.BindTo()` to create a
  weak-referenced copy of the target bindable. When the local bindable's
  lifetime expires, so does the external bindable's reference to it.

  Dan Balasescu · 2024-04-01 15:31:35 +09:00
  099ad22a92
• Fix inspection
  Dan Balasescu · 2024-04-01 15:28:20 +09:00
  7615c71efe
• Fix wrong formatting in array creation
  Arthur Araujo · 2024-03-31 13:39:19 -03:00
  19f0caa0f3
• Merge branch 'fix-rotate-editor-button-disabled' of https://github.com/honguyenminh/osu into fix-rotate-editor-button-disabled
  Nguyên Minh Hồ · 2024-03-31 16:00:58 +07:00
  1adba68357
• Change editor rotate button disabled tooltip text

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Nguyên Minh Hồ · 2024-03-31 16:00:47 +07:00
  86def7e263
• Merge pull request #27760 from EVAST9919/better-break-arrows

  Fix break overlay arrows look ugly on bright backgrounds

  Dean Herbert · 2024-03-31 10:24:32 +08:00
  c17ce3362b
• Bind StackHeight changes to visual update methods
  Arthur Araujo · 2024-03-30 21:23:05 -03:00
  450e7016bc
• Adjust blurred icons position due to size handling differences
  Andrei Zavatski · 2024-03-31 01:55:34 +03:00
  11b1135804
• Simplify glowing icons in break overlay
  Andrei Zavatski · 2024-03-31 01:44:54 +03:00
  58a68e94af
• Decouple GlowingDrawable from GlowingSpriteText
  Andrei Zavatski · 2024-03-31 01:44:54 +03:00
  54472e6452
• Aggregate two CanRotate bindable for enabling the Rotate button
  Nguyên Minh Hồ · 2024-03-30 17:54:27 +07:00
  b445e27ad6
• Fix inspection
  Nguyên Minh Hồ · 2024-03-30 17:28:57 +07:00
  6f782266b5
• Simplify TooltipText for EditorRadioButton
  Nguyên Minh Hồ · 2024-03-30 16:04:22 +07:00
  5d497ba4a8
• Fix editor rotation allowing spinner only bug
  Nguyên Minh Hồ · 2024-03-30 16:02:31 +07:00
  8d6358a138
• Merge branch 'fix-rotate-editor-button-disabled' of https://github.com/honguyenminh/osu into fix-rotate-editor-button-disabled
  Nguyên Minh Hồ · 2024-03-30 13:57:44 +07:00
  9950395e5f
• Merge branch 'master' into fix-rotate-editor-button-disabled
  Nguyên Minh Hồ · 2024-03-30 13:56:31 +07:00
  113dbcd10f
• Merge pull request #27758 from peppy/fix-mascot-size

  Fix taiko mascot size not matching stable

  Salman Ahmed · 2024-03-29 23:53:24 +03:00
  93f1578c10
• Fix URL pointing to non-existent commit
  Salman Ahmed · 2024-03-29 23:33:06 +03:00
  51f79c33e1
• Fix taiko mascot size not matching stable
  Dean Herbert · 2024-03-29 22:40:04 +08:00
  c21805589e
• Merge pull request #27756 from bdach/pp-on-results-provisional

  Apply partial fade on pp display on results screen when score will not give pp

  Dan Balasescu · 2024-03-29 19:57:59 +09:00
  48f8d9c916
• Merge pull request #27755 from peppy/fix-import-weirdness

  Avoid reporting an import as successful when all beatmaps failed to import

  Bartłomiej Dach · 2024-03-29 11:25:41 +01:00
  5371141d3b
• Apply partial fade on pp display on results screen when score will not give pp
  Bartłomiej Dach · 2024-03-29 11:16:31 +01:00
  e06df34a1c
• Remove redundant string interpolation
  Bartłomiej Dach · 2024-03-29 10:37:49 +01:00
  2d3b273974
• Fix failing test due to missing ruleset store
  Dean Herbert · 2024-03-29 17:32:20 +08:00
  df4a28db91
• Merge pull request #27748 from smoogipoo/update-diffcalc-gha

  Update action versions in diffcalc workflow

  Bartłomiej Dach · 2024-03-29 10:25:41 +01:00
  320ca04d98
• Merge pull request #27754 from peppy/multi-binding-fix

  Fix double binding causing game crash after API enters failing state

  Bartłomiej Dach · 2024-03-29 10:21:33 +01:00
  5c7fdeca35
• Avoid reporting an import as successful when all beatmaps failed to import
  Dean Herbert · 2024-03-29 17:11:55 +08:00
  233b9eb172
• Fix bindable not being correctly re-bound across local user changes
  Dean Herbert · 2024-03-29 15:50:10 +08:00
  d9cf5b5440
• Fix double binding causing game crash after API enters failing state

  See https://sentry.ppy.sh/organizations/ppy/issues/33406/?alert_rule_id=4&alert_timestamp=1711655107332&alert_type=email&environment=production&project=2&referrer=alert_email

  Dean Herbert · 2024-03-29 12:19:14 +08:00
  fef8afb833