Bartłomiej Dach
15fb1a099e
Modify assert to avoid false failures
...
In headless tests it was possible for TestInstantLoad() to erroneously
fail. There were two scenarios in which LoadingSpinner could be null:
1. If the test runner was quick enough, the assert could end up running
even before Loader.OnEntering() had even had a chance to, meaning
that the spinner was never even actually assigned to or instantiated
at that point in time.
2. Even if Loader.OnEntering() had managed to run, there was also
a possibility that the spinner itself wasn't loaded at the point
of checking the assertion. As the spinner is accessed through
ChildrenOfType(), which only checks InternalChildren and ignores
all currently-loading drawables, it would therefore return null.
As null != 0, both of these cases would actually fail the test (this is
best seen running headless, preferably with a [Repeat] attribute
attached).
To resolve, allow the spinner to be null at the point of asserting and
duplicate the assertion step at the end. This weakens the test, as case
(1) should probably be waited for and case (2) could be solved with
exposition as protected in the base, but when attempting to wait for
the loader itself to be loaded there were also cases where the
appropriate until step would take so much time that the spinner would
actually become visible in line with the delayed display logic, so this
is a best-effort attempt to address both points without radical
changes.
2020-03-28 00:43:57 +01:00
Dean Herbert
4f77850790
Merge pull request #8467 from peppy/update-framework
...
Update framework
2020-03-27 21:22:39 +09:00
Dean Herbert
6ecfeb8cc3
Merge pull request #8455 from Game4all/handle-novideo-beatmaps
...
Fix NullReferenceException when starting the no-video version of a beatmap with video
2020-03-27 21:12:40 +09:00
Dean Herbert
5be8934c8c
Merge pull request #8407 from peppy/disable-raw-input
...
Disable raw input toggle on all but windows
2020-03-27 21:10:02 +09:00
Dean Herbert
f25b1b33e3
Merge pull request #8461 from peppy/fix-minia-mod-replay-recording
...
Fix osu!mania replays recording incorrectly when key mod applied
2020-03-27 20:55:58 +09:00
Dean Herbert
4106700771
Update framework
2020-03-27 20:51:44 +09:00
Dan Balasescu
3763457a1d
Merge pull request #8451 from peppy/fix-slider-end-sounds
...
Only play slider end sounds if tracking
2020-03-27 20:38:59 +09:00
Dean Herbert
fdbffbd1db
Merge pull request #8452 from peppy/add-slider-judgement-accuracy
...
Make slider judgements count towards base score / accuracy
2020-03-27 20:37:26 +09:00
Lucas A
6788b7f9cd
Add test for loading storyboards with missing video file.
2020-03-27 12:07:47 +01:00
Dean Herbert
abb5bb14dd
Merge pull request #8450 from peppy/reduce-fruit-spread
...
Reduce spread of stacked fruit
2020-03-27 19:57:54 +09:00
Dan Balasescu
5e1cb0e9e9
Merge branch 'master' into fix-minia-mod-replay-recording
2020-03-27 19:26:41 +09:00
Dan Balasescu
04b34791cd
Merge branch 'master' into add-slider-judgement-accuracy
2020-03-27 19:26:34 +09:00
Dan Balasescu
005a818f32
Merge branch 'master' into fix-slider-end-sounds
2020-03-27 19:26:32 +09:00
Dan Balasescu
378a957b33
Merge branch 'master' into reduce-fruit-spread
2020-03-27 19:19:23 +09:00
Dan Balasescu
2bbff632c2
Merge pull request #8447 from peppy/fix-break-overlay-scaling
...
Fix break overlay scaling with gameplay
2020-03-27 19:18:51 +09:00
Dean Herbert
f75c082601
Fix osu!mania replays recording incorrectly when key mod applied
2020-03-27 15:50:11 +09:00
Lucas A
01c9112f82
Add a null check to prevent NRE when playing the "no video" version of a beatmap.
2020-03-26 17:09:22 +01:00
Dean Herbert
f80efd10c2
Avoid using a miss judgement
2020-03-26 19:54:17 +09:00
Dean Herbert
6555ab6ede
Only play slider end sounds if tracking
2020-03-26 17:18:27 +09:00
Dean Herbert
8e4896fbbe
Make slider judgements count towards base score / accuracy
2020-03-26 17:13:53 +09:00
Dean Herbert
2949e8dc27
Reduce spread of stacked fruit
2020-03-26 16:58:23 +09:00
Dean Herbert
07462120e4
Split break tracking into its own component
2020-03-26 15:30:23 +09:00
Dean Herbert
d372ddaadd
Move break overlay to a location it is not affected by gameplay scale
2020-03-26 12:50:18 +09:00
Dean Herbert
2b1245f63a
Improve xmldoc in a couple of places
2020-03-26 12:50:00 +09:00
Dean Herbert
a141e2e8b7
Merge pull request #8441 from EVAST9919/fix-panel-message
...
Fix last seen date being visible in user panel when it shouldn't
2020-03-26 10:15:23 +09:00
Andrei Zavatski
454e402e88
Fix last seen message has been visible when it shouldn't
2020-03-25 21:02:45 +03:00
Andrei Zavatski
1e025b7c31
Add tests to cover the issue
2020-03-25 20:58:51 +03:00
Dan Balasescu
1587d4b26f
Merge pull request #8428 from peppy/replay-recording
...
Add local replay support for all rulesets
2020-03-25 22:02:04 +09:00
Dean Herbert
deec7642ff
Merge branch 'master' into replay-recording
2020-03-25 21:21:20 +09:00
Dan Balasescu
9f617ba301
Merge pull request #8427 from peppy/basic-replay-recorder
...
Add replay recorder functionality
2020-03-25 21:15:20 +09:00
Dean Herbert
8a2aac5f83
Rename conversion methods for clarity
2020-03-25 20:21:34 +09:00
Dean Herbert
800e395bc8
Merge branch 'master' into replay-recording
2020-03-25 20:20:59 +09:00
Dan Balasescu
d341b16bbb
Merge branch 'master' into basic-replay-recorder
2020-03-25 19:37:39 +09:00
Dan Balasescu
e7f32d951d
Merge pull request #8431 from peppy/fix-intro-tests
...
Fix intro tests not asserting pass or working at all
2020-03-25 19:25:26 +09:00
Dan Balasescu
791bf95396
Merge pull request #8433 from peppy/fix-song-select-looping
...
Fix track looping state not being reset when entering editor from song select
2020-03-25 19:21:18 +09:00
Dean Herbert
ebe3cf2966
Merge pull request #8430 from peppy/remove-unused-transform-helpers
...
Remove unused text transform helpers
2020-03-25 15:50:33 +09:00
Dean Herbert
b1d4261402
Fix track looping state not being reset when entering editor from song select
...
Closes #8432 .
2020-03-25 15:50:19 +09:00
Dean Herbert
880d138a47
Fix intro tests not asserting pass or working at all
2020-03-25 15:12:19 +09:00
Dean Herbert
87db1ba487
Remove unused text transform helpers
2020-03-25 14:58:49 +09:00
Dean Herbert
f414b7fbb6
Merge pull request #8167 from voidedWarranties/video-offset
...
Start background video playback based on provided offset
2020-03-25 13:05:18 +09:00
voidedWarranties
b8f20831a1
Video no longer modifies storyboard resolution
2020-03-24 20:04:09 -07:00
Dean Herbert
f2e0fba164
Remove VideoFile from BeatmapMetadata
...
Leaving in database because it's a pain to drop columns.
2020-03-25 12:00:02 +09:00
Dean Herbert
6d81da5419
Merge branch 'master' into video-offset
2020-03-25 11:28:59 +09:00
Dean Herbert
cf890efa42
Merge pull request #8426 from voidedWarranties/storyboard-masking
...
Allow individual storyboard layers to disable masking
2020-03-25 11:28:36 +09:00
Dean Herbert
368bf58521
Rename and make fields readonly
2020-03-25 11:08:08 +09:00
Dean Herbert
971249338d
Merge branch 'master' into storyboard-masking
2020-03-25 11:05:40 +09:00
Dean Herbert
7818251c3e
Merge pull request #8406 from smoogipoo/taiko-random-mod
...
Implement random mod for taiko
2020-03-24 17:11:49 +09:00
Dean Herbert
e31acbd592
Merge pull request #8414 from Joehuu/fix-select-filter-not-absorbing-input
...
Fix song select filter and footer not absorbing input from carousel
2020-03-24 16:37:50 +09:00
Dean Herbert
4070b2b75f
Merge branch 'basic-replay-recorder' into replay-recording
2020-03-24 16:31:14 +09:00
Dean Herbert
cc1863ca3d
Merge branch 'master' into basic-replay-recorder
2020-03-24 16:26:13 +09:00
