Dan Balasescu
|
132bb59203
|
Update working beatmap when returning to match
|
2021-11-24 19:56:02 +09:00 |
|
Dan Balasescu
|
88b968fbe8
|
Merge pull request #15783 from peppy/close-failed-update-notification
Close a failed update notification immediately
|
2021-11-24 19:46:33 +09:00 |
|
Dan Balasescu
|
e176083898
|
Merge pull request #15781 from peppy/beatmap-set-status
Rename `BeatmapSetOnlineStatus` to `BeatmapOnlineStatus`
|
2021-11-24 19:25:29 +09:00 |
|
Dan Balasescu
|
30037fbec1
|
Merge pull request #15780 from peppy/combine-test-beatmap-set-info-usage
Combine all test data `BeatmapSetInfo` creation into a single method
|
2021-11-24 19:09:35 +09:00 |
|
Dean Herbert
|
1dc1de3d1f
|
Close a failed update notification immediately
Fixes visual issue pointed out at
https://github.com/ppy/osu/discussions/15653#discussioncomment-1679263.
|
2021-11-24 19:05:53 +09:00 |
|
Dean Herbert
|
183b95cbc2
|
Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus
This variable is used at more than just a set level.
|
2021-11-24 18:42:49 +09:00 |
|
Dean Herbert
|
0fe27cc8a1
|
Replace one more usage
|
2021-11-24 18:29:33 +09:00 |
|
Dean Herbert
|
7603f7eb36
|
Fix a few incorrectly updated arguments
|
2021-11-24 18:14:18 +09:00 |
|
Dean Herbert
|
0c819b9cfb
|
Combine all test data BeatmapSetInfo creation into a single method
|
2021-11-24 18:07:32 +09:00 |
|
Dan Balasescu
|
5ff62a8e04
|
Merge pull request #15779 from peppy/remaining-misc-fixes
Apply some various code quality fixes that don't fit elsewhere
|
2021-11-24 16:59:49 +09:00 |
|
Dan Balasescu
|
74b6c33fab
|
Merge pull request #15778 from peppy/ruleset-info-id-usage
Update usages of `RulesetInfo.ID` to use `OnlineID` instead
|
2021-11-24 16:55:28 +09:00 |
|
Dan Balasescu
|
834bdd8e5c
|
Merge pull request #15776 from peppy/non-null-beatmapset-metadata
Make `BeatmapSet.Metadata` non-null
|
2021-11-24 16:48:28 +09:00 |
|
Dan Balasescu
|
8ce5324c8b
|
Merge pull request #15772 from peppy/remove-model-list-inits
Initialise `BeatmapSet.Beatmaps` list at construction time
|
2021-11-24 16:41:19 +09:00 |
|
Dean Herbert
|
2dabedebff
|
Remove unnecessary user assign in HitObjectSampleTest
|
2021-11-24 16:30:00 +09:00 |
|
Dean Herbert
|
3e0e01abdb
|
Move bookmark parsing logic into LegacyBeatmapDecoder
|
2021-11-24 16:29:51 +09:00 |
|
Dean Herbert
|
9c61ec217b
|
Remove unnecessary mainTrackMixer parameter from BeatmapManager
|
2021-11-24 16:27:17 +09:00 |
|
Dan Balasescu
|
2ec3fb2e9e
|
Merge pull request #15760 from peppy/realm-move-data-migration-to-context-factory
Move realm data migrations inside the `RealmContextFactory`
|
2021-11-24 16:23:56 +09:00 |
|
Dan Balasescu
|
f6e91f1824
|
Merge pull request #15777 from smoogipoo/revert-nunit-blame
Revert "Run nunit in blame mode"
|
2021-11-24 16:23:22 +09:00 |
|
Dean Herbert
|
bbd3ea5b77
|
Update all actual usages of RulesetInfo.ID to use OnlineID instead
|
2021-11-24 15:50:26 +09:00 |
|
Dean Herbert
|
f283770f34
|
Update mock RulesetInfo usage to set OnlineID instead of ID
|
2021-11-24 15:50:26 +09:00 |
|
Dean Herbert
|
e57c343531
|
Add helper setter to EF RulesetInfo.OnlineID to allow updating usages
|
2021-11-24 15:50:26 +09:00 |
|
Dan Balasescu
|
eff1293b5b
|
Revert "Run nunit in blame mode"
This reverts commit 215c179b92.
|
2021-11-24 15:26:40 +09:00 |
|
Dean Herbert
|
db2d8b6d8b
|
Fix ruleset instance creation null checks
|
2021-11-24 15:25:56 +09:00 |
|
Dan Balasescu
|
33d95fbb9c
|
Merge pull request #15771 from peppy/ruleset-config-cache-shortname
Update `RulesetConfigCache` to cache via `ShortName` instead of `ID`
|
2021-11-24 15:24:57 +09:00 |
|
Dan Balasescu
|
73e50af9cc
|
Merge pull request #15775 from peppy/update-framework
Update framework
|
2021-11-24 15:24:43 +09:00 |
|
Dean Herbert
|
cb093e1e01
|
Remove reundant self-sets of metadata
|
2021-11-24 15:08:04 +09:00 |
|
Dean Herbert
|
3946a39b65
|
Make BeatmapSet.Metadata non-null
|
2021-11-24 15:03:34 +09:00 |
|
Dean Herbert
|
44c34ca7b2
|
Revert changes causing BeatmapSet.Metadata to be expectedly null in some tests
|
2021-11-24 14:52:08 +09:00 |
|
Dan Balasescu
|
c4b5a07f4b
|
Merge branch 'master' into realm-move-data-migration-to-context-factory
|
2021-11-24 14:40:26 +09:00 |
|
Dan Balasescu
|
5b88e4d7b5
|
Merge pull request #15741 from peppy/realm-ruleset-keybinding-short-name
Switch realm ruleset key bindings to use ruleset's `ShortName` as key
|
2021-11-24 14:38:57 +09:00 |
|
Dean Herbert
|
a7853fc9cc
|
Fix cases of known-non-null
|
2021-11-24 14:26:25 +09:00 |
|
Dean Herbert
|
ec89dfa043
|
Update framework
|
2021-11-24 14:09:25 +09:00 |
|
Dean Herbert
|
0aedbbe165
|
Fix incorrect fallback logic causing test failure
|
2021-11-24 14:04:55 +09:00 |
|
Dan Balasescu
|
cf17c51df2
|
Merge pull request #15770 from peppy/fix-incorrect-id-usage-in-tests
Fix incorrect usage of `ID` in `TestSceneMultiplayerResults`
|
2021-11-24 13:51:30 +09:00 |
|
Dan Balasescu
|
5a0a95f9d4
|
Trim whitespace
|
2021-11-24 13:48:59 +09:00 |
|
Dan Balasescu
|
84268c3d85
|
Merge branch 'master' into realm-ruleset-keybinding-short-name
|
2021-11-24 13:48:48 +09:00 |
|
Dan Balasescu
|
6183d1cd46
|
Merge pull request #15769 from peppy/model-equality-consistency
Update cases where equality can be used instead of primary key equality
|
2021-11-24 13:45:57 +09:00 |
|
Dan Balasescu
|
6ffba8a546
|
Merge pull request #15768 from peppy/standardise-ruleset-create-instance
Remove nullability of `Ruleset.CreateInstance`
|
2021-11-24 13:43:23 +09:00 |
|
Dean Herbert
|
a3fdab34d5
|
Avoid json serialisation of aggregate helper properties
Also avoids `throw`ing when there are no beatmaps available. Until now
this wasn't an issue due to the `Beatmaps` list being null instead of empty.
|
2021-11-24 13:36:34 +09:00 |
|
Dean Herbert
|
8c60f37508
|
Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment
|
2021-11-24 13:27:37 +09:00 |
|
Dean Herbert
|
49c2cb9125
|
Initialise BeatmapSet.Beatmaps list to line up with realm expectations
|
2021-11-24 13:25:55 +09:00 |
|
Dean Herbert
|
ee22c24370
|
Update RulesetConfigCache to cache via ShortName instead of ID
|
2021-11-24 13:10:18 +09:00 |
|
Dean Herbert
|
b1f3e98045
|
Fix incorrect usage of ID in TestSceneMultiplayerResults
|
2021-11-24 13:05:51 +09:00 |
|
Dean Herbert
|
729f681938
|
Update cases where equality can be used instead of primary key equality
|
2021-11-24 12:49:57 +09:00 |
|
Dean Herbert
|
6aed41eacc
|
Merge branch 'master' into realm-move-data-migration-to-context-factory
|
2021-11-24 12:38:44 +09:00 |
|
Dean Herbert
|
63b09b356f
|
Rewrite commments to read better
|
2021-11-24 12:37:09 +09:00 |
|
Dean Herbert
|
6cd1bfd94f
|
Remove outdated comment
|
2021-11-24 12:35:05 +09:00 |
|
Dean Herbert
|
0eea026afb
|
Remove null checks on CreateInstance() calls
|
2021-11-24 12:23:09 +09:00 |
|
Dean Herbert
|
8d69ebd7db
|
Remove nullability of Ruleset.CreateInstance
|
2021-11-24 12:23:06 +09:00 |
|
Dean Herbert
|
049f25a133
|
Merge pull request #15757 from smoogipoo/fix-multiplayer-tests
Fix several intermittent multiplayer test failures
|
2021-11-24 09:32:01 +09:00 |
|