75266 Commits

This Branch

This Branch

All Branches

• Skip updating window title for protected mapsets
  Zihad · 2025-03-05 22:47:39 +06:00
  d33a8dfc3b
• Remove unnecessary comment
  Zihad · 2025-03-05 21:41:11 +06:00
  4ae5f239cb
• Revert "Update window title in input thread"

  This reverts commit 14b5c0bf10.
  This is not necessary as the title update is already scheduled on the correct thread by the framework.

  Zihad · 2025-03-05 21:40:29 +06:00
  5feddae6c7
• Merge pull request #32235 from bdach/screw-this-feature-who-is-it-even-for

  Fix "use these mods" context menu option doing broken things with system mods

  Dan Balasescu · 2025-03-05 23:43:30 +09:00
  3f211e33b8
• Add forgotten partials
  Dan Balasescu · 2025-03-05 23:25:22 +09:00
  26daf085d7
• Add "discard unsaved changes" operation to beatmap editor

  Apparently useful in modding workflows when you want to test out a few
  different variants of a thing.
  
  Re-uses `Ctrl-L` binding from stable. Some folks may argue that the
  dialog makes the hotkey pointless, but I really do want to protect
  users from accidental data loss, and also if you want to power through
  it quickly, you can hit the 1 key when the dialog shows, which will
  bypass the hold-to-activate period (which wasn't intentional, but so
  many people want a bypass at this point that we're probably keeping that
  behaviour for power users).

  Bartłomiej Dach · 2025-03-05 14:34:44 +01:00
  3f461c0734
• Block input to screen during gameplay
  Dan Balasescu · 2025-03-05 22:12:48 +09:00
  51f794a566
• Reset mods when exiting to lounge

  To be hoenst, this is all quite abusive but I'm not sure how to do it in
  any better way. I especially dislike the fact that the screen's
  bindables are disabled yet the screen itself is allowed to set their
  value because they're `LeasedBindable`s.
  
  But I feel better doing this in a central location like this
  `ScreenStack` than in the rooms... Otherwise this specific behaviour
  would have to be replicated in the multiplayer screen when it goes
  through the same refactoring.

  Dan Balasescu · 2025-03-05 21:45:51 +09:00
  f887846311
• Merge branch 'master' into room-subscreen-split
  Dan Balasescu · 2025-03-05 20:41:44 +09:00
  4709ebd593
• Try to fix test
  Bartłomiej Dach · 2025-03-05 12:32:58 +01:00
  7975c301a8
• Fix "use these mods" option showing if it can't do anything

  Closes https://github.com/ppy/osu/issues/32230.

  Bartłomiej Dach · 2025-03-05 09:40:11 +01:00
  0ac3a80406
• Add another failing test
  Bartłomiej Dach · 2025-03-05 09:39:52 +01:00
  097dd70139
• Fix "use these mods" option applying to system mods

  Closes https://github.com/ppy/osu/issues/32229.

  Bartłomiej Dach · 2025-03-05 09:25:56 +01:00
  d9a1dcf9b9
• Add failing test coverage
  Bartłomiej Dach · 2025-03-05 09:21:47 +01:00
  abc4955e81
• Merge pull request #32199 from bdach/negative-leaderboard-position

  Fix playlists results screens potentially displaying negative score positions

  Dan Balasescu · 2025-03-05 16:13:12 +09:00
  f6cf63edae
• Update property name in line with web changes
  Bartłomiej Dach · 2025-03-05 08:05:15 +01:00
  3661107e4f
• Rename test scene to match new RoomListing class name
  Dean Herbert · 2025-03-05 13:51:56 +09:00
  9ca1274495
• Skip updating window title in headless mode
  Zihad · 2025-03-04 20:36:53 +06:00
  8ce6003a3e
• Update window title in input thread
  Zihad · 2025-03-04 19:56:48 +06:00
  14b5c0bf10
• Change ModSelectOverlay.ShowPresets to init
  Dean Herbert · 2025-03-04 22:32:13 +09:00
  dff354247e
• Merge pull request #31867 from smoogipoo/remove-selectedroom

  Remove `SelectedRoom` from online play tests

  Dean Herbert · 2025-03-04 21:56:30 +09:00
  0d3e66fbfa
• Skip window title update for dummy beatmap
  Zihad · 2025-03-04 18:28:03 +06:00
  2abe75629e
• Add UI for assigning custom tags to beatmaps

  Visual part for https://github.com/ppy/osu/issues/31913. Opening
  separately for appropriate visual UI adjustments.
  
  Also mostly ready to be hooked up to the results screen, pending merge
  of https://github.com/ppy/osu-web/pull/11951.

  Bartłomiej Dach · 2025-03-04 13:08:02 +01:00
  c051ff84d2
• Show current beatmap info in window title
  Zihad · 2025-03-04 17:15:35 +06:00
  b5696f97a0
• Use alternative method of offsetting X that conveys flow better
  Dean Herbert · 2025-03-04 19:40:31 +09:00
  21d35f9dae
• Merge branch 'master' into remove-selectedroom
  Dean Herbert · 2025-03-04 19:21:05 +09:00
  c31a5dcdae
• Split out methods so retrieving the room is not a callback function
  Dean Herbert · 2025-03-04 19:19:53 +09:00
  918315aa65
• Merge pull request #32098 from bdach/dont-drop-green-line-sample-bank

  Attempt to preserve sample control point bank when encoding beatmap

  Dean Herbert · 2025-03-04 18:32:16 +09:00
  d9162daac2
• Merge pull request #32218 from peppy/fix-editor-creation-test-failures
  Dean Herbert · 2025-03-04 18:22:13 +09:00
  43259075ec
• Add transition for selecting a beatmap
  Dean Herbert · 2025-03-04 18:09:58 +09:00
  1be3b990e7
• Add basic subclassing and implement beatmap-start flow
  Dean Herbert · 2025-03-04 17:44:48 +09:00
  f0d6641adf
• Merge pull request #32214 from smoogipoo/fix-multi-user-kick-threading

  Fix thread safety when kicking multiplayer users

  Bartłomiej Dach · 2025-03-04 09:24:08 +01:00
  28be0e31c2
• Remove duplicated assert
  Dan Balasescu · 2025-03-04 17:22:19 +09:00
  5b0e54a77d
• Merge pull request #32219 from peppy/lounge-minor-redesign

  Adjust scale and display of rooms in multiplayer lounge

  Dan Balasescu · 2025-03-04 17:19:58 +09:00
  e0e7d92e79
• Update recently-added test
  Dan Balasescu · 2025-03-04 17:01:41 +09:00
  b19c2c7f9f
• Merge branch 'master' into remove-selectedroom
  Dan Balasescu · 2025-03-04 17:00:43 +09:00
  cf3664349d
• Fix typo in xmldoc
  Dean Herbert · 2025-03-04 16:15:40 +09:00
  2025.304.0 4a16b4bd98
• Merge pull request #32217 from smoogipoo/fix-mp-channel

  Fix multiplayer not joining correct chat channel

  Dean Herbert · 2025-03-04 16:15:20 +09:00
  667bd6e8f1
• Merge pull request #32075 from Gennadiyev/patch-result-screen-volume-adjust

  Add Alt + mousewheel volume adjustment on result screens

  Dean Herbert · 2025-03-04 16:06:46 +09:00
  c9a492a6eb
• Adjust scale and display of rooms in multiplayer lounge

  Just a quick pass because the rooms were definitely larger than they
  should be.

  Dean Herbert · 2025-03-04 15:55:44 +09:00
  4085ee805a
• Merge pull request #31866 from smoogipoo/remove-roommanager

  Remove `RoomManager`, centralise listing management to lounge

  Dean Herbert · 2025-03-04 15:52:59 +09:00
  5318c370d4
• Attempt to fix common editor test failures

  See
  https://github.com/ppy/osu/actions/runs/13623586844/job/38143232417?pr=32180
  for one example.
  
  Arguably the bindable usage in
  [`ControlPointPart`](https://github.com/ppy/osu/blob/2365b065a4994f38fe67bab7d193e5a09bee538c/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/ControlPointPart.cs#L24-L26)
  is dangerous, but it's only dangerous in tests (because control points
  aren't mutated outside the editor) so I'm willing to turn a blind eye
  for now to favour async loading support.

  Dean Herbert · 2025-03-04 15:51:08 +09:00
  a0888a7f2c
• Rename RoomsContainer and scope down bindables
  Dean Herbert · 2025-03-04 15:05:12 +09:00
  9e8a611728
• Fix multiplayer not joining correct chat channel
  Dan Balasescu · 2025-03-04 14:45:23 +09:00
  77d5b1d5dd
• LoungePollingComponent -> LoungeListingPoller
  Dean Herbert · 2025-03-04 14:40:55 +09:00
  0696cfa4f2
• Merge branch 'master' into remove-roommanager
  Dean Herbert · 2025-03-04 14:23:51 +09:00
  f3e9d1931c
• Merge branch 'master' into fix-multi-user-kick-threading
  Dean Herbert · 2025-03-04 14:21:38 +09:00
  6ba9491cea
• Merge pull request #32215 from smoogipoo/fix-broken-test

  Fix broken test

  Dean Herbert · 2025-03-04 14:20:55 +09:00
  45e0446e19
• Fix broken test
  Dan Balasescu · 2025-03-04 14:14:42 +09:00
  b73a872b94
• Fix thread safety when kicking multiplayer users
  Dan Balasescu · 2025-03-04 14:02:45 +09:00
  4a00662092