75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #32149 from peppy/preview-time-display

  Adjust preview time display to not conflict with bookmarks

  Dan Balasescu · 2025-02-28 16:14:44 +09:00
  89b6d7caee
• Adjust x offsets to work again for keyboard selection
  Dean Herbert · 2025-02-28 16:08:11 +09:00
  02b950223c
• Merge pull request #32151 from peppy/mania-barline

  Add support for legacy osu!mania barline height and colour spec

  Dan Balasescu · 2025-02-28 16:05:47 +09:00
  f9c73e6501
• Fix API room host not being populated
  Dan Balasescu · 2025-02-28 15:52:02 +09:00
  a09ef5d96d
• Add failing test
  Dan Balasescu · 2025-02-28 15:51:54 +09:00
  306b30cb12
• Add support for legacy osu!mania barline height and colour spec
  Dean Herbert · 2025-02-28 15:13:13 +09:00
  cb29459a1e
• Add basic setup for mania legacy barline implementation
  Dean Herbert · 2025-02-28 14:43:00 +09:00
  3e8dafa3c5
• Adjust preview time display to not conflict with bookmarks
  Dean Herbert · 2025-02-28 14:05:49 +09:00
  e1723ec1bb
• Inline some methods
  Dean Herbert · 2025-02-28 13:25:21 +09:00
  a659936c57
• Fix settings control not visible because of previous search

  This also makes `SettingsPanel`'s `SearchTextBox` protected from private so that `SettingsOverlay` can access it.

  Zihad · 2025-02-28 00:24:12 +06:00
  0913174099
• Merge pull request #32130 from bdach/fix-sliders-visible-but-not-selectable-harder
  Dean Herbert · 2025-02-28 00:38:03 +09:00
  7f99e60cfd
• Fix sliders not being selectable if the body is hidden but the head is still visible

  Closes https://github.com/ppy/osu/issues/31998.
  
  Previously: https://github.com/ppy/osu/commit/1648f2efa306f587714178f113e69d8ad8c4ac02,
  https://github.com/ppy/osu/pull/31923.
  
  Oh input handling, how I love ya.

  Bartłomiej Dach · 2025-02-27 15:00:29 +01:00
  5b318edbfb
• Merge pull request #32110 from bdach/combo-colour-count-limit

  Limit number of allowed beatmap combo colours to 8

  Bartłomiej Dach · 2025-02-27 12:13:06 +01:00
  79b737bc27
• Disable button instead of hiding (and add tooltip)
  Dean Herbert · 2025-02-27 15:15:58 +09:00
  0b453772da
• Refactor post-join setup to not pass delegates around
  Dan Balasescu · 2025-02-27 14:50:35 +09:00
  47ca5c90a5
• Merge branch 'master' into room-management-lio
  Dan Balasescu · 2025-02-27 14:14:19 +09:00
  a33aff9bbd
• Disallow attempting to close multiplayer rooms
  Dan Balasescu · 2025-02-27 13:39:16 +09:00
  d31588939c
• Fix typo
  Dan Balasescu · 2025-02-27 13:16:51 +09:00
  d3c4afe65d
• Merge pull request #32111 from bdach/prevent-closing-team-channels-harder

  Prevent closing team chat channels via Ctrl-W

  Dean Herbert · 2025-02-27 12:55:54 +09:00
  2025.227.0 66b8b527e3
• Merge branch 'master' into tip-pressure-threshold-option
  Nathan Corbett · 2025-02-26 12:09:20 -08:00
  12e769128c
• Merge pull request #31595 from ppy/pp-dev

  January 2025 Diffcalc/PP release

  Dean Herbert · 2025-02-27 01:17:42 +09:00
  003adadbf3
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-27 00:08:43 +09:00
  87b6dddd11
• Prevent closing team chat channels via Ctrl-W

  As pointed out in
  https://github.com/ppy/osu/pull/32079#issuecomment-2680297760.
  
  The comment suggested putting that logic in `ChannelManager` but
  honestly I kinda don't see it working out. It'd probably be multiple
  boolean arguments for `leaveChannel()` (because `sendLeaveRequest` or
  whatever already exists), and then there's this one usage in tournament
  client:
  
  	https://github.com/ppy/osu/blob/31aded69714cf205c215893368d1f148c9a73319/osu.Game.Tournament/Components/TournamentMatchChatDisplay.cs#L57-L58
  
  I'm not sure how that would interact with this particular change, but I
  think there is a nonzero possibility that it would interact badly. So in
  general I kinda just prefer steering clear of all that and adding a
  local one-liner.

  Bartłomiej Dach · 2025-02-26 12:06:50 +01:00
  f3632a466f
• Merge pull request #32108 from peppy/adjust-leaderboard-design-slightly

  Adjust leaderboard score design slightly

  Bartłomiej Dach · 2025-02-26 11:28:39 +01:00
  31aded6971
• Do not allow adding more than 8 combo colours in editor
  Bartłomiej Dach · 2025-02-26 11:24:06 +01:00
  6b76b8ccdd
• Limit beatmap encoder & decoder to at most 8 combo colours
  Bartłomiej Dach · 2025-02-26 11:13:57 +01:00
  2167c7b8d5
• Add failing encoder test case for too many combo colours
  Bartłomiej Dach · 2025-02-26 11:10:33 +01:00
  e48d36ad1e
• Cleanup score fetching a bit
  Dan Balasescu · 2025-02-26 18:58:29 +09:00
  c2875423ee
• Add failing decoder test case for too many combo colours
  Bartłomiej Dach · 2025-02-26 10:56:28 +01:00
  76bf03b05d
• Merge pull request #32107 from peppy/fix-player-team-flag-replay

  Fix `PlayerTeamFlag` skinnable component not showing team details during replay

  Bartłomiej Dach · 2025-02-26 10:36:49 +01:00
  38d807e846
• Add support to tests

  Somewhat informal because it isn't super easy to handle.

  Dan Balasescu · 2025-02-26 18:31:06 +09:00
  c280c8fa1c
• Replace error handling with logs

  - Handling all errors matches master a little bit better. Logging
  exceptions in any case.
  - Not throwing when beatmaps are missing simplifies tests.

  Dan Balasescu · 2025-02-26 18:02:13 +09:00
  3dde024650
• Mostly revert sizes
  Dean Herbert · 2025-02-26 18:00:18 +09:00
  c45a403fe2
• Update test coverage
  Dean Herbert · 2025-02-26 17:57:10 +09:00
  896caf4a8d
• Add back right-click-for-new-combo and right-click-delete when in compose mode

  Requested too many times to count.
  
  I'm not sure what to do about the code quality of this. It's a bit weird
  that there's no way to check the current composition tool from a higher
  level.
  
  Also it was discussed IRL that there should be some kind of hinting that
  existing notes will be deleted when they are hovered, but I'm not sure
  how well this will work in normal mapping flows, since it will display
  even in cases that users aren't intending to delete an object. Still
  willing to explore this direction though (it's just non-trivial to
  implement so I haven't yet).

  Dean Herbert · 2025-02-26 17:52:33 +09:00
  2738c1a807
• Add missing ConfigureAwait
  Dan Balasescu · 2025-02-26 17:39:56 +09:00
  c7fd7cf9cd
• Adjust leaderboard score design slightly

  This design is about to get replaced, so I'm just making some minor
  adjustments since a lot of people complained about the font size in the
  last update.
  
  Of note, I'm only changing the font size which is one pt size lower than
  we'd usually use. Also overlapping the mod icons to create a bit more
  space (since there's already cases where they don't fit).
  
  Closes https://github.com/ppy/osu/issues/32055 as far as I'm concerned.
  I can read everything fine at 0.8x UI scale.

  Dean Herbert · 2025-02-26 17:01:51 +09:00
  e8b7ec0f95
• Fix PlayerTeamFlag skinnable component not showing team details during replay

  For now, let's fetch on demand.
  
  Note that song select local leaderboard has the same issue. I feel we should be
  doing a lot more cached lookups (probaly with persisting across game restarts).
  Maybe even replacing the realm user storage. An issue for another day.

  Dean Herbert · 2025-02-26 16:48:18 +09:00
  abc12abded
• Include author
  Dan Balasescu · 2025-02-26 15:04:43 +09:00
  b7d431fdde
• Prefer local models where available
  Dan Balasescu · 2025-02-26 15:04:37 +09:00
  59cfcb3595
• Fix score panel difficulty depending on local beatmap

  This is a very special case where online beatmap/ruleset models are
  being ferried via `ScoreInfo` in what appear to `BeatmapDifficultyCache`
  as local `BeatmapInfo`/`RulesetInfo` models. Here, BDC will incorrectly
  attempt to proceed with calculating true difficulty where it cannot, and
  return 0.
  
  This is fixed locally because `ScoreInfo` is a very weird model, and I'm
  not sure whether BDC should contain logic to work around this.

  Dan Balasescu · 2025-02-26 14:49:00 +09:00
  90290997a7
• Attempt to preserve sample control point bank when encoding beatmap

  This was reported internally in
  https://discord.com/channels/90072389919997952/1259818301517725707/1343470899357024286.
  The issue described was that sample specifications on control points in
  stable disappeared after the beatmap was updated from lazer.
  
  The reason why the sample specifications were getting dropped is that
  they got lost in the logic that attempts to translate per-hitobject
  samples that lazer has back into stable "green line" type control
  points. That process only attempted to preserve volume and custom sample
  bank, but did not keep the standard bank - likely because it's kind of
  superfluous information *for correct sample playback of the objects*, as
  the samples get encoded again for each object individually. However
  dropping this information makes for a subpar editing experience.
  
  The choice of which sample to pick the bank from is sort of arbitrary
  and I'm not sure if there's a correct one to pick. Intuitively picking
  the normal sample's bank (if there is one) seems most correct.

  Bartłomiej Dach · 2025-02-25 15:39:35 +01:00
  65a62d5440
• Fix loading spinners not hiding correctly
  Dan Balasescu · 2025-02-25 23:17:23 +09:00
  baf20d8484
• Clean up completion handling
  Dan Balasescu · 2025-02-25 23:17:02 +09:00
  bb457ca8e2
• ConfigureAwait(false) everywhere
  Dan Balasescu · 2025-02-25 22:56:38 +09:00
  116b5a335a
• Arrays instead of enumerables
  Dan Balasescu · 2025-02-25 22:55:55 +09:00
  3b5bf391da
• Replace virtual async method with better abstraction
  Dan Balasescu · 2025-02-25 22:51:36 +09:00
  8a27b6689e
• Populate playlists results screen with online beatmaps
  Dan Balasescu · 2025-02-25 22:37:12 +09:00
  dfae11101f
• Make results screens use tasks to fetch scores
  Dan Balasescu · 2025-02-25 21:54:16 +09:00
  13ca8c20f6
• Merge pull request #32077 from bdach/double-click-difficulty-slider-nub

  Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

  Dean Herbert · 2025-02-25 21:08:46 +09:00
  2025.225.0 b3965f0dd0