h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-10 21:40:34 +08:00
Code Issues Releases Wiki Activity

Prevent closing team chat channels via Ctrl-W

Browse Source 
As pointed out in
https://github.com/ppy/osu/pull/32079#issuecomment-2680297760.

The comment suggested putting that logic in `ChannelManager` but
honestly I kinda don't see it working out. It'd probably be multiple
boolean arguments for `leaveChannel()` (because `sendLeaveRequest` or
whatever already exists), and then there's this one usage in tournament
client:

	31aded6971/osu.Game.Tournament/Components/TournamentMatchChatDisplay.cs (L57-L58)

I'm not sure how that would interact with this particular change, but I
think there is a nonzero possibility that it would interact badly. So in
general I kinda just prefer steering clear of all that and adding a
local one-liner.
This commit is contained in:
Bartłomiej Dach 2025-02-26 12:01:30 +01:00
parent 31aded6971
commit f3632a466f
No known key found for this signature in database
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Overlays/ChatOverlay.cs
View File

@ -228,7 +228,8 @@ namespace osu.Game.Overlays
return true;
case PlatformAction.DocumentClose:
channelManager.LeaveChannel(currentChannel.Value);
if (currentChannel.Value?.Type != ChannelType.Team)
channelManager.LeaveChannel(currentChannel.Value);
return true;
case PlatformAction.TabRestore: