75266 Commits

This Branch

This Branch

All Branches

• Remove unnecessary conditionals
  Dean Herbert · 2025-03-25 17:13:13 +09:00
  68cdb60bee
• Merge pull request #32540 from frenzibyte/mod-rich-tooltip

  Display mod tooltips in rich form

  Dean Herbert · 2025-03-25 16:44:43 +09:00
  6dbd6a7e7b
• Merge pull request #32566 from peppy/fix-double-placeholders

  Fix overlapping placeholders in beatmap info leaderboard

  Dan Balasescu · 2025-03-25 16:43:37 +09:00
  6b9313a93f
• Remove pointless left-over code
  Dean Herbert · 2025-03-25 16:43:22 +09:00
  1bb85bab89
• Add tests
  Dan Balasescu · 2025-03-25 16:25:02 +09:00
  3ff05b7330
• Make test headless
  Dan Balasescu · 2025-03-25 16:19:46 +09:00
  0392af3d4b
• Add multiplayer user mod display
  Dan Balasescu · 2025-03-25 16:17:54 +09:00
  6cd4a36c61
• Fix storyboards with no-op alpha operations causing extended drawable lifetimes

  Test with https://osu.ppy.sh/beatmapsets/139525#osu/348550. See
  https://github.com/ppy/osu/issues/32453#issuecomment-2742562780 (and
  inline comments) for explanation.
  
  Closes https://github.com/ppy/osu/issues/32453.

  Dean Herbert · 2025-03-25 16:14:33 +09:00
  203e294e49
• Make class partial
  Dan Balasescu · 2025-03-25 16:11:51 +09:00
  d9efa08673
• Remove unnecessary ruleset store
  Dan Balasescu · 2025-03-25 16:08:13 +09:00
  b83a69b029
• Partial classes
  Dan Balasescu · 2025-03-25 16:05:33 +09:00
  5793ad4a63
• Add tests for multiplayer implementation
  Dan Balasescu · 2025-03-25 16:03:56 +09:00
  a1894c9193
• Adjust tests to add tracker to hierarchy
  Dan Balasescu · 2025-03-25 15:41:03 +09:00
  bc2b7aae1c
• Split tracker into per-system implementations
  Dan Balasescu · 2025-03-25 14:56:12 +09:00
  53ece9396a
• Fix christmas menu track potentially playing out of season

  Closes https://github.com/ppy/osu/issues/32502.

  Dean Herbert · 2025-03-25 14:48:51 +09:00
  0d8f328fe6
• Fix overlapping placeholders in beatmap info leaderboard

  Closes https://github.com/ppy/osu/issues/32508.

  Dean Herbert · 2025-03-25 14:27:24 +09:00
  9630002a68
• Refactor tracker to be a bit more stateless

  Removes storage of `selectedBeatmap` that was referenced through
  multiple class-level methods.
  
  To expound a bit, this structure felt better (or otherwise passing
  `APIBeatmap` through methods) alongside removal of the `#nullable
  disable`, otherwise each method would check `selectedBeatmap != null`.

  Dan Balasescu · 2025-03-25 14:23:05 +09:00
  72b56146ee
• Refactor multiplayer background to remove selected item bindable
  Dan Balasescu · 2025-03-25 13:56:40 +09:00
  748e890ee4
• Merge pull request #32428 from evilldev/show-full-rank

  Show full rank in extended results screen

  Dean Herbert · 2025-03-25 01:18:19 +09:00
  1b0c60cff5
• Merge pull request #32551 from smoogipoo/basic-freestyle-validation

  Validate freestyle selection post-selection

  Bartłomiej Dach · 2025-03-24 14:08:20 +01:00
  d0cdacea79
• Merge pull request #32550 from peppy/taiko-hit-animations

  Fix taiko legacy skins playing scale animations even when skins contain animations

  Bartłomiej Dach · 2025-03-24 13:41:09 +01:00
  3e297bdb9d
• Merge branch 'master' into show-full-rank
  Bartłomiej Dach · 2025-03-24 12:56:20 +01:00
  c631e7a1c5
• Fix inconsistent formatting
  Bartłomiej Dach · 2025-03-24 12:30:03 +01:00
  334b1e85bc
• Add extra test coverage
  Bartłomiej Dach · 2025-03-24 12:28:46 +01:00
  f6dd2e4ac2
• Fix code quality
  Bartłomiej Dach · 2025-03-24 12:28:40 +01:00
  130d0c8b70
• Merge pull request #32460 from smoogipoo/refactor-match-footer

  Refactor multiplayer match footer

  Bartłomiej Dach · 2025-03-24 12:14:57 +01:00
  fdcf40d4a6
• Validate freestyle selection post-selection
  Dan Balasescu · 2025-03-24 17:38:43 +09:00
  303d0c56c3
• Merge pull request #32532 from frenzibyte/sheared-dropdown

  Implement sheared dropdowns

  Dean Herbert · 2025-03-24 16:34:42 +09:00
  5b191dad8f
• Fix taiko legacy skins playing scale animations even when skins contain animations

  Closes https://github.com/ppy/osu/issues/32477.
  
  Can be tested using
  https://drive.google.com/drive/folders/1HUCsTL_iqCGPCyruSSfdSoxL19EQuy_a.

  Dean Herbert · 2025-03-24 16:14:32 +09:00
  bb998ad687
• Apply shearing to dropdown menu as well

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2025-03-24 02:18:11 -04:00
  4cd631f9f9
• Merge pull request #32495 from bdach/some-more-activities

  Adjust user activity updates

  Dan Balasescu · 2025-03-24 12:53:12 +09:00
  6d7e94f58e
• Merge pull request #32546 from frenzibyte/fix-external-resource-lookup

  Fix images embedded in comments not displaying

  Dan Balasescu · 2025-03-24 12:36:16 +09:00
  89de22c5af
• Apply better fix for background bleeding

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Salman Alshamrani · 2025-03-23 22:27:51 -04:00
  b2c9a572fa
• Fix images embedded in comments not displaying
  Salman Alshamrani · 2025-03-23 21:38:36 -04:00
  655c799c58
• Add failing test case
  Salman Alshamrani · 2025-03-23 21:38:36 -04:00
  b3d572029f
• Add extra margin below description text
  Salman Alshamrani · 2025-03-23 13:46:19 -04:00
  54eb0b33b0
• Update mod preset tooltip design accordingly
  Salman Alshamrani · 2025-03-23 13:43:38 -04:00
  623e705704
• Introduce rich mod tooltip
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  9b55325526
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a
• Adjust user activity updates

  - Changed copy of the multiplayer spectator activity to be
    ruleset-agnostic, thus I guess closing
    https://github.com/ppy/osu/issues/32307 maybe? There is still the
    ruleset icon in discord RPC but that one is taken from the game-global
    ruleset so it's a bit more involved to fix.
  
  - Added new activities for daily challenge screens, therefore partially
    addressing https://github.com/ppy/osu/discussions/29200. I didn't add
    skin editor because (a) it's not easy to make work because skin editor
    isn't a screen and (b) I'm not sure we want that to begin with? Kind
    of a weird one.
  
  I've tested backwards compatibility; old server will raise exceptions
  that then will be logged as unobserved by the clients when receiving the
  new statuses, and an old client, when given one of the new statuses by a
  new server, seems to completely ignore it. Seems pretty acceptable to
  me.

  Bartłomiej Dach · 2025-03-23 11:50:59 +01:00
  429819e68b
• Merge pull request #32531 from frenzibyte/footer-v2-fix-mod-button

  Fix mod select footer overlapping with mod unranked indicator

  Dean Herbert · 2025-03-23 17:48:56 +09:00
  589c8aba4b
• Merge pull request #32389 from wezwery/show-mode-name-in-empty-field

  Show the mod name in LeaderboardScoreTooltip.ModCell, instead of an empty field.

  Dean Herbert · 2025-03-23 17:14:50 +09:00
  5832ba8dcb
• Add sheared dropdown
  Salman Alshamrani · 2025-03-22 22:49:34 -04:00
  25e404c734
• Add test coverage
  Salman Alshamrani · 2025-03-22 22:15:02 -04:00
  b6068e6e29
• Fix mod select footer overlapping with mod unranked indicator
  Salman Alshamrani · 2025-03-22 22:14:56 -04:00
  0cc7cb0245
• Change mod select colour scheme to aquamarine in new song select
  Salman Alshamrani · 2025-03-22 21:25:30 -04:00
  3b53e221d6
• Merge pull request #32504 from smoogipoo/fix-duplicate-test-runs

  Fix `osu.Game.Tests` tests running twice

  Dean Herbert · 2025-03-22 22:03:10 +09:00
  882b449df2
• Merge pull request #32358 from peppy/clickable-things-results-screen

  Make username and beatmap information clickable at results screen

  Joseph Madamba · 2025-03-21 12:54:08 -07:00
  5a53eed426
• Merge remote-tracking branch 'upstream/master' into pr/32358
  Joseph Madamba · 2025-03-21 12:09:09 -07:00
  3354170c7c
• Fix partial errors
  Joseph Madamba · 2025-03-21 12:08:10 -07:00
  0802eff1b8