75266 Commits

This Branch

This Branch

All Branches

• Fix "no results" placeholder having weird transitions
  Salman Alshamrani · 2025-05-21 15:44:49 +03:00
  3f2ba893ba
• Merge pull request #33210 from bdach/strict-tracking-rewind

  Fix Strict Tracking running miss-on-tracking-loss logic during rewind

  Dan Balasescu · 2025-05-21 21:27:01 +09:00
  0ca7e359b8
• Merge pull request #33191 from peppy/fix-aggressive-diffcalc

  Reduce difficulty calculation churn overheads when using keyboard to iterate quickly at song select

  Dan Balasescu · 2025-05-21 20:48:14 +09:00
  662cbfcc48
• Resolve inspections
  Dan Balasescu · 2025-05-21 20:00:05 +09:00
  f967091aad
• Merge pull request #33208 from tsunyoku/increase-diff-calc-ci-timeout

  Increase diff calc processor timeout minutes

  Dan Balasescu · 2025-05-21 19:55:30 +09:00
  ec7e82ddfa
• Merge pull request #33203 from frenzibyte/carousel-select-first-visible

  Fix carousel potentially selecting filtered difficulty

  Dean Herbert · 2025-05-21 18:15:48 +09:00
  275dcca4b5
• Show loading spinner underneath user tags during transitions
  Salman Alshamrani · 2025-05-20 23:52:40 +03:00
  135fc47766
• Add test for metadata wedge loading transitions
  Salman Alshamrani · 2025-05-20 23:52:40 +03:00
  c23abe818c
• Use better method to select first difficulty
  Salman Alshamrani · 2025-05-20 21:42:19 +03:00
  59b0ab7f46
• Merge pull request #33200 from frenzibyte/fix-song-select-test

  Fix song select tests not loading footer buttons with dependencies

  Dean Herbert · 2025-05-21 00:40:30 +09:00
  23bd1e5d72
• Merge pull request #33207 from frenzibyte/ssv2-hook-mod-to-selected-beatmap

  SongSelectV2: Hook mod select overlay to selected beatmap

  Dean Herbert · 2025-05-21 00:38:36 +09:00
  c5ec25358d
• Merge pull request #33205 from frenzibyte/carousel-disable-status-animation

  Disable status pill animation on carousel panels

  Dean Herbert · 2025-05-21 00:37:49 +09:00
  420a49b812
• Add property to allow disabling status pill animation
  Salman Alshamrani · 2025-05-21 00:37:08 +09:00
  c565b76b6e
• Merge pull request #33202 from frenzibyte/hidden-beatmap-difficulties

  Fix hidden beatmap difficulties not handled in new carousel

  Dean Herbert · 2025-05-21 00:33:36 +09:00
  875414a47a
• Add very basic transition for DifficultyIcon colour changes
  Dean Herbert · 2025-05-20 22:12:03 +09:00
  d9c376067d
• Fix Strict Tracking running miss-on-tracking-loss logic during rewind

  Probably closes https://github.com/ppy/osu/issues/29945.

  Bartłomiej Dach · 2025-05-20 14:17:16 +02:00
  3a136a4c81
• Add failing test case
  Bartłomiej Dach · 2025-05-20 14:17:15 +02:00
  b2de486aec
• Increase diff calc processor timeout minutes
  tsunyoku · 2025-05-20 11:29:46 +01:00
  a1bdbd8ec3
• Add demonstrative test coverage of combo accounting being order-agnostic
  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  1576001491
• Adjust combo accounting in score processor to be order-agnostic

  Closes https://github.com/ppy/osu/issues/21732.
  
  While the problem of multiple judgements in one frame and ordering of
  `RevertResult()` calls as described in the issue is a real one, this
  commit is a bit of a sidestep of the entire issue.
  
  The idea here that while *snapshots* of instantaneous combo values are
  susceptible to such ordering foibles on revert, *deltas* are not - and
  such, when deltas are using to update the combo counts on revert,
  ordering stops mattering so much.

  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  237de1ef72
• Add protective test coverage of combo accounting
  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  561578c0e9
• Add failing test case
  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  b60cf08635
• Fix solo results screen tests better

  See 12b09586c7.

  Bartłomiej Dach · 2025-05-20 12:10:07 +02:00
  6a56ed1d3b
• Merge pull request #33199 from pe1agio/iss32064

  Fix inconsistent display of rotation in tooltip when dragging selection box rotation handles

  Bartłomiej Dach · 2025-05-20 12:02:08 +02:00
  687c0e5cc0
• Fix solo results screen test failure

  As spotted in https://github.com/ppy/osu/pull/33191/checks?check_run_id=42460062656
  
  Seems like just a bog-standard race. Could be reproduced via
  
  diff --git a/osu.Game/Screens/Ranking/SoloResultsScreen.cs b/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  index d11e7db178..1a594fd21b 100644
  --- a/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  +++ b/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  @@ -45,6 +45,8 @@ protected override async Task<ScoreInfo[]> FetchScores()
               if (Score.BeatmapInfo!.OnlineID <= 0 || Score.BeatmapInfo.Status <= BeatmapOnlineStatus.Pending)
                   return [];
  
  +            await Task.Delay(5000).ConfigureAwait(false);
  +
               var criteria = new LeaderboardCriteria(
                   Score.BeatmapInfo!,
                   Score.Ruleset,

  Bartłomiej Dach · 2025-05-20 11:09:18 +02:00
  12b09586c7
• Merge pull request #33194 from bdach/mania-hold-rewind

  Fix hold notes getting incorrectly missed after rewinding gameplay

  Dan Balasescu · 2025-05-20 16:48:26 +09:00
  17819ba592
• Fix incorrect translation of note freezing logic
  Bartłomiej Dach · 2025-05-20 08:58:11 +02:00
  bd703b60f9
• Merge pull request #33115 from bdach/fix-snapping-to-loading-grid

  Fix distance snap grid being used before it's ready for use

  Dan Balasescu · 2025-05-20 12:46:39 +09:00
  e97c757084
• Hook mod select overlay to selected beatmap
  Salman Alshamrani · 2025-05-20 01:14:42 +03:00
  fc436553a8
• Merge branch 'master' into iss32064
  Nuno Pelágio · 2025-05-19 21:17:23 +01:00
  7893b885c5
• Fix carousel potentially selecting filtered diff when clicking set panel
  Salman Alshamrani · 2025-05-19 22:33:24 +03:00
  e2e156c6ba
• Add failing test case
  Salman Alshamrani · 2025-05-19 22:31:08 +03:00
  2a70e2485b
• Fix hidden beatmap difficulties not handled in new carousel
  Salman Alshamrani · 2025-05-19 22:02:41 +03:00
  ce1da54af4
• Add failing test case
  Salman Alshamrani · 2025-05-19 22:02:41 +03:00
  cc3aeca5a7
• Fix ppy#32064: Fixed Formatting.
  Nuno Pelagio · 2025-05-19 20:00:24 +01:00
  dc86b77f80
• Fix song select tests not loading footer buttons with dependencies
  Salman Alshamrani · 2025-05-19 20:45:24 +03:00
  5333221e71
• Merge pull request #33192 from peppy/fix-multiplayer-position-display-two-player

  Fix multiplayer position display looking wrong when player count is low

  Bartłomiej Dach · 2025-05-19 13:04:22 +02:00
  9d438bac29
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Add failing test case
  Bartłomiej Dach · 2025-05-19 11:38:42 +02:00
  3d4763bdb5
• Fix case where there's only one player causing NaN

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-05-19 18:25:41 +09:00
  962ec3dca0
• Fix multiplayer position display looking wrong when player count is low

  Spotted when watching video in #33173's opening post.

  Dean Herbert · 2025-05-19 16:58:01 +09:00
  beb77176b6
• Merge pull request #33189 from peppy/fix-clock-animation

  Fix analog clock animation not animating when hand crosses zero

  Bartłomiej Dach · 2025-05-19 09:39:45 +02:00
  34e5c7ee42
• Add animation to star rating display in new carousel

  Also matches the animation speed of `StarRatingDisplay` with
  `StarCounter` as they are regularly displayed together.

  Dean Herbert · 2025-05-19 16:30:58 +09:00
  eb29c45513
• Aggressively cancel difficulty calculation for new beatmap carousel usages

  This was already being done on the old carousel (see `ApplyState`
  methods) but wasn't correctly on new carousel.
  
  Importantly, `FreeAfterUse` alone is not enough due to transitions. We
  want to immediately stop calculation as soon as a panel is marked
  non-visible.
  
  There's no bindable flow for this so it's performed in `Update`. I don't
  see this as an issue.

  Dean Herbert · 2025-05-19 16:18:54 +09:00
  3a532013ac
• Start with known star rating for no-mod-no-convert rather than zero

  This makes displays look better, even if it's incorrect momentarily.

  Dean Herbert · 2025-05-19 16:18:54 +09:00
  01edee123f
• Add debounce to difficulty calculation operations in churn scenarios
  Dean Herbert · 2025-05-19 16:16:33 +09:00
  192a1642d4
• Merge pull request #33178 from peppy/fix-footer-button-thing

  Fix footer buttons not restoring when exiting an already displayed screen

  Bartłomiej Dach · 2025-05-19 09:02:07 +02:00
  5ae39819b6
• Merge pull request #33162 from smoogipoo/photon-release

  Add "Tachyon" (unstable) release stream

  Dean Herbert · 2025-05-19 15:27:35 +09:00
  c339977e98
• Fix analog clock animation not animating when hand crosses zero

  Pointed out in
  [discord](https://discord.com/channels/188630481301012481/188630652340404224/1373836064313180200).

  Dean Herbert · 2025-05-19 15:08:15 +09:00
  8aedfb81ff
• Set isFirstRun flag on all operating systems
  Dean Herbert · 2025-05-19 14:55:51 +09:00
  9ad57162b0