75266 Commits

This Branch

This Branch

All Branches

• Fix mod change tracker not being hooked up if mods are present on load
  Dean Herbert · 2025-05-25 20:42:13 +09:00
  bd71c2ce52
• Add back missing using statement
  Dean Herbert · 2025-05-25 20:41:36 +09:00
  48fe2a6723
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Merge pull request #33175 from frenzibyte/carousel-grouping

  Add support for most grouping modes

  Dean Herbert · 2025-05-25 01:31:55 +09:00
  77953aaee4
• Change back to using Vector2.Distance instead of length, keep order of before-after consistent
  Chris Ehmann · 2025-05-23 22:33:04 -07:00
  a4e78a34ac
• Add back two missing actions for beatmap set headers
  Dean Herbert · 2025-05-24 11:28:12 +09:00
  a1426eb8be
• Merge branch 'ppy:master' into fix-distance-snapping-to-stacks
  Chris · 2025-05-23 15:10:16 -07:00
  3d8ab823e3
• Change OsuDistanceSnapProvider to use StackedPosition when determining distance between notes
  Chris Ehmann · 2025-05-23 12:36:16 -07:00
  441c941039
• Remove obsoleted flow by using a new configuration variable

  The old one wasn't used anyway.

  Dean Herbert · 2025-05-24 01:01:17 +09:00
  cd44cab3ff
• Handle star difficulty grouping in a way which doesn't require arbitrary nullable data
  Dean Herbert · 2025-05-23 19:49:24 +09:00
  dc519441f9
• Fix weird todo comments..
  Dean Herbert · 2025-05-23 19:43:05 +09:00
  6555e45367
• Fix typo in comment
  Dean Herbert · 2025-05-23 19:37:22 +09:00
  ff48c4a047
• Merge branch 'master' into carousel-grouping
  Dean Herbert · 2025-05-23 19:03:09 +09:00
  0a5fbb35c5
• Fix nasty bug associated with reusing a single panel wrong
  Bartłomiej Dach · 2025-05-23 11:45:25 +02:00
  9742f48437
• Merge pull request #33239 from bdach/analysis-container-test-failure

  Attempt to fix test failures in osu! replay analysis container test

  Dean Herbert · 2025-05-23 18:11:55 +09:00
  faa73f5d04
• Add extra test coverage for multiplayer participants list in team versus
  Bartłomiej Dach · 2025-05-23 10:47:50 +02:00
  fea50ee432
• Refactor team display to fit with pooling better
  Bartłomiej Dach · 2025-05-23 10:47:36 +02:00
  17cf5df668
• Fix tests post-pooling implementation
  Bartłomiej Dach · 2025-05-23 10:47:23 +02:00
  231afbf463
• Implement pooling in multiplayer participants list
  Bartłomiej Dach · 2025-05-23 10:47:07 +02:00
  61e8c25a92
• Modify many users tests to stress it & demonstrate transform overhead
  Bartłomiej Dach · 2025-05-23 10:46:50 +02:00
  40a4129776
• Merge pull request #33209 from bdach/mania-combo-accounting-rewind

  Fix combo accounting when rewinding mania replays

  Dean Herbert · 2025-05-23 16:47:36 +09:00
  fa92fbb9d1
• Add context menus to new carousel panels

  This changes the flow of actions (yet again.. sorry) to standardise what
  is shown on the beatmap options button in the footer and the context
  menus.
  
  This is something I wanted from the start – for devices where right
  click is not available, it's always preferable to have a second method
  of accessing actions which isn't the context menu.
  
  Collection actions are missing for now, as they will come in a second
  pass which includes tidying things up further.
  
  Fix formatting
  
  Duplicate menu items between implementations

  Dean Herbert · 2025-05-23 16:02:13 +09:00
  891f0c469f
• Add icon specification to OsuMenuItem

  This isn't used visually for context menus, but is handy to have when
  using this class to convey more general information about actions,
  including usages outside of context menus where an icon is relevant to
  have.

  Dean Herbert · 2025-05-23 15:46:52 +09:00
  1cf4636d31
• Add context menu container to song select and required tests
  Dean Herbert · 2025-05-23 15:43:46 +09:00
  02a54fa428
• Add action to select and start a provided beatmap
  Dean Herbert · 2025-05-23 15:42:49 +09:00
  db7f66dd09
• Use a fixed clock
  Bartłomiej Dach · 2025-05-23 08:29:45 +02:00
  44feb7814e
• Merge pull request #33236 from bdach/disclaim-harder

  Attempt to give users better disclaimer on how not to nuke their data

  Dean Herbert · 2025-05-23 15:12:32 +09:00
  1e29753c1f
• Adjust wording
  Bartłomiej Dach · 2025-05-23 08:09:29 +02:00
  af5a1cea94
• Fix github code quality ping
  Dean Herbert · 2025-05-23 14:52:41 +09:00
  68264eb1ad
• Attempt to give users better disclaimer on how not to nuke their data

  I can't count the number of times where someone backed up just the file
  store without the realm database and lost data. As such this moves the
  "IMPORTANT READ ME" disclaimer a directory higher and attempts to
  describe the "proper" backup procedure in detail.
  
  People don't read, but maybe this will at least partially lower the
  volume.

  Bartłomiej Dach · 2025-05-22 19:16:42 +02:00
  6a3e9a9093
• Merge pull request #33222 from frenzibyte/ssv2-no-results-transitions

  SongSelectV2: Fix "no results" placeholder having weird transitions

  Dean Herbert · 2025-05-23 01:51:55 +09:00
  9bee290063
• Merge pull request #33216 from frenzibyte/user-tags-transition

  SongSelectV2: Show loading spinner underneath user tags during transitions

  Dean Herbert · 2025-05-23 01:49:05 +09:00
  335427b420
• Merge pull request #33229 from frenzibyte/ssv2-select-recommended-diff

  SongSelectV2: Choose recommended difficulty on beatmap selection

  Dean Herbert · 2025-05-23 01:09:35 +09:00
  07de5d5131
• Merge pull request #33228 from frenzibyte/ssv2-leaderboard-total-count

  SongSelectV2: Display total scores count in personal best score

  Dean Herbert · 2025-05-22 22:52:34 +09:00
  2ddd789248
• Remove unnecessary initial text content duplicate
  Dean Herbert · 2025-05-22 22:52:19 +09:00
  4d309ded2e
• Code quality fixes
  Dean Herbert · 2025-05-22 22:41:11 +09:00
  41feba120b
• Do not use unseeded RNG in replay analysis container test

  It's just bad form.

  Bartłomiej Dach · 2025-05-22 12:52:40 +02:00
  d7efce5378
• Merge pull request #33232 from bdach/editor-playback-speed-application-safer

  Improve reliability of unapplying speed adjustment on exiting editor

  Dan Balasescu · 2025-05-22 19:19:11 +09:00
  99e342043a
• Merge pull request #33234 from bdach/editor-player-instantiate-correct-result-type

  Fix editor player sometimes crashing because of instantiating wrong judgement result type for object

  Dan Balasescu · 2025-05-22 18:58:40 +09:00
  1ba4c9d0d6
• Fix editor player sometimes crashing because of instantiating wrong judgement result type for object

  Closes https://github.com/ppy/osu/issues/33231.
  
  I'm not sure how to reproduce the instances of this reported to sentry
  with `Drawable{Slider,Spinner}`, but this bug is about to be made worse
  by `DrawableHoldNote` in mania getting its own `JudgementResult` subtype
  in https://github.com/ppy/osu/pull/33194 - for that one to reproduce
  just start gameplay test while editor is seeked to a time instant where
  a hold note is mid-hold.
  
  There's possibly an argument here that `CreateResult()` should live on
  `HitObject` and not `DrawableHitObject`, and I'd even be partial to such
  an argument, but doing that would be a rather hard ruleset API break
  (albeit trivial one to resolve), and also may dredge up past
  conversations about `Judgement` and `JudgementResult` (cf.
  https://github.com/ppy/osu/pull/26563) that I would rather not get into
  again.
  
  Notably this is not source-breaking for rulesets. It may be
  binary-breaking, I haven't tested.

  Bartłomiej Dach · 2025-05-22 10:20:39 +02:00
  70c6ddbe30
• Improve reliability of unapplying speed adjustment on exiting editor

  Probably closes https://github.com/ppy/osu/issues/33230.
  
  I say "probably" because I couldn't reproduce this myself using the
  scenario provided in the issue but looking at the code involved I can
  see why it would happen. Long and short of it is that the speed
  adjustment cleanup code was much too reliant on disposal executing
  quickly, which as we've learned on several occasions before, cannot be
  relied upon.

  Bartłomiej Dach · 2025-05-22 09:28:47 +02:00
  b7c695b47c
• Merge pull request #33223 from frenzibyte/nominations-incorrect

  Fix nominations count logic not updated to newer API structure

  Bartłomiej Dach · 2025-05-22 08:01:45 +02:00
  c632383ccb
• Add test coverage
  Salman Alshamrani · 2025-05-22 01:44:30 +03:00
  aacb1ea58d
• Choose recommended difficulty when selecting a beatmap set
  Salman Alshamrani · 2025-05-22 01:44:24 +03:00
  f6c3dc502a
• Display total scores count in personal best score
  Salman Alshamrani · 2025-05-22 00:58:07 +03:00
  9e720509db
• Expose total scores count from backend
  Salman Alshamrani · 2025-05-22 00:57:49 +03:00
  6bc407310e
• Simplify test
  Salman Alshamrani · 2025-05-21 23:53:25 +03:00
  a8dc954efd
• Fix test not working due to incorrect setup
  Dean Herbert · 2025-05-22 04:54:03 +09:00
  08c8b6f17a
• Add test coverage
  Salman Alshamrani · 2025-05-21 19:01:47 +03:00
  17afea431b
• Fix nominations count system not updated to newer API structure
  Salman Alshamrani · 2025-05-21 17:35:13 +03:00
  bd2851c386