75266 Commits

This Branch

This Branch

All Branches

• Always use MessagePack to talk to spectator server
  Dan Balasescu · 2025-08-06 16:36:33 +09:00
  d0e9fda874
• refactor and reduce duplication
  Hivie · 2025-08-06 07:42:40 +01:00
  03b6f35946
• Merge pull request #34516 from bdach/async-write-in-cache-thing

  Fix update thread stutters upon completion of online beatmap lookup in song select

  Dean Herbert · 2025-08-06 13:19:57 +09:00
  8b2e394509
• Made the IconContent (avatar) square, in UserAvatarNotification.
  AeroKoder · 2025-08-05 15:31:11 -07:00
  7ec4912677
• add tests
  Hivie · 2025-08-05 23:04:15 +01:00
  7312cff96f
• add check for missing genre/language tags
  Hivie · 2025-08-05 23:02:48 +01:00
  f5c6c086ad
• Merge branch 'master' into async-write-in-cache-thing
  Bartłomiej Dach · 2025-08-05 20:12:14 +02:00
  ef67b596d3
• Merge pull request #34525 from bdach/carousel-mapping-thread-safety

  Fix clicking beatmap carousel group & set headers not working (or crashing) during a filter

  Dean Herbert · 2025-08-05 21:25:17 +09:00
  f4a1276be7
• Fix grid placement aggressively changing tool selection
  Salman Alshamrani · 2025-08-05 15:20:04 +03:00
  6001d6418b
• Merge pull request #34517 from Hiviexd/verify/check-inconsistent-barlines

  Add verify check for inconsistent osu!taiko barline omission

  Bartłomiej Dach · 2025-08-05 14:19:23 +02:00
  d2d3eda832
• Add failing test case
  Salman Alshamrani · 2025-08-05 14:20:20 +03:00
  5aa186c987
• Be more aggressive about cancelling grouping filter

  This is also papering over the larger issue of the insane refilter count
  and is basically a drive-by fix but rider is bugging me with a bunch of
  yellow highlights from memory churn which looks somewhat easily
  preventable.
  
  Basically the cancellation of filters could only take place between full
  groups. If there are few groups with lots of beatmaps, it could be a
  *looooong* while before the cancellation of the filter would actually
  take place. Hence the added extra cancellation check before every
  individual group item, and one extra check before performing the set
  mapping exchange and items return.

  Bartłomiej Dach · 2025-08-05 13:16:48 +02:00
  a10eaf7f2b
• Fix clicking group & set headers not working (or crashing) during a filter

  This papers over most of https://github.com/ppy/osu/issues/34507.
  
  The full failure scenario is:
  
  - user selects a beatmap set
  - online lookups fire
  - online lookups are populated back to realm
  - the realm changes trigger subscription, which triggers detached store
    replace, which triggers refilter
  - refilter takes a while
  - during the refilter user may be unable to select some sets because the
    set header mapping is incomplete
  
  This only papers over the last bullet of that, in making sure that the
  set header mapping is not externally accessed while it's being rebuilt.
  It doesn't fix the insane amount of refilters caused by everything
  preceding the refilter being overeager to trigger said refilter.

  Bartłomiej Dach · 2025-08-05 13:12:29 +02:00
  6b73308955
• Fix test steps potentially failing due to not waiting for database changes
  Dean Herbert · 2025-08-05 18:50:25 +09:00
  f2dd86631f
• Merge pull request #34500 from frenzibyte/mania-long-notes-sound-broken

  Prevent playing sliding sounds in hold notes when beatmap is not converted

  Bartłomiej Dach · 2025-08-05 11:41:22 +02:00
  619fe60dd1
• comment
  Hivie · 2025-08-05 10:02:26 +01:00
  85a7504ffc
• add tests
  Hivie · 2025-08-05 10:00:08 +01:00
  2109109686
• add taiko check for inconsistent barline omission
  Hivie · 2025-08-05 09:59:44 +01:00
  7c6b2dd230
• Fix grammar in comment
  Bartłomiej Dach · 2025-08-05 10:48:17 +02:00
  50daae399b
• Merge pull request #34465 from Hiviexd/verify/check-inconsistent-timing

  Add verify check for inconsistent timing control points

  Bartłomiej Dach · 2025-08-05 10:34:47 +02:00
  427dc2b31e
• Merge pull request #34467 from Hiviexd/verify/implement-scopes

  Distinguish between set-level and difficulty-specific checks in verify screen

  Bartłomiej Dach · 2025-08-05 10:31:22 +02:00
  da710ad558
• Fix update thread stutters upon completion of online beatmap lookup
  Bartłomiej Dach · 2025-08-05 10:16:54 +02:00
  1f1fc0a3de
• Add test coverage
  Salman Alshamrani · 2025-08-05 10:25:58 +03:00
  9798889ace
• Fix special cases of mania beatmaps not playing sliding samples

  Apparently mania sliders are a thing. See https://github.com/ppy/osu/pull/34500#issuecomment-3150610188

  Salman Alshamrani · 2025-08-05 10:25:39 +03:00
  03dae97ff3
• Bring back localisations
  Bartłomiej Dach · 2025-08-05 08:23:47 +02:00
  c1c43fab17
• Use casing of "beatmap set" consistent with the rest of the code base
  Bartłomiej Dach · 2025-08-05 08:18:30 +02:00
  ee5a5cda11
• Merge pull request #34504 from diquoks/fix-update-beatmap-tooltip

  Fix `PanelUpdateBeatmapButton`'s tooltip display

  Dean Herbert · 2025-08-05 10:56:10 +09:00
  1da4b1ba93
• remove unnecessary localisations
  Hivie · 2025-08-04 22:07:41 +01:00
  2c5aa73ccb
• Fix PanelUpdateBeatmapButton's tooltip display
  Denis Titovets · 2025-08-04 18:13:14 +03:00
  46ee4cf018
• apply review

  - improve timing tolerance const name and documentation
  - simplify matching logic in `FindMatchingTimingPoint`

  Hivie · 2025-08-04 15:21:43 +01:00
  a7f0ae09bb
• Merge pull request #34419 from bdach/online-status-stuff

  Update beatmap online statuses when the set is selected in song select

  Dean Herbert · 2025-08-04 22:48:12 +09:00
  2025.804.0-tachyon 5a9c8da6c2
• simplify filtering logic
  Hivie · 2025-08-04 14:22:02 +01:00
  bb156d4206
• define general checks with a bool in CheckMetadata instead of an interface
  Hivie · 2025-08-04 14:12:59 +01:00
  ed301ec114
• rename scopes
  Hivie · 2025-08-04 14:02:40 +01:00
  8a2053bf61
• Fix crash when switching between online leaderboard scopes in song select

  closes https://github.com/ppy/osu/issues/34502

  Bartłomiej Dach · 2025-08-04 13:15:20 +02:00
  a0a7235c8e
• Merge pull request #34491 from peppy/wedge-background-click-block

  Fix clicks propagating through personal best score area

  Bartłomiej Dach · 2025-08-04 12:56:40 +02:00
  3bfe2581a4
• Merge pull request #34501 from peppy/reveal-background-only-left-button

  Avoid reveal background triggering when more than left mouse button is involved

  Bartłomiej Dach · 2025-08-04 12:13:19 +02:00
  1dcf9d4395
• Merge pull request #34462 from bdach/difficulty-extended-information-tooltip

  Display extended information about effect of beatmap attributes on gameplay in tooltip when hovering

  Dean Herbert · 2025-08-04 18:58:37 +09:00
  f3fe5aee1b
• Fix test failure due to over-scoping
  Dean Herbert · 2025-08-04 18:53:55 +09:00
  13ff11ac85
• Avoid reveal background triggering when more than left mouse button is involved

  Closes https://github.com/ppy/osu/issues/34393.

  Dean Herbert · 2025-08-04 18:30:08 +09:00
  d34c526717
• Merge pull request #34496 from peppy/fade-music-after-gameplay

  Fade music back in when returning from song select from gameplay

  Bartłomiej Dach · 2025-08-04 11:28:40 +02:00
  ba6b5d858f
• Clarify "invert" mod cannot possibly play sliding samples
  Salman Alshamrani · 2025-08-04 12:27:57 +03:00
  6d43ae8ac1
• Fix "no release" mod not playing sliding samples in converted beatmaps
  Salman Alshamrani · 2025-08-04 12:27:57 +03:00
  d216256fdf
• Only play hold note sliding samples when beatmap is converted
  Salman Alshamrani · 2025-08-04 12:27:55 +03:00
  4171c3a241
• Adjust some formatting to read better
  Dean Herbert · 2025-08-04 18:20:56 +09:00
  af290ddc0c
• Limit maximum width of tooltips
  Dean Herbert · 2025-08-04 18:18:31 +09:00
  85aadedb2f
• Merge pull request #34498 from peppy/sort-mode-dropdown-always-show

  Always show "sort" dropdown but disable in cases it doesn't (yet) work

  Bartłomiej Dach · 2025-08-04 10:56:54 +02:00
  d72cb6e602
• Fix context menu not working due to too much blocking
  Dean Herbert · 2025-08-04 17:52:27 +09:00
  3557207609
• Move duck code to run before looping is setup
  Dean Herbert · 2025-08-04 17:45:39 +09:00
  9fa95ceabe
• Merge pull request #33809 from frenzibyte/fix-leaderboard-loading

  Fix leaderboard wedge updating scores in non-update thread

  Bartłomiej Dach · 2025-08-04 10:45:27 +02:00
  4423983db5