osu-lazer

Fix osu!mania legacy skin WidthForNoteHeightScale not being used (#35050 )

* Add osu!mania legacy skin widthForNoteHeightScale

* Ensure WidthForNoteHeightScale correctly defaults to MinimumColumnWidth

qinvvv · 2025-09-19 10:53:25 +09:00

b91ff8a5c5

Fix beatmap skin sample lookups falling back to non-custom sample banks if the custom sample bank sample was not found

Closes https://github.com/ppy/osu/issues/33900. I think. Stable's sample
lookup logic is horrible.

The user in the issue claimed they were hearing `drum-hitfinish2`, but
they were really hearing `drum-hitfinish`, because they're the same
`.wav` file in the beatmap. Now the reason *why* they were hearind
`drum-hitfinish` is that the sample control point was specifying
something like:

23946,-200,4,2,4,40,0,0

To decipher, this is:
- default sample bank of soft
- custom sample bank of 4

Taking one of the objects affected, namely 00:23:946 (2) - that's a
slider with finish addition and drum addition bank on the slider head.
The slider head is thus attempting to play `soft-hitnormal4` and
`drum-hitfinish4`.

Neither `soft-hitnormal4` or `soft-hitnormal` exist in the beatmap, so
that plays fine via falling back to user skin's `soft-hitnormal`, but
`drum-hitfinish4` ends up falling back to `drum-hitfinish` which *does*
exist in the beatmap skin and thus plays wrongly from the beatmap skin
rather than the user skin.

I have no idea how to ensure this is correct across every beatmap and
skin out there so my approach is to just spray and pray (and rely on
issue reports I guess). I *think* this matches the stable logic which is
nestled within
https://github.com/peppy/osu-stable-reference/blob/a5e5fe6ef240505d13526cf32783cad261e9bd8b/osu!/Audio/AudioEngine.cs#L1136-L1230
but honestly if you put a gun to my head I couldn't be sure if it
matches completely in every possible circumstance or not.

Bartłomiej Dach · 2025-06-27 13:00:50 +02:00

c7cd3a9842

Merge branch 'master' into gameplay-leaderboard-skinnable

Bartłomiej Dach · 2025-05-07 10:45:51 +02:00

5b61761bbd

Clarify purpose of helper lookup entries in osu!mania skinning

Salman Alshamrani · 2025-05-01 06:30:32 +03:00

3151fe7ef1

Make column spacing lookups easy to use

Salman Alshamrani · 2025-04-30 03:59:41 +03:00

d63f9533b1

Convert gameplay leaderboard to skinnable component

This PR converts the leaderboard into a full-fledged skinnable component
that can be manipulated by users at will.

Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
be fixed - although it's a very mixed bag, for several reasons:

- Because of taiko players' refusal to see reason^W^W^W^Winsistence on
  keeping stable behaviours related to aspect ratio treatment, I have to
  assume the worst case scenario, which means than on typical
  resolutions like 16:9 (or even worse, 4:3), the leaderboard will
  likely not occupy as much vertical space as it probably could.

- Additionally, there's the problem of where to put the spectator list.
  I settled on putting it to the right of the leaderboard, but that's
  kind of janky, because the leaderboard sometimes collapses and
  sometimes fully hides, leading to a very awkward space left behind. If
  we had the capability to anchor elements to other elements, maybe this
  could be resolved, but for now, I'm not sure what to do. I think if
  some users are bothered by it they can move it where they want it. Or
  delete it.

Bartłomiej Dach · 2025-04-24 13:10:30 +02:00

59b826c321

Add support for legacy osu!mania barline height and colour spec

Dean Herbert · 2025-02-28 15:13:13 +09:00

cb29459a1e

Merge spectator list classes into one skinnable

Bartłomiej Dach · 2025-01-17 11:23:14 +01:00

3c4bfc0a01

Add skinnable spectator list to default skins

Bartłomiej Dach · 2025-01-15 14:29:53 +01:00

99c7e164dc

Component -> Lookup

Dean Herbert · 2024-08-23 14:48:50 +09:00

48cfd77ee8

Remove remaining early base lookup calls which were missed

Dean Herbert · 2024-08-22 20:13:28 +09:00

46d55d5e61

Rename Target lookup to Component

Dean Herbert · 2024-08-22 19:00:28 +09:00

b57b8168a6

Move GlobalSkinnableContainers to global scope

Dean Herbert · 2024-08-22 18:46:07 +09:00

9a21174582

Rename GameplaySkinComponentLookup -> SkinComponentLookup

Dean Herbert · 2024-08-22 18:46:03 +09:00

36b4013fa6

Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup

Dean Herbert · 2024-08-22 18:39:36 +09:00

f37cab0c6e

Fix incorrect skin lookup shortcutting causing sprites to no longer work

Dean Herbert · 2024-08-17 02:33:52 +09:00

d1d195cf18

Update in line with new changes

Dean Herbert · 2024-08-09 14:55:01 +09:00

80c814008f

Merge branch 'master' into mania-combo-counter

Dean Herbert · 2024-08-09 00:19:17 +09:00

e645651ef4

Avoid making non-ruleset transformers in Ruleset.CreateSkinTransformer

This didn't make any sense, so let's do it a better way.

Dean Herbert · 2024-08-08 16:29:54 +09:00

60d383448f

Merge branch 'master' into ruleset-specific-combo-counter

Dean Herbert · 2024-08-08 03:21:52 +09:00

3c572abaa7

Use transformers for per-skin key counter implementation

Dean Herbert · 2024-08-06 18:17:21 +09:00

725dc4de9b

Only add legacy key overlay to osu! and catch HUD layers

Bartłomiej Dach · 2024-07-24 15:41:20 +02:00

c3dae81935

Simplify input overlay text colour decode (and fix incorrect default)

Bartłomiej Dach · 2024-07-24 14:53:01 +02:00

3c28c116ca

Adjust layout to ballpark-match stable

I dunno what the wiki is claiming with the "24px" figure or why
but I'm not playing conversion games either. Dimensions ballparked
via screenshots captured at x768 resolution.

Also removes a weird homebrew method to keep the text upright.
There is one canonical way to do this, namely
`UprightAspectMaintainingContainer`. And the other key counters
were already using it.

Bartłomiej Dach · 2024-07-24 14:52:56 +02:00

087dd759be

Fix code quality

normalid · 2024-07-24 12:57:30 +08:00

b24be96d04

Remove logging

normalid · 2024-07-24 12:31:01 +08:00

e2beacb3dd

Support custom input overlay color

normalid · 2024-07-23 23:35:25 +08:00

c52a993607

* Fix the default position

* Make the font match stable style

normalid · 2024-07-23 22:11:28 +08:00

c7b110a471

Fix the return button being squshed

normalid · 2024-07-23 21:12:55 +08:00

989ac56cbb

Change the default height to match the stable

normalid · 2024-07-23 20:53:06 +08:00

a015fde014

Implement the overlay

normalid · 2024-07-23 19:05:14 +08:00

ad1a86ebdc

Store layout version in SkinLayoutVersion instead and refactor migration code

Salman Ahmed · 2024-07-01 08:30:37 +03:00

0c34e7bebb

Fix migration logic overwriting existing components in ruleset targets

Salman Ahmed · 2024-06-25 05:54:56 +03:00

fc2202e0cc

Migrate combo counter layouts in custom skins to correct target-ruleset pairs

Salman Ahmed · 2024-06-25 04:38:58 +03:00

78e0126f16

Merge branch 'master' into ruleset-specific-combo-counter

Bartłomiej Dach · 2024-06-04 15:44:11 +02:00

5fcea01c13

Convert selected legacy skin sprites to grayscale

Matching stable.

Closes https://github.com/ppy/osu/issues/9858.

I would have liked to apply this in the taiko transformer itself, but
the limited accessibility of texture uploads, and as such the raw image
data, sort of prevents that...

Bartłomiej Dach · 2024-02-06 12:33:37 +01:00

27b97a3c4d

Remove ancient osu-resources lookup path from legacy skin textures

Salman Ahmed · 2024-01-17 16:33:14 +03:00

e54d20ea93

Allow disabling high resolution texture lookups in LegacySkin

Salman Ahmed · 2024-01-17 12:56:29 +03:00

5ad2918a75

Add legacy mania combo counter lookups

Salman Ahmed · 2023-12-30 05:29:22 +03:00

ece532b837

Move combo counter to ruleset-specific HUD components target