osu-lazer

Make BeatmapDifficultyCache's returned bindable non-nullable

Dean Herbert · 2025-05-25 22:27:37 +09:00

6500be3f2d

Fix status pill animating from zero height

Dean Herbert · 2025-04-10 20:11:04 +09:00

69035ef48f

Move rate-changing TODO to a common place in CalculateRateWithMods

Tim Schumacher · 2024-12-02 23:49:51 +01:00

e920cfa187

Adjust song select info icon size slightly

Not going to PR this it's just a minor tweak.

Dean Herbert · 2024-08-05 17:21:50 +09:00

c37f617e1d

Fix code quality and null handling

Dean Herbert · 2024-06-07 00:01:50 +08:00

dd3f4bcdab

Creating method in ModUtils to calculate the rate for the song

Xesquim · 2024-06-06 10:06:07 -03:00

860afb8123

Extract common helper for BPM rounding

Bartłomiej Dach · 2024-02-22 10:27:37 +01:00

81a9908c60

adjust beatmap length and drain based on rate changing mods

Simon G · 2023-12-22 03:04:48 +01:00

b31b9e96d0

Tidy up visual look

Dean Herbert · 2023-12-19 19:28:02 +09:00

3b848e8503

Move advanced stats to a more permanent location on song select

Dean Herbert · 2023-12-19 19:10:43 +09:00

07bb0805e9

Use existing localisations in BeatmapInfoWedge

Magnus-Cosmos · 2023-09-02 22:49:29 -04:00

d674856e29

Revert "Show only the break length instead of total minute breaks"

This reverts commit 9edaa6909e.

Bartłomiej Dach · 2023-07-25 22:17:55 +02:00

3b11559fd0

Show only the break length instead of total minute breaks

Dean Herbert · 2023-07-25 17:02:27 +09:00

9edaa6909e

Show drain length in length tooltip at song select

Dean Herbert · 2023-07-25 16:58:53 +09:00

480163ec2e

Remove beatmap info wedge rotation animation

It looks jank and also causes framebuffer overheads.

But mostly because it looks jank.

Dean Herbert · 2023-07-06 16:15:42 +09:00

f69f6adf67

Fix remaining obvious CI inspections

Bartłomiej Dach · 2023-06-24 16:07:01 +02:00

e3a89a6273

Add tooltips to truncated text

Joseph Madamba · 2023-06-08 19:44:07 -07:00

85fedbd025

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Apply rate multiplier outside BPM rounding

Salman Ahmed · 2022-05-20 18:04:12 +03:00

84a3cee452

Fix song select potentially displaying BPM range with equal min/max values

Salman Ahmed · 2022-05-20 17:53:28 +03:00

596853da8f

Simplify string bindings

Dean Herbert · 2022-03-30 17:59:45 +09:00

f9f6248101

Remove song source from main wedge display

This was definitely added at someone's request, since I wouldn't have
put it here. But it's displayed below in the details section already and
also not displayed in the updated "wedge" in the new design.

See https://github.com/ppy/osu/discussions/17537 for discussion.

Dean Herbert · 2022-03-30 17:59:40 +09:00

bc0b982102

Fix always rolling up from zero

Co-authored-by: Dean Herbert <pe@ppy.sh>

Dan Balasescu · 2022-03-10 19:59:05 +09:00

2de7795844

Fix beatmap wedge mutating transforms incorrectly

Dan Balasescu · 2022-03-10 17:54:33 +09:00

671d614c92

Fix CI reported warnings

Dean Herbert · 2022-01-12 22:39:00 +09:00

51251e3204

Miscellaneous fixes that don't fit elsewhere

Dean Herbert · 2022-01-12 16:39:36 +09:00

e6fdd0e969

Add missing null check before attempting to populate bpm info

Dean Herbert · 2021-12-10 13:53:48 +09:00

9ac8e6c81c

Fix potential crash due to children being mutated after disposal

This is a bit of an unfortunate edge case where the unbind-on-disposal
doesn't help, since the binding is happening in BDL, and the usage is in
a nested `LoadComponentAsync` call. Combine those and you have a recipe
for disaster.

Dean Herbert · 2021-12-09 18:52:00 +09:00

e7e61cd9ab

Rename BeatmapInfo.Version to DifficultyName to match underlying interface

Dean Herbert · 2021-11-11 17:20:53 +09:00

51a353e12d

Update existing usages of Author as string to access Username directly

Dean Herbert · 2021-11-04 18:57:54 +09:00

86540d1fb6

Update usages of GetLocalised{-> Bindable}String

Bartłomiej Dach · 2021-11-02 21:42:01 +01:00

98367fc482

Remove FixedWidth and add AutoSizeAxes specs to all usages

Bartłomiej Dach · 2021-10-25 20:24:48 +02:00

6802e9ec10

Move mod value change callback inside wedge info text component

Salman Ahmed · 2021-08-24 07:53:49 +03:00

847726547a

Explicitly update beatmap info wedge on mod change

This used to already be the case prior to b419ea7, but in a very
roundabout way. Changes to the value of the star difficulty bindable -
including indirect changes via the set of active mods changing - would
trigger the wedge display to regenerate and load asynchronously.

b419ea7 accidentally broke this by moving down the bindable retrieval to
a lower level, at which point `WedgeInfoText` would only receive the set
of mods selected at the time at which a given beatmap was selected, and
not receive any further updates, breaking the BPM display updating in
real time (as `WedgeInfoText` could not be aware that rate-changing mods
were even in effect).

To resolve, explicitly reload the wedge's contents on mod changes.

Bartłomiej Dach · 2021-08-22 19:16:46 +02:00

9538a32b5e

Add failing test case

Bartłomiej Dach · 2021-08-22 19:16:43 +02:00

e4a8f72167

Move some constants to consts

Dean Herbert · 2021-08-19 19:19:46 +09:00

a65cd36a5f

Apply 5px vertical spacing on fill flow

Regressed, was margin { bottom = 5f } from the star rating display
creation method, which I've partly inlined.

Salman Ahmed · 2021-08-19 08:30:29 +03:00

6bfae25cda

Use animated star display in beatmap info wedge and synchronise bar

Salman Ahmed · 2021-08-19 07:18:02 +03:00

25e6317e7f

Merge branch 'master' into mod-settings-difficulty-cache

Salman Ahmed · 2021-08-19 06:35:13 +03:00

102320f8ae

Merge branch 'master' into star-rating-display-v2

Dean Herbert · 2021-08-18 17:22:33 +09:00

9d2664cbb1

Refactor beatmap info wedge to not fully refresh on star difficulty change

Makes it look awkward when changing difficulty via mod settings for
example.

Now the changes should instead only affect the displayed components which consume it
directly.

Salman Ahmed · 2021-08-17 05:46:06 +03:00

b419ea716b

Hide left border of beatmap wedge

smoogipoo · 2021-08-13 22:29:22 +09:00

0e66a05963

Merge both variants of the star rating display

Salman Ahmed · 2021-08-04 18:19:28 +03:00

d4399f10f9

Use star difficulty colour spectrum game-wide

Salman Ahmed · 2021-08-03 15:02:18 +03:00

9a5e052dc0

Update existing inline usages to use new extension method