354 Commits

• Refetch leaderboard when (slow) retrying a beatmap

  Probably closes https://github.com/ppy/osu/issues/34645.
  
  Obviously this is only good if the score has managed to process online
  and slot into a leaderboard before the user requested a retry. I can't
  make miracles happen.
  
  Notably this is not applied to quick retry, because it would make quick
  retry slower, and the presumption is that if the user is quick-retrying
  their last score is likely useless for global leaderboards anyway. (The
  one exception to that last part is possibly quick-retrying from results
  screen, which is a flow that we have, but maybe fine to ignore it...?)

  Bartłomiej Dach · 2025-08-14 14:31:49 +02:00
  44e76a61a9
• Add a comment about a sneaky part of the leaderboard sorting changes
  Bartłomiej Dach · 2025-07-28 11:47:19 +02:00
  a80fecffe7
• Fix back button appearing on second quick retry when it shouldn't
  Dean Herbert · 2025-07-01 19:56:52 +09:00
  5b584227a0
• Fix footer appearing at loader screen on quick retries
  Dean Herbert · 2025-07-01 19:56:39 +09:00
  2aca8eecb9
• Ensure global leaderboard state matches beatmap when loading player

  Closes https://github.com/ppy/osu/issues/33835.
  
  I love fixing issues multiple times.
  
  Notably the refetch is not forced so this should be a no-op if the
  global state is already correct.
  
  https://github.com/ppy/osu/issues/33835#issuecomment-2998897932 says
  
  > but we should also consider adding a force `RunTask` of the pending debounce before entering gameplay, probably around here:
  >
  > https://github.com/ppy/osu/blob/3192eaa2a20f20495db8431d3d6f35af7c705a94/osu.Game/Screens/SelectV2/SongSelect.cs#L420
  
  but I am not confident in making that change as I have no idea whether
  it is correct or not.

  Bartłomiej Dach · 2025-06-25 09:54:05 +02:00
  dee4ede306
• Add note about reasoning for low battery threshold
  Dean Herbert · 2025-06-20 02:26:46 +09:00
  a6c7e20ffc
• Update logo tracking operations to use IDisposable flow
  Dean Herbert · 2025-06-12 15:18:38 +09:00
  435128ebaa
• Adjust PlayerLoader logic to avoid threading safety requirements
  Dean Herbert · 2025-04-17 19:21:33 +09:00
  708d9ae1b0
• Centralise calls to end high performance sessions
  Dean Herbert · 2025-04-17 16:55:33 +09:00
  a15230eba1
• Merge branch 'master' into mobile-fix-mania
  Dean Herbert · 2025-01-24 17:03:00 +09:00
  56a611b47e
• Switch IsImportant to init property isntead of virtual
  Dean Herbert · 2025-01-22 16:41:26 +09:00
  4cf4b8c73d
• Merge branch 'master' into mobile-fix-mania
  Salman Alshamrani · 2025-01-12 02:00:49 -05:00
  f121b03a78
• Revert "Clear previous LastLocalUserScore when returning to song select"

  This reverts commit ced8dda1a2.

  Dean Herbert · 2025-01-02 15:59:00 +09:00
  58dcb25bd5
• Keep game in portrait mode when restarting
  Salman Alshamrani · 2024-12-31 12:25:58 -05:00
  d7e4038f4a
• Move "global" scroll-adjusts-volume to a per-screen component-based implementation
  Dean Herbert · 2024-12-16 15:21:07 +09:00
  bdd417c1a1
• Merge pull request #30937 from frenzibyte/fix-quick-restart-not-saving-score

  Fix score no longer being saved when quick-restarting after pass

  Dean Herbert · 2024-12-04 23:48:18 -08:00
  791416c8f1
• Merge pull request #30863 from frenzibyte/improve-back-button-display

  Delay back button appearance when performing a quick restart

  Bartłomiej Dach · 2024-12-02 11:49:45 +01:00
  6c0ccc5ebe
• Merge pull request #28473 from bdach/beatmap-info-purge

  Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`

  Dean Herbert · 2024-12-02 16:19:12 +09:00
  5b2558cec2
• Fix score no longer being saved when quick-restarting after pass
  Salman Alshamrani · 2024-11-30 23:36:02 -05:00
  9140893249
• Clear previous LastLocalUserScore when returning to song select

  This seems like the lowest friction way of fixing
  https://github.com/ppy/osu/issues/30885.
  
  We could also only null this on application, but this feels worse
  because
  
  - It would require local handling (potentially complex) in
    `BeatmapOffsetControl` if we want to continue displaying the graph and
  button after clicking it.
  - It would make the session static very specific in usage and
    potentially make future usage not possible due to being nulled in only
  a very specific scenario.
  
  One might argue that it would be nice to have this non-null until the
  next play, but if such a usage comes up I'd propose we rename this
  session static and add a new one with that purpose.

  Dean Herbert · 2024-11-28 18:01:28 +09:00
  ced8dda1a2
• Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2024-11-26 16:52:39 -05:00
  3e1b4f4ac5
• Hide back button when quick-restarting unless load time takes long
  Salman Alshamrani · 2024-11-24 05:40:06 -05:00
  ae9119eef0
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Fix beatmap load not continuing when when settings slider is focused

  Regressed with recent sliderbar focus changes.
  
  Closes #30716.

  Dean Herbert · 2024-11-21 02:28:35 +09:00
  ae98f63b51
• Fix black layer not fading fast enough when exiting quickly from quick restart
  Dean Herbert · 2024-11-16 11:52:02 +09:00
  0a1f589c80
• Merge pull request #30603 from peppy/quick-restart-faster-better

  Make quick restart even faster

  Bartłomiej Dach · 2024-11-14 12:30:13 +01:00
  1355fa636d
• Add missing expire call

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2024-11-14 19:33:34 +09:00
  36d48a01c8
• Adjust transition further to avoid brief "jumpscare" display of metadata
  Dean Herbert · 2024-11-14 18:28:27 +09:00
  9849a88eef
• Make quick restart even faster
  Dean Herbert · 2024-11-13 18:11:25 +09:00
  2dbc275bb8
• Increase idle time before gameplay loads when hovering controls
  Dean Herbert · 2024-11-13 17:39:21 +09:00
  2ae8c36d17
• Start preparing player earlier when quick retrying

  Should help with https://github.com/ppy/osu/issues/9039.

  Dean Herbert · 2024-10-13 22:29:00 +09:00
  868a7db9e9
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-09-15 04:53:35 +09:00
  58fe502af4
• Fix high performance session potentially getting stuck after multiplayer spectator
  Dean Herbert · 2024-09-05 17:19:53 +09:00
  86a06c7e10
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-07-23 12:09:32 +09:00
  d707e29ff7
• Adjust calls to GetContainingInputManager()
  Bartłomiej Dach · 2024-06-18 07:41:19 +02:00
  659505f711
• Move EpilepsyWarning out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:28:41 +02:00
  f64a0624a5
• Continue loading even when osu! logo is being dragged at loading screen

  Closes https://github.com/ppy/osu/issues/28130.

  Dean Herbert · 2024-05-14 23:54:07 +08:00
  cff865b556
• Merge pull request #26937 from frenzibyte/fix-osu-logo-blocking-load

  Stop blocking player load when hovering over osu! logo

  Dean Herbert · 2024-03-21 21:52:25 +08:00
  970e45ff24
• Adjust timings and delay disclaimers the same as settings
  Dean Herbert · 2024-03-16 10:09:49 +08:00
  0f8d526453
• Tweak visuals further
  Bartłomiej Dach · 2024-03-15 11:38:51 +01:00
  e6883b8418
• Improve hiding transition when multiple disclaimers are visible
  Bartłomiej Dach · 2024-03-15 11:01:34 +01:00
  5513a72748
• Add localisation support
  Bartłomiej Dach · 2024-03-15 10:59:49 +01:00
  49a087f7fc
• Stay on player loader a bit longer if disclaimers are present

  Just to make reading the text easier.

  Bartłomiej Dach · 2024-03-15 09:53:20 +01:00
  4688a53cf4
• Add disclaimer for loved/qualified status
  Bartłomiej Dach · 2024-03-15 09:53:20 +01:00
  f3a444b7ac
• Replace existing epilepsy warning with inline display
  Bartłomiej Dach · 2024-03-15 09:53:20 +01:00
  42ae18976f
• Merge pull request #27391 from smoogipoo/high-performance-session-redux

  Use high performance session during gameplay

  Bartłomiej Dach · 2024-02-27 16:28:04 +01:00
  2889cf39d7
• Move manager to desktop game
  Dan Balasescu · 2024-02-27 19:36:03 +09:00
  069b400dd0
• Use high performance session during gameplay
  Dan Balasescu · 2024-02-26 22:32:48 +09:00
  bfb5098238
• Apply safeties for AudioFilter usage around drawables which go non-present
  Dean Herbert · 2024-02-26 21:22:25 +08:00
  c686dfd361
• Always bring master/music volume to 50%
  Salman Ahmed · 2024-02-16 11:20:07 +03:00
  583e71634f