185 Commits

• Calculate multiplayer room difficulty range based only on non-expired items

  Previously (https://github.com/ppy/osu/pull/34464) this was based on
  room status, but in review of the web-side change it was pointed out
  that even an open room could have no active items
  (https://github.com/ppy/osu-web/pull/12325#pullrequestreview-3082894354).

  Bartłomiej Dach · 2025-08-13 09:32:50 +02:00
  aa88d90eb2
• Only exclude expired items from difficulty range if room is still open
  Bartłomiej Dach · 2025-08-01 14:52:46 +02:00
  9531fb3599
• Calculate multiplayer room difficulty range based on non-expired items only

  Fixes one part of https://github.com/ppy/osu/issues/34379.

  Bartłomiej Dach · 2025-08-01 14:28:51 +02:00
  cc25919094
• Apply suggestions from review
  Dan Balasescu · 2025-03-27 19:24:57 +09:00
  050cc27125
• Make class partial
  Dan Balasescu · 2025-03-27 00:35:21 +09:00
  c720f2b33f
• Fix room background not working in multiplayer

  At the core of the problem is that the multiplayer server does not
  serialise beatmap covers to clients -- only the beatmap ids. Because of
  this, any components that need to display the background should query it
  from an online source first (i.e. via `BeatmapLookupCache`).
  
  There is a slightly tricky situation here formed of two parts, which
  I'll try to explain below.
  
  `Background.Sprite` is exposed publicly and some inheritors override the
  sprite's texture in a similar fashion to the way this changeset does.
  While I frankly believe this is unnaceptable from an encapsulation point
  of view, I've gone for consistency in this regard.
  
  The other fail case is `UpdateableBeatmapBackgroundSprite`. Contrary to
  its name, that object is _not_ a `Sprite` - it is a
  `ModelBackedDrawable` that _contains_ a `Sprite`. The logic in this PR
  could be extracted into a separate object similar to
  `OnlineBeatmapSetCover` (an actual `Sprite`), but even so it would
  require `Background` to provide a path for overriding its contained
  `Sprite`.
  I went through the path above originally with the changes visible in
  https://github.com/smoogipoo/osu/tree/fix-mp-backgrounds, but it looks
  quite daunting and I feel like there would be a lot of emphasis on the
  correct abstraction model for `Background`, of which I'm not entirely
  sure of.
  
  Instead of dealing with both of the above, this commit presents a
  direct; local resolution to the problem.

  Dan Balasescu · 2025-03-27 00:26:08 +09:00
  f907758b8b
• Merge branch 'master' into remove-roommanager
  Dan Balasescu · 2025-03-04 13:17:04 +09:00
  446718f929
• Merge pull request #31637 from smoogipoo/room-management-lio

  Create, join, and part multiplayer rooms only via the multiplayer server

  Dean Herbert · 2025-03-04 13:13:55 +09:00
  58a671decb
• Disable button instead of hiding (and add tooltip)
  Dean Herbert · 2025-02-27 15:15:58 +09:00
  0b453772da
• Merge branch 'master' into room-management-lio
  Dan Balasescu · 2025-02-27 14:14:19 +09:00
  a33aff9bbd
• Refactor polling components (namespace/namings)
  Dan Balasescu · 2025-02-12 22:22:17 +09:00
  24cc77287e
• Remove RoomManager and related components
  Dan Balasescu · 2025-02-12 21:37:34 +09:00
  f146a7d116
• Move room tracking to lounge subscreen
  Dan Balasescu · 2025-02-12 21:10:21 +09:00
  068a66e7d4
• Adjust some paddings and text

  Mostly trying to give more space to the queue as we add more vertical
  elements to the middle area of multiplayer / playerlists. This whole UI
  will likely change – this is just a stop-gap fix.

  Dean Herbert · 2025-02-12 17:43:49 +09:00
  9aef95c381
• Add comment indicating RoomManager shouldn't exist
  Dan Balasescu · 2025-01-23 17:18:01 +09:00
  a198b0830a
• Join/Leave rooms via multiplayer server

  Relevant functionality has been removed from `RoomManager` in the
  process.

  Dan Balasescu · 2025-01-22 21:44:45 +09:00
  02369baec4
• Fix star range display looking a bit bad when changing opacity
  Dean Herbert · 2025-01-07 16:42:06 +09:00
  383fda7431
• Merge branch 'master' into filter-playing-rooms
  Bartłomiej Dach · 2024-12-12 13:06:22 +09:00
  d8d5a00f3b
• Increase timed update frequency and add inline comment
  Dean Herbert · 2024-12-11 18:08:34 +09:00
  0aa17a905b
• Add ability to filter out currently playing rooms

  Addresses https://osu.ppy.sh/community/forums/topics/2013293?n=1.

  Bartłomiej Dach · 2024-12-11 13:24:08 +09:00
  3352571f2a
• Rename Room{Status -> Mode}Filter

  I need the "status" term free for an upcoming change. And web calls this
  parameter "mode" as well:
  
  	https://github.com/ppy/osu-web/blob/642e973f916f315fb505aa79d4376675d0a2ec95/app/Models/Multiplayer/Room.php#L184-L199
  
  so it works in my head.

  Bartłomiej Dach · 2024-12-11 12:36:42 +09:00
  637fe07b31
• Merge branch 'master' into better-room-status
  Bartłomiej Dach · 2024-11-25 09:48:40 +01:00
  1410e8837a
• Merge branch 'master' into multiplayer-remove-expired-item-removal
  Salman Alshamrani · 2024-11-23 22:19:21 -05:00
  956da0383f
• Merge pull request #30812 from smoogipoo/playlist-populate-on-enter

  Fix joining playlists room sometimes not selecting the first item

  Dean Herbert · 2024-11-22 23:57:45 +09:00
  ce41c000a1
• Improve handling of multiplayer room status
  Dan Balasescu · 2024-11-22 21:21:04 +09:00
  82a63228de
• No longer remove expired playlist items from Room model
  Dan Balasescu · 2024-11-22 17:19:26 +09:00
  e59ac9e7c8
• Populate rooms as soon as they're joined
  Dan Balasescu · 2024-11-21 23:48:04 +09:00
  f738fb2a89
• Enable NRT for multiplayer and playlists
  Dan Balasescu · 2024-11-21 20:32:09 +09:00
  6870c99eb2
• Remove OnlinePlayComposite
  Dan Balasescu · 2024-11-15 15:59:28 +09:00
  bfbae9458a
• Make Room.Playlist non-bindable
  Dan Balasescu · 2024-11-15 15:51:01 +09:00
  34c0f72dd6
• Make Room.RecentParticipants non-bindable
  Dan Balasescu · 2024-11-15 15:25:43 +09:00
  b16edbbf52
• Make Room.UserScore non-bindable
  Dan Balasescu · 2024-11-15 14:42:46 +09:00
  dc5337d771
• Make Room.DifficultyRange non-bindable
  Dan Balasescu · 2024-11-15 14:42:46 +09:00
  c4f8fd1832
• Make Room.MaxAttempts non-bindable
  Dan Balasescu · 2024-11-15 14:42:46 +09:00
  6c84e425f8
• Make Room.ParticipantCount & Room.MaxParticipants non-bindable
  Dan Balasescu · 2024-11-15 14:42:45 +09:00
  b8bae30b66
• Make Room.Status non-bindable
  Dan Balasescu · 2024-11-15 14:42:18 +09:00
  5d4838a08b
• Make Room.Category non-bindable
  Dan Balasescu · 2024-11-15 14:42:18 +09:00
  bde7b8e610
• Make Room.Host non-bindable
  Dan Balasescu · 2024-11-15 14:42:17 +09:00
  8694f7e1cc
• Make Room.Name non-bindable
  Dan Balasescu · 2024-11-15 14:29:15 +09:00
  6160df1586
• Fix CI issues
  Dan Balasescu · 2024-11-13 17:15:50 +09:00
  a2a930aa35
• Make RoomID non-bindable

  Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.

  Dan Balasescu · 2024-11-13 16:28:54 +09:00
  99762da7b8
• Make CurrentPlaylistItem not a bindable
  Dan Balasescu · 2024-11-12 18:17:24 +09:00
  72564b5c98
• Remove extra box in OnlinePlayBackgroundScreen
  Andrei Zavatski · 2024-08-17 01:01:51 +03:00
  f74263db81
• Remove requirement of specifying animateOnnter in BackgroundScreen ctor
  Dean Herbert · 2024-08-07 19:07:44 +09:00
  6870311c1e
• Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge
  Dean Herbert · 2024-07-27 02:06:56 +09:00
  9323f89357
• Fix crash on calculating playlist duration when rate-changing mods are present

  Regressed in https://github.com/ppy/osu/pull/28399.
  
  To reproduce, enter a playlist that has an item with a rate-changing mod
  (rather than create it yourself).
  
  This is happening because `APIRuleset` has `CreateInstance()`
  unimplemented:
  
      https://github.com/ppy/osu/blob/b4cefe0cc2fda0ab4b5af6138ee158bd32262f9a/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs#L159
  
  and only triggers when the playlist items in question originate from
  web.
  
  This is why it is bad to have interface implementations throw outside of
  maybe mock implementations for tests. `CreateInstance()` is a scourge
  elsewhere in general, we need way less of it in the codebase (because
  while convenient, it's also problematic to implement in online contexts,
  and also expensive because reflection).

  Bartłomiej Dach · 2024-06-25 11:28:10 +02:00
  0d2a47167c
• Hide daily challenge from playlists listing
  Bartłomiej Dach · 2024-06-10 13:12:21 +02:00
  073ddcebe4
• Apply padding to GridContainers directly
  Andrei Zavatski · 2024-02-20 23:18:37 +03:00
  2543a48ac8
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Merge pull request #25522 from bdach/no-concurrent-connections

  Implement flow allowing disconnection from online services when another client instance for same user is detected

  Dean Herbert · 2023-11-28 19:09:38 +09:00
  537c9e031d