74 Commits

• Select timing point on enter if no effect point is active at the time

  Noticed during testing.

  Bartłomiej Dach · 2025-02-04 12:44:05 +01:00
  2dbf30a096
• Always select the closest control point group regardless of whether it has a timing point
  Bartłomiej Dach · 2025-02-04 12:35:02 +01:00
  a0b6610054
• Select closest timing point every time the timing screen is changed to

  No issue thread for this, was pointed out internally:
  https://discord.com/channels/90072389919997952/1259818301517725707/1316604605777444905
  
  Due to the custom setup that editor has with its nested
  "screens-that-aren't-screens", the logic that selects the closest
  timing point to the current time would only fire on the first open of
  the screen. Seems like a good idea to have it fire every time instead.

  Bartłomiej Dach · 2025-01-08 14:24:46 +01:00
  5a2024777d
• Always show timing points in timeline when at the timing screen

  Supersedes https://github.com/ppy/osu/pull/29196.

  Dean Herbert · 2024-07-31 19:43:08 +09:00
  2d52bab77b
• Fix typo in xmldoc
  Bartłomiej Dach · 2023-02-11 16:26:32 +01:00
  a3cc0d23b3
• Automatically select the closest timing point on entering the timing screen
  Dean Herbert · 2023-02-10 17:48:56 +09:00
  6d876fdb9a
• Move ControlPointList to own file
  Dean Herbert · 2023-02-10 17:37:31 +09:00
  03e623d1d2
• Don't use verbatim string literals
  Jai Sharma · 2022-11-29 18:22:07 +00:00
  7dbf379351
• Code quality
  Jai Sharma · 2022-11-27 03:23:08 +00:00
  218c04c174
• Add OnRowSelected event to EditorTable
  Jai Sharma · 2022-11-27 02:47:54 +00:00
  3c56b9c93a
• Remove #nullable disable from TimingScreen
  Jai Sharma · 2022-11-27 02:43:22 +00:00
  1a914d0df7
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Convert == usages to ReferenceEquals
  Dan Balasescu · 2022-06-20 16:56:19 +09:00
  e0c82d11ab
• Fix selection by directly comparing control points

  Previously, all control points would get replaced, which led to
  performance issues that was worked around in this PR. By comparing
  control points, we're able to get good performance without requiring the
  workaround.

  Dan Balasescu · 2022-06-20 15:29:29 +09:00
  a922ea9b01
• Merge branch 'master' into editor-controlpoint-undo-redo
  Dan Balasescu · 2022-06-20 13:47:01 +09:00
  468e5fcbed
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Work around performance issues
  Dan Balasescu · 2022-06-13 15:45:08 +09:00
  776e7c0c71
• Merge pull request #18530 from peppy/add-cloen-button

  Change text on timing group add button when it is going to clone instead

  Dan Balasescu · 2022-06-03 22:23:04 +09:00
  fcf51a6f51
• Merge pull request #18531 from peppy/track-groups-better

  Improve group tracking logic to avoid switching which point type unnecessarily

  Dan Balasescu · 2022-06-03 13:04:54 +09:00
  dd93fc283b
• Merge branch 'master' into deselect-control-group
  Bartłomiej Dach · 2022-06-03 00:47:06 +02:00
  87ec2e490d
• Improve group tracking logic to avoid switching which point type unnecessarily
  Dean Herbert · 2022-06-02 18:33:09 +09:00
  ad3c093a08
• Change text on timing group add button when it is going to clone instead

  Also disables the button when it would otherwise have no effect.

  Dean Herbert · 2022-06-02 18:28:16 +09:00
  2fa4d46f73
• Allow clicking away to deselect the current control point group
  Dean Herbert · 2022-06-02 18:18:18 +09:00
  0b125ade4c
• Fix timing screen crash when attempting to add group to self

  Closes #18527.

  Dean Herbert · 2022-06-02 18:14:28 +09:00
  5a0f716bf2
• Merge pull request #18502 from peppy/editor-timing-follow-current-time

  Add automatic control point tracking to the timing screen

  Dean Herbert · 2022-06-02 07:37:03 +09:00
  6b297bc6ed
• Remove unused using directive
  Bartłomiej Dach · 2022-06-01 20:18:02 +02:00
  6b709de2c2
• Only switch to found group if non-null
  Dean Herbert · 2022-06-01 20:20:48 +09:00
  534e8f8fac
• Simplify linq tracking logic
  Dean Herbert · 2022-06-01 17:57:53 +09:00
  187acb0718
• Remove unused using statements
  Dean Herbert · 2022-06-01 17:43:40 +09:00
  c55c3325a4
• Use DeepClone instead of reflection call

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-06-01 10:47:45 +09:00
  25941f6187
• Copy attribute types from currently selected control point to new placements
  Dean Herbert · 2022-05-31 21:50:12 +09:00
  8240b645b4
• Automatically make first control point added to beatmap have timing data
  Dean Herbert · 2022-05-31 21:50:08 +09:00
  f99bcb23a0
• Add automatic control point tracking to the timing screen
  Dean Herbert · 2022-05-31 15:00:30 +09:00
  cf5da44492
• Update screen padding and colouring to better match new designs
  Dean Herbert · 2022-05-24 18:43:22 +09:00
  17206bbebf
• Remove TriangleButton usage in editor
  Dean Herbert · 2022-05-24 18:13:09 +09:00
  a346990a8c
• Reverse direction of binding to allow for better abstract class definitions
  Dean Herbert · 2021-05-12 16:53:58 +09:00
  d2e0e8ad94
• Adjust Add different background colour for timing area
  Dean Herbert · 2021-04-19 18:25:30 +09:00
  097a347533
• Make TimingScreen use rounded screen and adjust spacing/padding
  Dean Herbert · 2021-04-19 14:35:35 +09:00
  f4baff9e04
• Make "add" button more visible
  Dean Herbert · 2021-04-19 13:15:24 +09:00
  0c918410d0
• Give more space to the parameter adjustment area
  Dean Herbert · 2021-04-19 13:15:17 +09:00
  658c23c925
• Fix editor timing screen mutating the WorkingBeatmap instead of EditorBeatmap
  Dean Herbert · 2021-01-04 16:38:15 +09:00
  7fdf876b4c
• Add null checks to unguarded resolved-as-null fields
  Bartłomiej Dach · 2020-11-14 14:52:58 +01:00
  610ed99ae3
• Replace all usage of IBindableList.GetBoundCopy
  Dean Herbert · 2020-11-04 15:29:14 +09:00
  487a5ecdba
• Change editor timing screen seek behaviour to only occur on clicking table rows

  Previously it would react to any selection changed event, which could in
  lude time changes (which is done by removing then adding the
  ControlPointGroup).
  
  Closes #10590.

  Dean Herbert · 2020-10-27 12:28:12 +09:00
  e1f578c590
• Merge branch 'master' into more-timeline-toggles
  Dan Balasescu · 2020-10-05 17:33:18 +09:00
  16a599850c
• Push state change on control point group addition / removal
  Dean Herbert · 2020-10-02 17:49:38 +09:00
  c1c5b5da8e
• Move control point display to the base timeline class

  We want them to display on all screens with a timeline as they are quite
  useful in all cases.

  Dean Herbert · 2020-10-01 18:16:12 +09:00
  0d03084cdc
• Update to consume framework fixes
  Dean Herbert · 2020-09-30 20:27:02 +09:00
  a11c74d600
• Show control points in timing screen timeline
  Dean Herbert · 2020-09-30 17:00:42 +09:00
  698042268f