238 Commits

• Fix editor metadata section reload potentially confusing title and author

  Probably closes https://github.com/ppy/osu/issues/34449. I say probably
  because I couldn't break this myself without commenting out chunks of
  code that apply the metadata from the id3 tags, and the reporter of that
  issue did not provide mp3s to test with or a clear reproduction
  scenario. But chances are this is going to fix the problem anyhow.

  Bartłomiej Dach · 2025-07-31 10:58:43 +02:00
  d7a17d59e3
• Fix ID3 metadata half-applying on audio file switch

  Should be self-explanatory (feedback loop between `reloadMetadata()`
  changing text box current, and text box current changing calling
  `applyMetadata()`).

  Bartłomiej Dach · 2025-04-28 09:41:38 +02:00
  8ea89b9d52
• Use another property when reading artist as fallback

  I was testing with mp3s ripped via Apple Music and for whatever reason
  the artist was in `JoinedPerformers` rather than `JoinedAlbumArtist`.
  I'm not about to go down and do research on id3 so I'm just going to try
  this and see if anyone complains.

  Bartłomiej Dach · 2025-04-28 09:40:34 +02:00
  16b658b322
• Fix missing disposal of TagLib.File in ChangeAudioTrack
  Dean Herbert · 2025-04-28 15:52:55 +09:00
  aab2df1704
• Simplify taglib interactions further
  Dean Herbert · 2025-04-28 15:52:31 +09:00
  40faa3fc99
• Add manual MIME type resolution for TagLib file creation
  Stedoss · 2025-04-28 13:38:38 +09:00
  c2efda20d7
• Fix renamed translation keys
  Jamie Taylor · 2025-04-23 15:30:41 +09:00
  3b80c0af0a
• Fix osu!mania beatmap objects getting corrupted when updating beatmap background

  Closes https://github.com/ppy/osu/issues/32825.
  
  Tested manually to fix the issue. Setting up test coverage for this is
  going to likely take over an hour compared to the 30 second fix, so
  please advise if required. I couldn't find any existing tests which
  perform this flow.

  Dean Herbert · 2025-04-17 16:11:03 +09:00
  b71281bec8
• Merge pull request #32730 from peppy/fix-keyboard-steps

  Fix editor setup screen sliders not having correct keyboard steps

  Bartłomiej Dach · 2025-04-08 08:32:37 +02:00
  99ee5767cb
• Fix editor setup screen sliders not having correct keyboard steps

  Closes https://github.com/ppy/osu/issues/32691.
  
  Fixes some extra cases of failure that aren't pointed out in the issue.

  Dean Herbert · 2025-04-08 14:45:43 +09:00
  f2088496c5
• Make dependency on editor optional
  Bartłomiej Dach · 2025-04-07 15:00:47 +02:00
  5db4f80e84
• Fix code quality harder
  Bartłomiej Dach · 2025-04-07 14:59:51 +02:00
  f968f8ed68
• Fix nullability inspection
  Bartłomiej Dach · 2025-04-07 13:44:42 +02:00
  d34a1fb448
• Avoid saving a state when clearly not dirty
  Dean Herbert · 2025-04-07 19:37:26 +09:00
  3738d75202
• Ensure a state is saved when committing metadata to trigger pending changes flow
  Dean Herbert · 2025-04-03 18:49:18 +09:00
  f19fa73fb2
• Change editor to save metadata changes without explicit textbox commit

  Closes https://github.com/ppy/osu/issues/32365.

  Dean Herbert · 2025-04-03 15:31:24 +09:00
  ce288023fe
• Do not allow adding more than 8 combo colours in editor
  Bartłomiej Dach · 2025-02-26 11:24:06 +01:00
  6b76b8ccdd
• Fix infinite loop when switching audio tracks fails on an existing beatmap

  Bit ugly, but appears to work in practice...

  Bartłomiej Dach · 2025-01-27 10:27:06 +01:00
  be9c96c041
• Catch and display user-friendly errors regarding corrupted audio files

  Addresses lack of user feedback as indicated by
  https://github.com/ppy/osu/issues/31693.

  Bartłomiej Dach · 2025-01-27 10:25:22 +01:00
  01ae1a58f1
• Update textbox usage in line with framework changes
  Dean Herbert · 2025-01-14 16:29:56 +09:00
  904a08af26
• Display storyboard in editor background

  Fixes the main part of https://github.com/ppy/osu/issues/31144.
  Support for selecting a video will come later.
  
  Making this work was an absolutely awful time full of dealing with
  delightfully kooky issues, and yielded in a very weird-shaped
  contraption. There is at least one issue remaining wherein storyboard
  videos do not actually display until the track is started in editor, but
  that is 99% a framework issue and I do not currently have the mental
  fortitude to diagnose further.

  Bartłomiej Dach · 2024-12-31 13:57:50 +01:00
  21dba621f0
• Fix failing test scene due to new dependency
  Dean Herbert · 2024-12-28 01:02:15 +09:00
  1b2a223a5f
• Populate metadata from ID3 tags when changing beatmap audio track in editor

  - Closes https://github.com/ppy/osu/issues/21189
  - Supersedes / closes https://github.com/ppy/osu-framework/pull/5627
  - Supersedes / closes https://github.com/ppy/osu/pull/22235
  
  The reason why I opted for a complete rewrite rather than a revival of
  that aforementioned pull series is that it always felt quite gross to me
  to be pulling framework's audio subsystem into the task of reading ID3
  tags, and I also partially don't believe that BASS is *good* at reading
  ID3 tags. Meanwhile, we already have another library pulled in that is
  *explicitly* intended for reading multimedia metadata, and using it
  does not require framework changes. (And it was pulled in explicitly for
  use in the editor verify tab as well.)
  
  The hard and dumb part of this diff is hacking the gibson such that
  the metadata section on setup screen actually *updates itself*
  after the resources section is done doing its thing. After significant
  gnashing of teeth I just did the bare minimum to make work by caching
  a common parent and exposing an `Action?` on it. If anyone has better
  ideas, I'm all ears.

  Bartłomiej Dach · 2024-12-27 15:16:03 +01:00
  6a6db5a22b
• Add note about expensive operation
  Dean Herbert · 2024-12-10 16:45:26 +09:00
  bbaa542d4a
• Rewrite resource changing code to be more legible (to my eye)
  Dean Herbert · 2024-12-10 16:45:26 +09:00
  3cac583754
• Re-encode difficulties on resource change
  Salman Alshamrani · 2024-12-04 04:36:00 -05:00
  8e0f6fc12d
• Merge branch 'master' into editor-multiple-background-audio-files
  Salman Alshamrani · 2024-12-04 04:31:15 -05:00
  60d91bada8
• Merge pull request #28473 from bdach/beatmap-info-purge

  Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`

  Dean Herbert · 2024-12-02 16:19:12 +09:00
  5b2558cec2
• Use helper in one more place
  Bartłomiej Dach · 2024-11-29 09:22:29 +01:00
  5f092811cb
• Accidentally a word
  Bartłomiej Dach · 2024-11-29 08:46:08 +01:00
  5a9127dfc6
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• Perform a single Save call rather than doing it in each difficulty
  Salman Alshamrani · 2024-11-28 18:37:13 -05:00
  489d7a30ec
• Abstractify resource change logic and share between background and audio
  Salman Alshamrani · 2024-11-28 17:57:47 -05:00
  311f0947e4
• Add localisation support
  Salman Alshamrani · 2024-11-28 02:37:31 -05:00
  b1d0939142
• Rewrite bindable flow to make more sense
  Salman Alshamrani · 2024-11-28 02:37:27 -05:00
  4a1401a33d
• Rename container to make more sense
  Dean Herbert · 2024-11-28 15:20:51 +09:00
  32b34c1967
• Rename parameter to be more clear
  Dean Herbert · 2024-11-28 15:13:59 +09:00
  4d9d5adbf4
• Refactor ResourcesSection to support new form of selection
  Salman Alshamrani · 2024-11-27 05:53:22 -05:00
  efb68e4232
• Add FormBeatmapFileSelector for intermediate user-choice step
  Salman Alshamrani · 2024-11-27 05:52:43 -05:00
  b70fb4b0fe
• Reset new file states after syncing
  Salman Alshamrani · 2024-11-24 22:38:48 -05:00
  1468385559
• Remove no-op SaveState call
  Salman Alshamrani · 2024-11-24 01:13:39 -05:00
  3480da22d2
• Only enable button if there are different filenames
  Salman Alshamrani · 2024-11-24 01:11:36 -05:00
  95a6226413
• Make sync button only affect changed resource type
  Salman Alshamrani · 2024-11-24 01:02:34 -05:00
  a872f74974
• Add localisation support
  Salman Alshamrani · 2024-11-24 00:45:17 -05:00
  c8b13b726d
• Only enable button if there are multiple difficulties
  Salman Alshamrani · 2024-11-24 00:34:03 -05:00
  e348b3a7aa
• Add option to update all difficulties with new background/audio file
  Salman Alshamrani · 2024-11-24 00:32:50 -05:00
  8e20dc7e9d
• Preserve existing beatmap background/audio files if used elsewhere
  Salman Alshamrani · 2024-11-24 00:32:27 -05:00
  871c365fd8
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Only transfer difficulty slider values on commit

  Closes https://github.com/ppy/osu/issues/30112.

  Bartłomiej Dach · 2024-10-04 14:08:46 +02:00
  7816c41b94
• Merge pull request #30108 from bdach/default-combo-colours-in-editor

  Initialise colours section with default combo colours if none present

  Dean Herbert · 2024-10-04 18:57:25 +09:00
  4fc0aae486