mirror of
https://github.com/ppy/osu.git
synced 2025-01-31 17:12:56 +08:00
6a6db5a22b
- Closes https://github.com/ppy/osu/issues/21189 - Supersedes / closes https://github.com/ppy/osu-framework/pull/5627 - Supersedes / closes https://github.com/ppy/osu/pull/22235 The reason why I opted for a complete rewrite rather than a revival of that aforementioned pull series is that it always felt quite gross to me to be pulling framework's audio subsystem into the task of reading ID3 tags, and I also partially don't believe that BASS is *good* at reading ID3 tags. Meanwhile, we already have another library pulled in that is *explicitly* intended for reading multimedia metadata, and using it does not require framework changes. (And it was pulled in explicitly for use in the editor verify tab as well.) The hard and dumb part of this diff is hacking the gibson such that the metadata section on setup screen actually *updates itself* after the resources section is done doing its thing. After significant gnashing of teeth I just did the bare minimum to make work by caching a common parent and exposing an `Action?` on it. If anyone has better ideas, I'm all ears. |
||
|---|---|---|
| .. | ||
| ColoursSection.cs | ||
| DesignSection.cs | ||
| DifficultySection.cs | ||
| FormBeatmapFileSelector.cs | ||
| LabelledFileChooser.cs | ||
| LabelledTextBoxWithPopover.cs | ||
| MetadataSection.cs | ||
| ResourcesSection.cs | ||
| RulesetSetupSection.cs | ||
| SetupScreen.cs | ||
| SetupScreenHeader.cs | ||
| SetupScreenHeaderBackground.cs | ||
| SetupSection.cs | ||