64 Commits

• Do not expose track directly in EditorClock

  Intends to stop people from mutating it directly, and going through
  `EditorClock` members like `AudioAdjustments` instead.

  Bartłomiej Dach · 2025-01-07 11:40:18 +01:00
  98bb723438
• Re-route editor tempo adjustment via EditorClock and remove it on gameplay test
  Bartłomiej Dach · 2025-01-07 11:25:00 +01:00
  a5036cd092
• Use TimingPointAfter for seeking check
  OliBomby · 2024-08-16 01:36:51 +02:00
  3a84409546
• Fix CurrentTimeAccurate being inaccurate if seeking smoothly in the same frame and a transform is already active
  OliBomby · 2024-07-08 13:30:11 +02:00
  2822ba2377
• Fix incorrect test assumption in TestSceneEditorClock

  I don't know what this test was trying to do, but it was wrong. Any
  offset which is applied should be invisible to the clock's final
  `CurrentTime` (and to the user).

  Dean Herbert · 2023-10-06 16:43:28 +09:00
  1005b7ac85
• Disable decoupling for OsuGameBase's beatmap implementation

  This avoids it ever mutating the underlying track (aka attempting to start
  it). Resolves the one caveat mentioned in
  aeef92fa710648d4a00edc523e13c17ac6104125.

  Dean Herbert · 2023-09-22 12:49:25 +09:00
  df08c4e1ad
• Change FramedBeatmapClock to always be decoupled
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  600651795b
• Update clocks in line with framework changes
  Dean Herbert · 2023-09-20 21:17:08 +09:00
  bf984388b3
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix editor not always playing hitsounds with clock offsets applied
  Salman Ahmed · 2022-11-19 05:15:22 +03:00
  016de2f5a0
• Fix velocity test failing with no audio device
  Dan Balasescu · 2022-11-03 13:59:22 +09:00
  fc191807c6
• Account for offset being applied to editor clock time in TestSceneEditorClock
  Dean Herbert · 2022-08-29 16:42:50 +09:00
  2dafa041a7
• Move EditorClock processing to Update and always decouple
  Dean Herbert · 2022-08-26 18:08:43 +09:00
  12d6d6793c
• Use FramedBeatmapClock in EditorClock
  Dean Herbert · 2022-08-26 17:28:58 +09:00
  31e459364b
• Convert == usages to ReferenceEquals
  Dan Balasescu · 2022-06-20 16:56:19 +09:00
  e0c82d11ab
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix EditorClock retaining a reference to potentially outdated ControlPointInfo
  Dean Herbert · 2021-09-14 23:56:57 +09:00
  13f88cbc4e
• Move time clamp to Seek/transformSeekTo methods
  Marvin Schürz · 2021-08-16 20:39:09 +02:00
  78f9f4a230
• Clamping seekTime to beatmap length
  Marvin Schürz · 2021-08-15 14:48:56 +02:00
  d287db7961
• Fix editor arrow seek snapping not updating after control point changes

  The editor clock, which is responsible for performing the seek, was not
  aware of changes in control points due to reading from the wrong
  beatmap. `loadableBeatmap` is not actually changed by any of the editor
  components; `playableBeatmap` and `editorBeatmap` are.
  
  For now this is changed to use `playableBeatmap`. A better follow-up
  would be to use `editorBeatmap`, but it would probably be best to move
  the beat snap bindable into `EditorBeatmap` first.

  Bartłomiej Dach · 2021-04-03 14:02:46 +02:00
  4df7ff21c7
• Further simplify logic
  voidedWarranties · 2021-03-18 16:20:31 -07:00
  b9761c8196
• Improve logic and add previously failing test

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  voidedWarranties · 2021-03-17 15:48:55 -07:00
  df6570ebf5
• Merge branch 'master' into editor-song-end
  Bartłomiej Dach · 2021-03-17 18:18:19 +01:00
  a691291ae8
• Expose and consume boolean covering whether an ongoing smooth seek is running
  Dean Herbert · 2021-01-15 16:14:38 +09:00
  831c06a3c7
• Rename and add xmldoc for smooth seeking method
  Dean Herbert · 2021-01-15 16:14:21 +09:00
  04fa32bc34
• Fix editor seek transform seeking too much
  smoogipoo · 2020-11-02 21:08:58 +09:00
  3956a0669a
• Move editor sample disabling logic to editor class (and support screen switching)
  Dean Herbert · 2020-10-27 14:33:44 +09:00
  e0ad005cc1
• Increase backwards seek magnitude when the track is running

  This matches osu-stable. When the track is running, seeking backwards
  (against the flow) is harder than seeking forwards. Adding a mutliplier
  makes it feel much better.
  
  Note that this is additive not multiplicative because for larger seeks
  the (where `amount` > 1) we don't want to jump an insanely huge amount -
  just offset the seek slightly to account for playing audio.

  Dean Herbert · 2020-10-06 17:53:12 +09:00
  b1a64f89d7
• Use existing bindable flow instead
  Dean Herbert · 2020-09-29 12:50:17 +09:00
  d6f3beffb6
• Handle paused state correctly
  Dean Herbert · 2020-09-29 12:17:38 +09:00
  585b857a0c
• Fix hit samples playing while paused / seeking in the editor
  Dean Herbert · 2020-09-28 18:17:47 +09:00
  4f0c0ea5f9
• Use bindable for track to fix rate adjustments not applying correctly
  Dean Herbert · 2020-09-24 20:56:35 +09:00
  7e7e2fd64a
• Add basic track reloading support while inside the editor
  Dean Herbert · 2020-09-24 20:56:35 +09:00
  978f6edf38
• Perform next timing point check before ensuring movement
  Dean Herbert · 2020-07-17 16:40:02 +09:00
  039790ce4f
• Fix reversing scroll direction not always behaving as expected
  Dean Herbert · 2020-07-17 16:03:23 +09:00
  e96e558728
• Simplify and fix incorrect seeking
  Dean Herbert · 2020-05-22 22:11:55 +09:00
  12d65f305f
• Merge branch 'editor-clock-cache' into editor-clock-transform
  Dean Herbert · 2020-05-22 19:51:02 +09:00
  1486a44b55
• Fix remaining test failures
  Dean Herbert · 2020-05-22 18:23:24 +09:00
  866db629d6
• Add tweening seek support to EditorClock
  Dean Herbert · 2020-05-22 16:47:52 +09:00
  d18eb663b1
• Fix seeking back to beginning too early
  voidedWarranties · 2020-03-23 22:37:53 -07:00
  b41f3f1cad
• Internalize both looping and stopping
  voidedWarranties · 2020-03-13 16:42:05 -07:00
  7e4f58c2d3
• Prevent playback from going beyond song end
  voidedWarranties · 2020-03-11 22:40:08 -07:00
  1d314a1f4b
• Update MathUtils namespace usages
  smoogipoo · 2020-01-09 13:43:44 +09:00
  91735ff367
• .NET Standard 2.1 implements Math.Clamp , use it instead of MathHelper.Clamp from osuTK.
  Berkan Diler · 2019-11-20 13:37:47 +01:00
  6cab517b2d
• Simplify EditorClock.Seek method
  Dean Herbert · 2019-10-30 19:09:46 +09:00
  7f2916454d
• Remove usages of EF internals
  smoogipoo · 2019-10-30 17:05:15 +09:00
  45af796943
• Add grouping of ControlPoints
  Dean Herbert · 2019-10-25 19:52:02 +09:00
  e987db37ec
• Apply newline additions
  Dean Herbert · 2019-04-01 12:16:32 +09:00
  612db31c38
• Update with framework bindable changes
  smoogipoo · 2019-02-21 18:56:34 +09:00
  bca347427f
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7