172 Commits

• Fix quick delete still propagating right click mouse input upwards
  Dean Herbert · 2025-03-12 16:52:36 +09:00
  db7d1f32d7
• Merge branch 'master' into editor-right-click-as-people-expect
  Dean Herbert · 2025-03-12 14:51:28 +09:00
  083979e299
• This method is not being used anymore.

  see:
  https://github.com/ppy/osu/pull/26643

  andy840119 · 2025-03-03 22:10:41 +08:00
  23a5d6dc40
• Add back right-click-for-new-combo and right-click-delete when in compose mode

  Requested too many times to count.
  
  I'm not sure what to do about the code quality of this. It's a bit weird
  that there's no way to check the current composition tool from a higher
  level.
  
  Also it was discussed IRL that there should be some kind of hinting that
  existing notes will be deleted when they are hovered, but I'm not sure
  how well this will work in normal mapping flows, since it will display
  even in cases that users aren't intending to delete an object. Still
  willing to explore this direction though (it's just non-trivial to
  implement so I haven't yet).

  Dean Herbert · 2025-02-26 17:52:33 +09:00
  2738c1a807
• Add hotkey hints to editor menus
  Bartłomiej Dach · 2024-09-04 12:16:54 +02:00
  130802e480
• Merge pull request #29279 from normalid-awa/bugfix/editor/delete-operation-wont-close-the-menu

  Close context menus when deselecting items in editor

  Bartłomiej Dach · 2024-08-07 13:25:13 +02:00
  437812eebe
• Refactor + CI fixes
  Dan Balasescu · 2024-08-06 15:17:52 +09:00
  b91461e661
• Close the menu when selecting other object
  jkh675 · 2024-08-06 13:09:48 +08:00
  cb877b7675
• Make the OsuContextMenu nullable in SelectionHandler
  jkh675 · 2024-08-05 16:32:49 +08:00
  75c0c6a5f9
• Allow placement deletion with middle mouse

  This is in addition to Shift + Right-click.
  
  I thik middle mouse feels more natural and is a good permanent solution
  to this issue.
  
  Note that this also *allows triggering the context menu from placement
  mode*. Until now it's done nothing. This may be annoying to users with
  muscle memory but I want to make the change and harvest feedback. I
  think showing the context menu is more correct behaviour (although
  arguably it should return to placement mode on dismiss?).

  Dean Herbert · 2024-08-05 14:25:09 +09:00
  0557b9ab79
• Merge EditorContextMenuContainer into OsuContextMenuContainer
  jkh675 · 2024-08-04 21:00:43 +08:00
  2145368d17
• Cleanup code
  jkh675 · 2024-08-04 19:56:41 +08:00
  7c83d6a883
• Refactor the code to follow IoC principle and more flexible
  jkh675 · 2024-08-04 19:39:06 +08:00
  3cc5466774
• Implement on beatmap editor
  jkh675 · 2024-08-04 19:16:14 +08:00
  27d6c4cecb
• Allow key event pass through selection handler
  jkh675 · 2024-08-04 19:11:21 +08:00
  5c5fcd7e7e
• Replace original menu container to the custom one
  jkh675 · 2024-08-04 19:08:31 +08:00
  83aeb27c73
• Fix selection box initialy visible despite no items selected
  Salman Ahmed · 2024-07-19 03:00:44 +03:00
  a570949459
• Merge branch 'master' into edit-nodesample
  Bartłomiej Dach · 2024-06-06 13:42:25 +02:00
  86b13074a0
• Merge remote-tracking branch 'upstream/master' into edit-nodesample
  OliBomby · 2024-01-25 11:33:29 +01:00
  c2d57dc77c
• Refactor scale handling in editor to facilitate reuse
  OliBomby · 2024-01-20 00:22:53 +01:00
  26c0d1077a
• Add precise rotation control to osu! editor
  Bartłomiej Dach · 2023-08-16 11:37:52 +02:00
  19f892687a
• Merge branch 'master' into edit-nodesample
  Dean Herbert · 2023-07-31 14:06:38 +09:00
  f06b203067
• Interface with SelectionRotationHandler via DI rather than explicit passing
  Bartłomiej Dach · 2023-07-30 20:21:41 +02:00
  ebe5dd2ac9
• Make SelectionRotationHandler a Component
  Bartłomiej Dach · 2023-07-30 20:18:33 +02:00
  262f25dce8
• Migrate SelectionHandler to use SelectionRotationHandler
  Bartłomiej Dach · 2023-07-23 20:56:22 +02:00
  aec3ca250c
• Add basic structure for new rotation handler
  Bartłomiej Dach · 2023-07-23 20:56:22 +02:00
  ba8ebefb50
• Move out helper methods to static class
  Bartłomiej Dach · 2023-07-23 18:24:20 +02:00
  4622255cc7
• Fix selection handlers eating hotkey presses they didn't handle
  Bartłomiej Dach · 2023-06-28 20:48:22 +02:00
  e4e08c0f5f
• Trigger state change when flipping via hotkey in the editor

  This will trigger a change even if nothing happens. But I think that's
  okay (not easy to avoid) because the change handler should be aware that
  nothing changed, if anything.
  
  Closes https://github.com/ppy/osu/issues/24065.

  Dean Herbert · 2023-06-28 13:52:51 +09:00
  29376ffcc0
• Merge branch 'master' into edit-nodesample
  Dean Herbert · 2023-05-30 14:03:43 +09:00
  4a81d068af
• Ensure selection is reset after immediately deleting objects

  Closes https://github.com/ppy/osu/issues/23518.

  Dean Herbert · 2023-05-25 23:20:32 +09:00
  949de35664
• Simplify SelectionHandler's DeselectAll implementation

  We are already doing other operations in this class directly on `SelectedItems`, so might as well change this one to match

  Dean Herbert · 2023-05-25 18:46:31 +09:00
  1049257b56
• allow editing additions in sample point piece
  OliBomby · 2023-05-08 15:08:40 +02:00
  4c36530435
• Improve visuals of skin blueprint
  Dean Herbert · 2023-02-17 18:19:46 +09:00
  16d94b4ea2
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Make sure all selected items get deleted
  ekrctb · 2022-10-05 21:58:05 +09:00
  0613388aaa
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Fix BlueprintContainer eating input from skin editor buttons
  Salman Ahmed · 2022-06-18 18:28:36 +03:00
  a5e5172b91
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Allow BlueprintContainer and SelectionHandler to receive input outside bounds
  Salman Ahmed · 2022-06-14 00:19:15 +03:00
  c49b8e4a5c
• Revert "Provide context menu items at BlueprintContainer for out-of-bounds support"

  This reverts commit 85fc218edf.

  Salman Ahmed · 2022-06-14 00:02:02 +03:00
  9fc04924eb
• Provide context menu items at BlueprintContainer for out-of-bounds support
  Salman Ahmed · 2022-06-11 20:53:53 +03:00
  85fc218edf
• Use existing web localisation for most hardcoded strings
  Joseph Madamba · 2022-04-20 16:31:11 -07:00
  5e5c8e78a6
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Refactor logic to avoid TimelineSelectionHandler having to block base calls
  Dean Herbert · 2022-01-05 16:56:54 +09:00
  6779503e57
• Add global flip hotkeys
  Dean Herbert · 2022-01-05 16:48:07 +09:00
  866ae3472b
• Add implementation of range selection
  Bartłomiej Dach · 2021-09-26 20:12:26 +02:00
  d3203f83dd
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Adapt to PlatformAction type change
  ekrctb · 2021-07-21 16:12:53 +09:00
  1bac471b49
• Implement proper rotation algorithm for skin editor
  Dean Herbert · 2021-05-20 18:21:16 +09:00
  27e81d6504