3455 Commits

• Merge pull request #34880 from minetoblend/fix/editor-player-crash

  Fix crash when trying to test map in the editor

  Dean Herbert · 2025-09-03 02:31:42 +09:00
  f414dd70f5
• Use better guard (and reword subsequent comment)

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2025-09-02 12:42:07 +02:00
  4ed72efeae
• Use SingleOrDefault() instead of LastOrDefault()

  `LastOrDefault()` is arbitrary, and I hope this doesn't matter for
  anything, because if it does, then that's utterly *horrifying*.

  Bartłomiej Dach · 2025-09-02 08:08:23 +02:00
  903d91b697
• Add one more comment
  Bartłomiej Dach · 2025-09-02 08:08:22 +02:00
  b0dcd06b38
• Fix editor memory leak
  Dan Balasescu · 2025-09-02 09:21:31 +09:00
  cac136d3c6
• Move null check after loop over nested hitobjects
  Marvin Schürz · 2025-09-01 13:13:28 +02:00
  ffb6ae2066
• Fix mismatch in cutoff time check between preventMissOnPreviousHitObjects and markPreviousObjectsHit
  Marvin Schürz · 2025-09-01 13:05:22 +02:00
  385529ec78
• Revert moving markPreviousObjectsHit into LoadAsyncComplete

  Running that there caused a test failure due to modifying drawables' transforms outside the update thread

  Marvin Schürz · 2025-09-01 12:10:12 +02:00
  060854f23a
• Prevent npr in tests due to drawable ruleset not being available
  Marvin Schürz · 2025-09-01 11:12:19 +02:00
  689cc27e68
• Move markPreviousObjectsHit into LoadAsyncComplete
  Marvin Schürz · 2025-09-01 11:11:26 +02:00
  da7e256302
• Recursively update hit results for nested drawables
  Marvin Schürz · 2025-09-01 11:10:30 +02:00
  9827f9f189
• Fix crash when marking previous objects as hit
  marvin · 2025-08-30 19:36:17 +02:00
  d6b4c2958d
• Fix navigating back and forth from beatmap submission settings screen crashing

  supersedes https://github.com/ppy/osu/pull/34656

  Bartłomiej Dach · 2025-08-14 12:57:10 +02:00
  3bfa7bf862
• pass on BeatmapManager directly
  Hivie · 2025-08-09 11:59:20 +01:00
  172a48f1ac
• refactor verifier context to use a static factory method for creating instances with beatmap resolution
  Hivie · 2025-08-07 01:52:50 +01:00
  c5f4feb725
• Fix looping samples again
  Bartłomiej Dach · 2025-08-06 19:24:12 +02:00
  dbf60763eb
• simplify filtering logic
  Hivie · 2025-08-04 14:22:02 +01:00
  bb156d4206
• define general checks with a bool in CheckMetadata instead of an interface
  Hivie · 2025-08-04 14:12:59 +01:00
  ed301ec114
• rename scopes
  Hivie · 2025-08-04 14:02:40 +01:00
  8a2053bf61
• simplify bool check
  Hivie · 2025-08-01 22:03:49 +01:00
  8d76ebae29
• add ability to filter checks via scope
  Hivie · 2025-08-01 21:41:21 +01:00
  ca8a821dca
• Fix editor metadata section reload potentially confusing title and author

  Probably closes https://github.com/ppy/osu/issues/34449. I say probably
  because I couldn't break this myself without commenting out chunks of
  code that apply the metadata from the id3 tags, and the reporter of that
  issue did not provide mp3s to test with or a clear reproduction
  scenario. But chances are this is going to fix the problem anyhow.

  Bartłomiej Dach · 2025-07-31 10:58:43 +02:00
  d7a17d59e3
• Add divisor colour for 5,7,9 snaps

  Closes https://github.com/ppy/osu/issues/34385#issuecomment-3117984457.

  Dean Herbert · 2025-07-29 13:30:04 +09:00
  de637f6434
• Revert "Update framework"

  This is temporary until we have a fix for
  https://github.com/ppy/osu/issues/34340, which will require resolution
  in bass-side thread
  https://www.un4seen.com/forum/?topic=20482.msg145307#msg145307.

  Dean Herbert · 2025-07-24 22:38:08 +09:00
  d36c50de13
• Merge pull request #34181 from Hiviexd/verify/check-lowest-diff-drain

  Add verify check for lowest diff drain/play time requirements

  Bartłomiej Dach · 2025-07-22 08:38:59 +02:00
  c408d60fbe
• Merge pull request #34290 from chris-ehmann/fix-editor-bg

  Fix editor background not updating in certain scenarios

  Bartłomiej Dach · 2025-07-22 08:32:48 +02:00
  f023d3b737
• Resolve IBindable<WorkingBeatmap> via DI in EditorBackgroundScreen
  Chris Ehmann · 2025-07-21 20:58:09 -07:00
  aeb1941cf9
• reduce whitespace
  Hivie · 2025-07-21 12:22:43 +01:00
  72254226cf
• Fix editor background not updating in certain scenarios
  Chris Ehmann · 2025-07-18 20:55:45 -07:00
  dd09a2487e
• Merge pull request #34280 from EVAST9919/editor-triangles-aa

  Add antialiasing to triangles in `MarkerVisualisation`

  Dean Herbert · 2025-07-19 00:44:08 +09:00
  edbf051d0e
• Fix potential div-by-zero
  Andrei Zavatski · 2025-07-18 15:55:33 +03:00
  04cd91bd36
• Use boxes with inflation instead of a shader
  Andrei Zavatski · 2025-07-18 15:52:51 +03:00
  0f2a078447
• Combine CentreMarker with MarkerVisualisation
  Andrei Zavatski · 2025-07-18 13:19:41 +03:00
  5cb51e5e21
• Move xmldoc to correct place
  Andrei Zavatski · 2025-07-18 12:46:21 +03:00
  c8eae6fd86
• Add xmldoc explaining the purpose of VerticalTrianglesDrawNode
  Andrei Zavatski · 2025-07-18 12:43:58 +03:00
  a7da7554bc
• Add antialiasing to triangles in MarkerVisualisation
  Andrei Zavatski · 2025-07-18 12:25:54 +03:00
  8362456148
• Fix looping sample implementation
  Dean Herbert · 2025-07-18 18:12:30 +09:00
  7f55cc5b4f
• fix ci
  Hivie · 2025-07-16 02:08:07 +01:00
  83ad34b718
• address review

  - add TODO for refactoring verifier context ctor
  - call `GetPlayableBeatmap()` in verifier context ctor
  - filter diffs with relevant ruleset in check logic
  - fix tests

  Hivie · 2025-07-16 01:53:22 +01:00
  747bff1df9
• include all of a beatmapset's diffs in the verifier context
  Hivie · 2025-07-13 01:53:07 +01:00
  f1eb7d367b
• add more predefined divisors to match stable
  Hivie · 2025-07-12 19:48:27 +01:00
  8c1e0b4d66
• Merge pull request #30226 from smallketchup82/skin-mounting

  Add skin mounting flow

  Dean Herbert · 2025-07-01 19:03:57 +09:00
  64702950e5
• Use OverlayColourProvider for BeatDivisorControl icon colour
  Marvin Schürz · 2025-07-01 10:38:22 +02:00
  709bc9c330
• Change icon colour of BeatDivisorControl to be light
  marvin · 2025-06-30 18:43:37 +02:00
  ccc1a7ae6f
• Merge branch 'master' into skin-mounting
  Bartłomiej Dach · 2025-06-30 12:53:55 +02:00
  368850967b
• Merge pull request #33856 from peppy/fix-skin-editor-rotation

  Fix rotating objects in the skin editor not rotating as expected

  Bartłomiej Dach · 2025-06-24 12:01:07 +02:00
  ea613a39e6
• Fix rotating objects in the skin editor not rotating as expected

  Closes https://github.com/ppy/osu/issues/33845.
  
  Not sure if this ever worked but it was definitely wrong for a while
  now.

  Dean Herbert · 2025-06-24 10:39:56 +02:00
  4123d4a80d
• Fix very short kiai sections not showing up on editor summary timeline

  Closes https://github.com/ppy/osu/issues/33836.

  Dean Herbert · 2025-06-24 14:54:54 +09:00
  dbdf2d9aca
• Pick better initial beatmap status when submitting

  Addresses https://github.com/ppy/osu/discussions/33291
  
  This is a half-baked RFC because things are awkward.
  
  For this to work correctly the submission flow has to do an API request,
  because one, the local beatmap status has been overwritten with "locally
  modified", and secondly, even if it *was* there, there's no guarantee
  that it was actually *up to date*.
  
  And if we have to do an API request then there are two choices:
  
  - Hard block on the API request and don't show anything until it
    completes which possibly means waiting at a spinner for several
    seconds if someone's on bad internet.
  
  - Don't block on the API request --- but then there's no guarantee
    what timing the API request completes at, which means that possibly the
    user could change the dropdown before the API request completes, and
    the API request will overwrite their choice, so to prevent that block
    the dropdown until the request completes. This is what this commit
    does.

  Bartłomiej Dach · 2025-06-12 10:38:22 +02:00
  a38e25115b
• Fix timeline not updating ticks correctly after arbitrary timing control point changes (again)

  Closes https://github.com/ppy/osu/issues/33393.
  
  This is admittedly a half-assed diff. This was apparently "fixed" once
  before, eons ago, in https://github.com/ppy/osu/pull/11032, but I'm not
  sure whether it regressed, or where, because I don't want to bisect four
  years back. (At that time `ControlPointInfo.ControlPointsChanged`
  did not exist yet.)
  
  Also there's the part where changes to control points do not undo or
  redo (see https://github.com/ppy/osu/issues/31942), but I'm not touching
  that *either*, because if I start touching that, then I will get yelled
  at for not reviewing the 2.5k line PR that rewrites the entirety of
  change handling in editor instead
  (https://github.com/ppy/osu/pull/30314). I will attempt to get through
  that mental block sometime within the year. Please do not rush me.
  
  The cheap cop-out argument is that hooking this up to `ControlPointInfo`
  specifically is probably "more efficient" anyway.

  Bartłomiej Dach · 2025-06-10 14:44:23 +02:00
  f5aeedc7e1