638 Commits

• Standardise HasReplay implementation (and remove from persisting to realm)
  Dean Herbert · 2022-07-15 16:14:21 +09:00
  c8c79d2185
• Add "F" ScoreRank to handle old scores which have this specified

  Not sure on the future of this, but given it is used in the
  save-failed-reply pull request (#18785) I think it's fine to add back
  for now.
  
  Without this, JSON parsing of older scores in server-side storage will
  fail on missing enum type.

  Dean Herbert · 2022-07-15 15:58:54 +09:00
  6122d2a525
• Simplify population logic and match code style
  Salman Ahmed · 2022-07-11 21:51:09 +03:00
  4f009419b8
• Assign missing UserID to RealmUser
  Andrew Hong · 2022-07-11 02:36:51 -04:00
  10d6027c89
• Use debug.assert for better readable.
  andy840119 · 2022-07-03 19:27:56 +08:00
  8c2f4b48fc
• Use AsNonNull() instead.
  andy840119 · 2022-07-02 19:48:32 +08:00
  0a1543c6e8
• pretend that the beatmap property will not be null.

  Not really throw exception will be the better way?

  andy840119 · 2022-07-02 13:20:46 +08:00
  c6d0f0f81b
• Merge branch 'master' into importer-post-import-rename
  Bartłomiej Dach · 2022-06-20 13:37:16 +02:00
  577a87bcad
• PostImport -> PresentImport
  Dean Herbert · 2022-06-20 18:36:29 +09:00
  dbae4c6f5a
• Remove necessity to provide BeatmapDifficultyCache as a function to ScoreManager
  Dean Herbert · 2022-06-20 17:52:42 +09:00
  ebcee21f6f
• Rename Import(TModel) to ImportModel to differentiate from other import methods
  Dean Herbert · 2022-06-20 15:18:07 +09:00
  92f1a2958c
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add back missing notification flow
  Dean Herbert · 2022-06-16 19:48:18 +09:00
  e66ccfd980
• Reimplement missing methods
  Dean Herbert · 2022-06-16 19:05:25 +09:00
  ce3d3a967c
• Remove local realm fields in manager classes
  Dean Herbert · 2022-06-16 18:56:53 +09:00
  72c5b9009d
• Remove RealmArchiveModelManager from hierarchy
  Dean Herbert · 2022-06-16 18:53:13 +09:00
  f3984d98e6
• Rename Score/Skin ModelManager classes to Importer for now
  Dean Herbert · 2022-06-16 18:11:50 +09:00
  4d9e3d1982
• Move remaining realm classes out of Stores namespace
  Dean Herbert · 2022-06-15 21:56:00 +09:00
  f23ddfe6cc
• Rename lowPriority to batchImport
  Dean Herbert · 2022-06-15 00:46:00 +09:00
  88d5e074a8
• Skip quick import clause when importing a single item

  Closes https://github.com/ppy/osu/issues/18600.

  Dean Herbert · 2022-06-15 00:26:34 +09:00
  2f8290831a
• Remove unused lowPriority flag from one Import method
  Dean Herbert · 2022-06-14 19:52:30 +09:00
  9f599a5ab4
• Tidy up various delegation implementations
  Dean Herbert · 2022-06-14 19:46:59 +09:00
  ca0765a932
• Add xmldoc to ScoringValues
  Dan Balasescu · 2022-06-02 16:39:51 +09:00
  773ba97117
• Rename member
  Dan Balasescu · 2022-06-02 16:35:50 +09:00
  a638392e81
• Move raw ScoreProcessor values into ScoringValues struct
  Dan Balasescu · 2022-05-31 19:39:38 +09:00
  af0f934e1a
• Prevent scores being calculated twice
  Dan Balasescu · 2022-03-30 13:15:41 +09:00
  4df63a4900
• Fix scores sometimes shown with incorrect scoring mode
  Dan Balasescu · 2022-03-30 13:03:12 +09:00
  bd9c0076df
• Use a constant for the early version timing offset
  Dean Herbert · 2022-03-24 16:43:41 +09:00
  a7554dcdf7
• Apply beatmap offsets to legacy replay frame handling
  Dean Herbert · 2022-03-24 16:16:40 +09:00
  a7d5f2281c
• Obsolete BeatmapInfo.MaxCombo and suppress in usages
  Salman Ahmed · 2022-03-20 16:30:29 +03:00
  b9859f9f21
• Add note about null return value
  Salman Ahmed · 2022-03-20 16:24:30 +03:00
  aef40da8d4
• GetBeatmapMaximumComboAsync -> GetMaximumAchievableComboAsync
  Salman Ahmed · 2022-03-20 16:18:53 +03:00
  2a78042038
• Introduce method for computing maximum achievable combo properly
  Salman Ahmed · 2022-03-20 05:38:14 +03:00
  d36f32a9c9
• Restructure PerformanceCalculator to not require ScoreInfo argument
  Dan Balasescu · 2022-03-14 14:25:28 +09:00
  4a3e3aba65
• Merge branch 'master' into scoreprocessor-rework
  Dean Herbert · 2022-03-09 23:04:18 +09:00
  94ff6a338f
• Rework GetScore() method signatures + implementations

  Rename legacy-facing overload to mention as much

  Dan Balasescu · 2022-03-08 22:30:44 +09:00
  f1c40bd9ed
• Fix scores not being recalculated in beatmap listing
  Dan Balasescu · 2022-03-08 19:07:39 +09:00
  f5cd967635
• Replace remaining manual online ID check with extension method
  Bartłomiej Dach · 2022-03-03 23:09:56 +01:00
  36263b4dbf
• Use constant for maximum legacy ruleset id
  Dean Herbert · 2022-03-01 12:07:03 +09:00
  eb75a29b20
• Enable nullable for LegacyScoreEncoder
  Dean Herbert · 2022-02-28 18:42:23 +09:00
  52e50db6b9
• Only convert non-legacy frames (and throw on conversion failure)
  Dean Herbert · 2022-02-28 18:42:23 +09:00
  723e96309a
• Allow LegacyScoreEncoder to be used without a beatmap if frames are already legacy frames
  Dean Herbert · 2022-02-28 18:42:23 +09:00
  2e96f74c94
• Scale classic score by hitobject count
  Dan Balasescu · 2022-02-21 13:31:03 +09:00
  c3b365cf6b
• Merge branch 'master' into display-performance-attributes
  Henry Lin · 2022-02-05 16:59:46 +08:00
  f29301cd1e
• Remove IIpcHost param from ScoreManager

  No longer used since 3e3b9bc963.

  Bartłomiej Dach · 2022-02-01 21:35:40 +01:00
  16e0cc6a2b
• Fix delete local scores crashing the game
  Dean Herbert · 2022-01-28 15:54:53 +09:00
  0d3ac4fd9c
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Fix some score imports failing due to null string attempted to be parsed as json
  Dean Herbert · 2022-01-26 22:46:29 +09:00
  378173cc66
• Merge pull request #16622 from peppy/fix-results-score-switch-crash

  Fix crash at results screen when viewing another score panel after playing

  Dan Balasescu · 2022-01-26 16:59:39 +09:00
  4a51bab9ac
• Fix ScoreInfo.RealmUser not getting deep cloned correctly

  I'm still not at all happy with the play-to-results flow (with multiple
  clones), but this will have to do for now.

  Dean Herbert · 2022-01-26 14:27:48 +09:00
  3491b77c8c