638 Commits

• Treat guest user scores & scores of unknown users as the local user's
  Bartłomiej Dach · 2025-09-03 12:05:03 +02:00
  f1a020d2c6
• Extract helper method for retrieving all user local scores
  Bartłomiej Dach · 2025-09-03 12:05:02 +02:00
  0bbad3e1cd
• Throw another exception better
  Bartłomiej Dach · 2025-07-28 11:38:50 +02:00
  2ffb5cbec5
• Rename {-> Max}Combo sort mode

  I have a feeling this is going to save asses in an indeterminate future.

  Bartłomiej Dach · 2025-07-28 11:38:17 +02:00
  f489ffdfd7
• Merge branch 'master' into local-score-sorting-v2
  Bartłomiej Dach · 2025-07-28 11:32:59 +02:00
  c620d58bc2
• Store pause timestamps (rounded to ms) instead of general count
  Bartłomiej Dach · 2025-07-22 09:26:12 +02:00
  d8900defd3
• Store score pause count to replays
  Bartłomiej Dach · 2025-07-07 11:00:31 +02:00
  2b6dab1e9d
• Store score pause count to realm database
  Bartłomiej Dach · 2025-07-07 11:00:31 +02:00
  c83dcdc915
• Track count of times gameplay was paused on ScoreInfo
  Bartłomiej Dach · 2025-07-07 11:00:30 +02:00
  f082b60c9b
• Fix very old lazer replays failing to decode

  See
  https://discord.com/channels/188630481301012481/1097318920991559880/1389240665061462047.
  
  I hope this was worth it.

  Bartłomiej Dach · 2025-07-01 10:14:27 +02:00
  654faa553a
• Throw ArgumentOutOfRangeException on default path
  Dani211e · 2025-06-27 04:28:44 +02:00
  6e73a9299e
• RankingsSort -> LeaderboardSortMode
  Dani211e · 2025-06-26 19:03:49 +02:00
  c1a34d8c6a
• Merge pull request #33612 from bdach/stable-scores-with-zero-legacy-id

  Fix stable scores importing with a `LegacyOnlineID` of 0

  Dean Herbert · 2025-06-25 16:50:45 +09:00
  4b665842fb
• Add sorting dropdown

  Only use sorting when on local scope otherwise hide

  Dani211e · 2025-06-25 05:01:40 +02:00
  ad35dad46d
• Add support for showing leaderboard in playlists and daily challenge

  As touched on in https://github.com/ppy/osu/pull/33581.

  Bartłomiej Dach · 2025-06-11 11:21:26 +02:00
  4810c7c847
• Fix stable scores importing with a LegacyOnlineID of 0

  Closes https://github.com/ppy/osu/issues/33435.
  
  The root cause of the issue is that the user's database contained a
  whole lot of scores with `LegacyOnlineID` of 0, which would trip up
  
  	https://github.com/ppy/osu/blob/97e6187f0d7c3dbee896596a623e34627135bf0e/osu.Game/Extensions/ModelExtensions.cs#L128-L129
  
  as that method would thus consider scores that are not the same as the
  same because of the zero, which later trips up
  
  	https://github.com/ppy/osu/blob/97e6187f0d7c3dbee896596a623e34627135bf0e/osu.Game/Screens/Ranking/SoloResultsScreen.cs#L79
  
  which ends up inserting `Score` into the list several times, which
  causes the crash.
  
  You might remember that I tried to fix this once before in
  https://github.com/ppy/osu/pull/24794. What I did not realise, however,
  is that stable *can still produce replays* that have an online ID of
  zero in them, because zero *is just `default(long)`*:
  
  	https://github.com/peppy/osu-stable-reference/blob/7205341bb70000a87fa1bd54e7642772e2af85d7/osu!/GameplayElements/Scoring/Score.cs#L123
  	https://github.com/peppy/osu-stable-reference/blob/7205341bb70000a87fa1bd54e7642772e2af85d7/osu!/GameplayElements/Scoring/Score.cs#L350
  
  The alternative way of fixing this would be just to change
  `MatchesOnlineID` to reject zeroes, but I think this is a saner overall
  direction.

  Bartłomiej Dach · 2025-06-10 11:54:11 +02:00
  d4fc6693b4
• Fix possible replay playback inaccuracy with very large lead-in time

  Closes https://github.com/ppy/osu/issues/22086
  
  While this *is* a case of aspire-tier breakage, I hesitate to dismiss it
  as wontfix, because the fix is somewhat easy, and probably results in
  better accuracy across the board.
  
  The issue in question here manifests when there is a significant amount
  of lead-in time, like what the beatmap linked in the aforementioned
  issue (https://osu.ppy.sh/beatmapsets/948643#osu/1981090) does.
  
  Both stable and lazer record replay frames using absolute timestamps,
  *but* the legacy replay format after the first frame uses time *deltas*,
  i.e. amounts of time elapsed since the previous frame. This means that
  the decoding process of the replay has to reconstruct absolute timestamps
  by doing cumulative summation starting from the first frame.
  
  When the very first frame has a timestamp that is very large in
  magnitude (say, like the negative 2 billion that the beatmap in question
  uses), this will lead to error if the cumulative summation is using
  floating point numbers, because it will be adding a small magnitude
  frame delta to a large magnitude cumulative absolute time. Which means
  that sometimes adding the frame delta to the cumulative time *will not
  change the cumulative time*, leading to the loss of time and thus replay
  de-synchronisation.
  
  Knowing that the legacy replay format only deals in integral time
  values, however, this can be circumvented by just using a large enough
  integral number type for the cumulative time tracking instead. I think
  `long` in this case can be safely used "large enough" for our purposes:
  
  	> Console.WriteLine(long.MaxValue);
  	9223372036854775807
  
  	9 223 372 036 854 775 807 ms equals 292 277 024,6269277149 years

  Bartłomiej Dach · 2025-05-16 12:52:49 +02:00
  56e17dd7ba
• Fix presenting score potentially dying due to deleted beatmap

  - Closes https://github.com/ppy/osu/issues/27168
  - Closes https://github.com/ppy/osu/issues/32930
  
  It's a little manual (if you perform any of the scenarios in the issues
  above on this branch, the first click will re-import the beatmap but not
  start the replay, and only the second will play it), but maybe fine?

  Bartłomiej Dach · 2025-04-24 08:47:08 +02:00
  c52dce0f38
• Refuse to import scores specifying incompatible mods

  Supersedes https://github.com/ppy/osu/pull/32817.
  
  The messaging of the failure to the user is maybe not the cleanest, but
  I'm not sure it's worth putting time in to improve it?

  Bartłomiej Dach · 2025-04-17 10:10:07 +02:00
  485c3e8e53
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Use RealmLive in SaveFailedScoreButton

  This also optimises the manager classes to better support `Live` usage
  where the managed object is already in a good state (ie. doesn't require
  re-fetching).

  Dean Herbert · 2024-11-27 15:25:42 +09:00
  5260a401d4
• Expose no-op constructors as protected
  Dean Herbert · 2024-10-18 13:30:29 +09:00
  8193038986
• Fix mouseX legacy replay parsing for high key counts in mania
  clayton · 2024-08-11 09:45:43 -07:00
  9620c58751
• Add basic flow for mounting beatmaps for external editing
  Dean Herbert · 2024-07-10 18:29:51 +09:00
  d3c66e2404
• Merge branch 'master' into negative-frame-handling
  Dan Balasescu · 2024-05-29 13:14:59 +09:00
  655b0f5343
• Do not attempt to match score by equality of hash if it's empty

  Closes https://github.com/ppy/osu/issues/28216.
  
  The affected user's database contained six sentakki scores with an empty
  hash. When an online score is being imported, an online model (which
  does not have a hash) will be transmogrified into a `ScoreInfo` with
  an empty hash, which would end up accidentally matching those scores
  and basically breaking everything at that point.
  
  To fix, avoid attempting to match anything on empty hash. This does not
  break online score matching because for those cases the actual online ID
  of the score will be used.

  Bartłomiej Dach · 2024-05-20 15:05:41 +02:00
  ed498f6eed
• Use hash rather than online ID as primary lookup key when presenting score

  Something I ran into when investigating
  https://github.com/ppy/osu/issues/28169.
  
  If there are two scores with the same online ID available in the
  database - for instance, one being recorded locally, and one recorded by
  spectator server, of one single play - the lookup code would use online
  ID first to find the score and pick any first one that matched. This
  could lead to the wrong replay being refetched and presented / exported.
  
  (In the case of the aforementioned issue, I was confused as to whether
  after restarting spectator server midway through a play and importing
  the replay saved by spectator server after the restart, I was seeing a
  complete replay with no dropped frames, even though there was nothing in
  the code that prevented the frame drop. It turns out that I was getting
  presented the locally recorded replay instead all along.)
  
  Instead, jiggle the fallback preference to use hash first.

  Bartłomiej Dach · 2024-05-14 11:16:50 +02:00
  03a279a48d
• Merge branch 'master' into pre-mod-multiplier-score
  Bartłomiej Dach · 2024-05-08 13:39:44 +02:00
  c9414da5d4
• Use score.User.OnlineID instead of score.UserID

  You'd hope that they'd be the same thing, but
  post-https://github.com/ppy/osu-server-spectator/pull/230 it turns out
  that cannot be guaranteed, so just attempt to use `User` in the encoder
  consistently everywhere...

  Bartłomiej Dach · 2024-05-06 16:29:03 +02:00
  9c6968c13a
• Look up users by ID if available when importing scores
  Bartłomiej Dach · 2024-05-06 13:24:34 +02:00
  abfb2c00bc
• Decode user ID from score if available
  Bartłomiej Dach · 2024-05-06 12:28:13 +02:00
  554ead0d9d
• Encode user ID to replays
  Bartłomiej Dach · 2024-05-06 12:28:13 +02:00
  4d9ccdc3b2
• Do not perform username lookups for scores without an online ID
  Bartłomiej Dach · 2024-05-03 13:59:36 +02:00
  afb491dff0
• Merge pull request #28058 from frenzibyte/export-score-rank

  Preserve score rank on lazer scores during encode/decode

  Bartłomiej Dach · 2024-05-02 08:44:10 +02:00
  555305bf7f
• Preserve score rank on encode/decode
  Salman Ahmed · 2024-05-01 23:31:23 +03:00
  0106f1fe3e
• Disable inconsistent naming in some fields of ScoreRank
  Salman Ahmed · 2024-05-01 17:22:10 +03:00
  97fc2a5473
• Return Task.CompletedTask instead of null
  Joseph Madamba · 2024-04-22 11:22:39 -07:00
  35eddf35c5
• Improve xmldoc wording
  Joseph Madamba · 2024-04-22 11:17:27 -07:00
  a59bf6d373
• Add xmldoc to GetScore() and Export() and remove xmldoc from private getDatabasedScoreInfo()
  Joseph Madamba · 2024-04-17 21:52:36 -07:00
  d08b1e5ae7
• Export and import TotalScoreWithoutMods to replays (or recalculate if it missing)
  Bartłomiej Dach · 2024-04-17 09:08:15 +02:00
  2f1a4cdaa4
• Add ScoreInfo.TotalScoreWithoutMods
  Bartłomiej Dach · 2024-04-17 08:51:53 +02:00
  a386068ed3
• Make getDatabasedScoreInfo() private and move to GetScore() and Export()
  Joseph Madamba · 2024-04-15 20:48:51 -07:00
  514e316b49
• Fix replay export not working correctly from online leaderboards
  Joseph Madamba · 2024-04-14 16:22:58 -07:00
  ed8b596325
• Enable NRT to ScoreManager
  Joseph Madamba · 2024-04-14 15:53:29 -07:00
  f282152f99
• Bump legacy score version to recalculate all scores
  Bartłomiej Dach · 2024-03-25 19:27:38 +01:00
  73926592b9
• Rewrite handling of legacy replay frame quirks to match stable closer
  Bartłomiej Dach · 2024-03-21 21:11:29 +01:00
  990a07af0e
• Merge branch 'master' into negative-frame-handling
  Bartłomiej Dach · 2024-03-21 16:45:35 +01:00
  c47463ee0e
• Compare against MaxCombo instead
  Dan Balasescu · 2024-03-19 17:46:18 +09:00
  f6069d8d93
• Remove added property, use local decoding instead
  Dan Balasescu · 2024-03-19 17:44:37 +09:00
  6e33509417
• Fix incorrectly encoded score IsPerfect value
  Dan Balasescu · 2024-03-19 17:20:59 +09:00
  af713a7869