181 Commits

• Fix code quality
  Bartłomiej Dach · 2025-07-30 15:00:55 +02:00
  640fe5752d
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Add new ruleset method responsible for displaying beatmap attributes consistently everywhere

  The intention is to use this in every place that wishes to display
  beatmap attributes (and also remove a bunch of local hack-arounds for
  mania, etc.)

  Bartłomiej Dach · 2025-07-30 13:41:19 +02:00
  e2a454ae00
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Ignore casing when matching mods acronyms
  Dan Balasescu · 2024-10-31 08:55:42 +09:00
  372162de5d
• Redo the layout of sections based on discord feedback

  See
  https://discord.com/channels/188630481301012481/188630652340404224/1291358770064130140
  and everything after.

  Bartłomiej Dach · 2024-10-03 13:53:21 +02:00
  99eb26b7d5
• Add property EditorShowScrollSpeed to Ruleset
  OliBomby · 2024-08-22 19:53:34 +02:00
  998b5fdc12
• Remove setup screen controls that do nothing useful

  Before I go with a hammer to redesign these, I want to remove stuff that
  does nothing first.
  
  Hard-breaks API to allow rulesets to specify an enumerable of custom
  sections rather than two specific weird ones.
  
  For specific rulesets:
  
  - osu!:
    - Stack leniency slider merged into difficulty section.
  - osu!taiko:
    - Approach rate and circle size sliders removed.
    - Colours section removed.
  - osu!catch:
    - No functional changes.
  - osu!mania:
    - Special style toggle merged into difficulty section.
    - Colours section removed.

  Bartłomiej Dach · 2024-07-10 14:53:16 +02:00
  c8a64c5950
• Split mania difficulty section implementation off completely from base

  - "Circle size" / key count needs completely different handling.
  - Approach rate does not exist in mania.

  Bartłomiej Dach · 2024-06-11 11:30:20 +02:00
  10af642342
• Tidy up GetRateAdjustedDisplayDifficulty implemetations
  Dean Herbert · 2023-12-13 17:13:21 +09:00
  9a982a9564
• Rename method and adjust xmldoc to be very explicit about how wrong this is
  Dean Herbert · 2023-11-17 17:04:20 +09:00
  9172632b0b
• Merge branch 'master' into arod_rate_adjust
  Dean Herbert · 2023-11-12 15:49:07 +09:00
  6bd5eda2a0
• Update Ruleset.cs
  Givikap120 · 2023-11-10 15:05:26 +02:00
  d0d334a371
• FIxed stated problems
  Givikap120 · 2023-11-10 15:02:15 +02:00
  9ef34fa51a
• Improve code quality
  Givikap120 · 2023-11-04 17:25:09 +02:00
  57170501cd
• Generalise notion of 'touch device' mod
  Bartłomiej Dach · 2023-11-02 19:14:05 +01:00
  9f11a04cc7
• Added BeatmapAttributesDisplay support
  Givikap120 · 2023-09-12 16:44:44 +03:00
  1a70110a4e
• fixed stated problems

  removed functions from `Ruleset.cs` and added a `GetEffectiveDifficulty()` instead

  Givikap120 · 2023-08-26 02:13:14 +03:00
  290f8db341
• Fixed "works only for std" problem

  1) Now it use AR/OD calculation from Ruleset class
  2) Implemented needed functions in each of default rulesets

  Givikap120 · 2023-08-25 00:58:26 +03:00
  17b9b1649a
• Fix "key count" setting showing as "circle size" in osu!mania editor

  Closes https://github.com/ppy/osu/issues/12904.

  Dean Herbert · 2023-07-21 18:52:29 +09:00
  fd2bdc10c7
• Implement back-and-forth conversion of ModScoreV2 and LegacyMods
  Bartłomiej Dach · 2023-07-09 16:15:21 +02:00
  7be5e0e978
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Remove usages of [ExcludeFromDynamicCompile]
  Dan Balasescu · 2023-05-08 18:12:56 +09:00
  d2380bd840
• Use generic Enum methods
  Berkan Diler · 2022-12-26 20:36:39 +01:00
  c7ca4bbba5
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins
  Dean Herbert · 2022-09-15 20:18:10 +09:00
  c7f8f948b9
• Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset.
  andy840119 · 2022-09-10 11:07:23 +08:00
  3d7367a842
• Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset

  # Conflicts:
  #	osu.Game.Rulesets.Catch/CatchRuleset.cs
  #	osu.Game.Rulesets.Osu/OsuRuleset.cs
  #	osu.Game.Rulesets.Taiko/TaikoRuleset.cs
  #	osu.Game/Rulesets/Ruleset.cs

  andy840119 · 2022-09-10 10:40:12 +08:00
  e62999fb16
• Remove "internal" identifier as unnecessary
  Dean Herbert · 2022-08-29 14:01:15 +09:00
  90b9c02ac6
• Add ruleset API versioning
  Dean Herbert · 2022-08-22 16:35:08 +09:00
  f5710d8000
• Update GetVariantName to also support localisation
  Dean Herbert · 2022-08-22 14:51:00 +09:00
  d199b3b100
• Localise hit result name
  naoei · 2022-08-14 14:57:02 -04:00
  45e9eda9e7
• Revert localisation for GetDisplayNameForHitResult

  Came across an issue where `LeaderboardScoreTooltip` attempts to capitalize all letters for the `displayName`.
  
  Unsure if I should completely ignore it and localise it anyway.

  naoei · 2022-08-10 16:03:59 -04:00
  1e356f6137
• Change most ruleset-accessible string types to Localisable strings
  naoei · 2022-08-10 15:51:11 -04:00
  8cb2e11766
• Mark CreateHitObjectComposer() accept null.

  And add the null check in the test case.

  為什麼 · 2022-07-10 10:15:27 +08:00
  8e1ed1c621
• Mark the CreateBeatmapProcessor() as nullable.

  Also, should add the null check in the working beatmap.

  為什麼 · 2022-07-10 10:15:27 +08:00
  57c6763556
• Mark CreateConfig() return type as nullable because it's not required all ruleset to implement.

  Also, remove nullable disable annotation for all using classes.
  
  Setting store can be nullable because `RulesetConfigManager()` can accept null setting store.

  為什麼 · 2022-07-10 10:15:27 +08:00
  d39f53f1f0
• Move CreateConvertibleReplayFrame() into legacy ruleset interface because technically only legacy ruleset use it to convert the legacy frame.

  But seems some of the customized ruleset use it for save the replay frame.

  為什麼 · 2022-07-10 10:15:27 +08:00
  857377e145
• Mark create beatmap verifier as nullable because seems it's not requirement to be implemented.
  為什麼 · 2022-07-10 10:10:43 +08:00
  e67cb4c905
• Remove unnecessary attribute.
  為什麼 · 2022-07-10 10:10:43 +08:00
  4a503bab0a
• Remove nullable disable annotation and mark some return value as nullable.
  為什麼 · 2022-07-10 09:29:17 +08:00
  855debd5f6
• Attach DT with NC, SD with PF, and Cinema with Autoplay
  Dan Balasescu · 2022-06-30 11:52:30 +09:00
  edc4ace17e
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fill out GetModsFor() xmldoc and annotate items as non-null
  Bartłomiej Dach · 2022-06-15 17:40:15 +02:00
  30382b0445
• Require ScoreProcessor to receive ruleset
  Dan Balasescu · 2022-03-14 15:51:10 +09:00
  3fff7f4b7e
• Restructure PerformanceCalculator to not require ScoreInfo argument
  Dan Balasescu · 2022-03-14 14:25:28 +09:00
  4a3e3aba65
• Make Ruleset.RulesetInfo get only
  Dean Herbert · 2022-01-27 15:36:35 +09:00
  e67b1fe0ec
• Update mock RulesetInfo usage to set OnlineID instead of ID
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  f283770f34
• Add back allowance for tests scenes using empty ShortName
  Dean Herbert · 2021-11-22 21:41:09 +09:00
  6c36770eb3