47 Commits

• Populate default LegacyType value on convert hitobjects

  Normally not an issue, but some tests create their own hitobjects
  deriving from `ConvertHitObject`.

  Dan Balasescu · 2024-12-06 17:47:14 +09:00
  8dda5aada8
• Merge implementations of ConvertHitObjectParser

  Having these be separate implementations sounded awesome at the time,
  but it only ever led to confusion. There's no practical difference if,
  for example, catch sees hitobjects with `IHasPosition` instead of
  `IHasXPosition`.

  Dan Balasescu · 2024-11-11 15:09:13 +09:00
  e1d93a7d9c
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Move LegacyLastTickOffset specification to generation code and stop passing everywhere
  Dean Herbert · 2023-09-29 14:32:29 +09:00
  81485c548c
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• fix implementations of IHasSliderVelocity
  OliBomby · 2023-04-25 18:22:22 +02:00
  66eda40cdf
• Fixed DifficultyPointPiece
  OliBomby · 2023-04-25 18:12:53 +02:00
  065464d90c
• remove unused directives
  OliBomby · 2023-04-25 13:06:37 +02:00
  97910d6be6
• remove ApplyLegacyInfo method
  OliBomby · 2023-04-25 12:52:21 +02:00
  891b87a5ff
• made the SampleControlPoint and DifficultyControlPoint obsolete
  OliBomby · 2023-04-25 11:34:09 +02:00
  a4c6850ab2
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Change IHasRepeats.NodeSamples to IList from List
  goodtrailer · 2021-10-23 01:59:07 -07:00
  4440b9ca11
• Merge branch 'master' into no-more-difficulty-control-points-info
  smoogipoo · 2021-10-08 18:41:17 +09:00
  bc37cb6f43
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Move approach rate to EffectControlPoint
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  a3d9ab1e2e
• Write out DifficultyControlPoints into HitObjects
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  b41b1e2394
• Remove obsoleted IHasCurve
  Bartłomiej Dach · 2021-01-06 18:38:24 +01:00
  539785e422
• Fix non-convert slider and spinner serialization
  Dean Herbert · 2020-09-14 17:32:32 +09:00
  a8b405791a
• Merge branch 'master' into move-setter-to-duration
  Dan Balasescu · 2020-06-01 15:55:48 +09:00
  64d1b4b11b
• Restore original IHasCurve implementation
  smoogipoo · 2020-06-01 15:11:58 +09:00
  cac6e93575
• Move sett from EndTime to Duration
  Dean Herbert · 2020-05-27 12:37:44 +09:00
  b8e0a6f127
• Split out IHasPath from IHasCurve to better define hitobjects
  Dean Herbert · 2020-05-26 17:44:47 +09:00
  6b5b215299
• Fix hitobjects with unknown lifetimes by enforcing non-null judgement

  We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
  due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
  CreateJudgement() must be implemented and return a non-null judgement.
  
  This fixes BananaShower and JuiceStreams in osu!catch.
  
  This also makes HitObject abstract and cleans up convert HitObject implementations.

  Dean Herbert · 2020-02-23 13:49:06 +09:00
  ffc7eaa3f2
• Throw NotSupportedException instead
  Dean Herbert · 2020-02-06 13:16:32 +09:00
  daf5fa9da4
• Make EndTime and RepeatCount settable
  Dean Herbert · 2020-02-05 17:52:51 +09:00
  cd6902a312
• Make hitobject samples a bindable list
  smoogipoo · 2019-11-08 14:04:57 +09:00
  6fc1be64c2
• Fix skinning support for combobreak
  Dean Herbert · 2019-06-30 21:58:30 +09:00
  60ea3d4e1a
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Make Path.Distance a property again
  smoogipoo · 2018-11-12 14:07:48 +09:00
  3aba462e52
• Instantiate a new path rather than setting properties on it

  # Conflicts:
  #	osu.Game.Rulesets.Catch/Beatmaps/CatchBeatmapConverter.cs
  #	osu.Game.Rulesets.Catch/Objects/JuiceStream.cs
  #	osu.Game.Rulesets.Osu/Beatmaps/OsuBeatmapConverter.cs
  #	osu.Game/Rulesets/Objects/Legacy/Catch/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Mania/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Osu/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Taiko/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/SliderPath.cs

  smoogipoo · 2018-11-12 13:50:19 +09:00
  54ab256c8e
• Merge remote-tracking branch 'origin/master' into fix-slider-samples

  # Conflicts:
  #	osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapDecoderTest.cs
  #	osu.Game/Rulesets/Objects/Legacy/Catch/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Mania/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Osu/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Taiko/ConvertHitObjectParser.cs

  smoogipoo · 2018-11-05 16:38:28 +09:00
  a4caaf56ef
• ControlPoint -> PathControlPoint

  Also Curve -> Path.

  Dean Herbert · 2018-11-01 03:56:51 +09:00
  bb2f8deb18
• Fix slider nodes using the wrong samples
  smoogipoo · 2018-10-16 17:10:24 +09:00
  47be95ce0b
• Pass sub-controlpoints as span slices
  smoogipoo · 2018-10-11 17:44:25 +09:00
  83fd251c7b
• Add legacy slider offsets
  smoogipoo · 2018-06-27 12:09:21 +09:00
  80501de4b9
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Clean up off-by-one offsets from repeat-related properties
  smoogipoo · 2018-01-23 13:37:25 +09:00
  d37844c068
• Update licence headers
  Dean Herbert · 2018-01-05 20:21:19 +09:00
  37d393bca0
• Remove SampleInfoList
  smoogipoo · 2017-12-25 15:40:01 +09:00
  d288d8a51f
• Make HitObjects construct nested hit objects
  smoogipoo · 2017-12-22 21:42:54 +09:00
  6a29f6020a
• Make DifficultyControlPoint.SpeedMultiplier actually increase with an increasing speed. Fixes #1147
  smoogipooo · 2017-08-21 11:58:54 +09:00
  6a7b410bc3
• Reshuffle namespaces
  Dean Herbert · 2017-07-26 13:22:46 +09:00
  fce580d717
• Give velocity a sane default value.
  smoogipooo · 2017-05-29 12:19:51 +09:00
  c137ee822c
• We don't need a curve.
  smoogipooo · 2017-05-29 12:19:38 +09:00
  231b1ae610
• Always ApplyDefaults after parsing beatmaps to make sure hit objects are in their most loaded state.
  smoogipooo · 2017-05-29 12:10:29 +09:00
  6101fe98e1
• Introduce SampleInfoList as List<SampleInfo> to reduce generic nesting. Fix CI warnings.
  smoogipooo · 2017-04-26 14:12:21 +09:00
  28f7e0cdba
• Prefix everything inside Rulesets.Objects.Legacy with "Convert" to avoid naming clashes with Ruleset projects.
  smoogipooo · 2017-04-22 21:33:11 +09:00
  2af9bf1423