osu-lazer

Change global shear definition to be a Vector2

Saves having this defined in 20+ places. If we ever make any changes to
shear, it's 100% going to need to be applied to every usage (there will
never be a case of multiple different shears in the game).

Also fixes a mismatching definition in `ShearedNub`.

Dean Herbert · 2025-04-16 18:01:08 +09:00

7a8e96f322

Move SHEAR constant to OsuGame and revert back to 0.2x (i.e. master)

Discussed in [discord](https://discord.com/channels/188630481301012481/188630652340404224/1240490608934653984).

Salman Ahmed · 2024-05-16 07:28:02 +03:00

310b4d90cc

Fix mod select overlay columns not displaying properly sometimes

Closes https://github.com/ppy/osu/issues/26504.

As far as I can tell the issue is basically another manifestation of
https://github.com/ppy/osu-framework/issues/5129, i.e. presence
overrides causing dropped invalidations and thus completely bogus
hierarchy state. The fix is to raise the appropriate invalidation
manually.

Bartłomiej Dach · 2024-04-23 13:36:12 +02:00

f7626aba18

Reduce allocations in ModColumn

Andrei Zavatski · 2024-02-24 22:44:58 +03:00

3b53ed3c3a

Remove obvious comment

Bartłomiej Dach · 2023-06-18 14:04:00 +02:00

4c78144d10

Fix duplicate linq and reword comment

Bartłomiej Dach · 2023-06-18 14:03:26 +02:00

64e96c6d82

Rename ModState members to better convey what's what

Bartłomiej Dach · 2023-06-18 13:58:25 +02:00

62f01e4f40

Merge branch 'master' into add-mod-search-option

Cootz · 2023-06-12 13:09:09 +03:00

aece548db1

Use debounce constant for select/deselect animation

Cootz · 2023-06-10 13:55:37 +03:00

502193e1c6

Mod panel don't play sound when hidden

Cootz · 2023-06-09 16:55:19 +03:00

7697dbe4b3

Rename IsValid to Visible

Cootz · 2023-06-02 11:33:38 +03:00

4c7cca101e

Prevent checkbox from toggle on when column have no valid panels

Cootz · 2023-05-29 14:22:40 +03:00

22c6d6c526

Remove weird update usage when 'deselect all' pressed

Cootz · 2023-05-07 15:34:01 +03:00

60bad35145

Fix testing

Cootz · 2023-05-06 11:09:44 +03:00

a226caff56

Fix wrong filtering in testing

Cootz · 2023-05-05 22:41:30 +03:00

7422b5285c

Fix mod deselect button not working properly when search applied

Cootz · 2023-05-05 09:31:27 +03:00

54757df51f

Manually implement @bdach prototype

Cootz · 2023-05-02 14:15:33 +03:00

a6ca049739

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Use alternative method for checking panel readiness to eliminate bool flag

Bartłomiej Dach · 2022-08-17 21:56:11 +02:00

3d14b14cfe

Fix several schedule-related issues arising from new column addition

Bartłomiej Dach · 2022-08-15 20:38:16 +02:00

f860bc11ee

Simplify mirror copy of task logic in ModColumn

Bartłomiej Dach · 2022-08-08 19:20:50 +02:00

f21a51aa24

Extract base mod select column presentation logic

Bartłomiej Dach · 2022-07-24 16:39:03 +02:00

b2f8934117

Rename ModSelect{Overlay -> }Panel

Bartłomiej Dach · 2022-07-22 19:17:22 +02:00

f3ceabc53f

Fix code inspections after base panel class extraction

Bartłomiej Dach · 2022-07-21 23:29:08 +02:00

6cd18fad99

Remove unnecessary null casts

Dean Herbert · 2022-06-24 14:50:11 +09:00

f71f6302fd

Remove unnecessary protected virtual

Bartłomiej Dach · 2022-06-21 16:43:04 +02:00

7013909322

Restructure everything to fix free mod overlay issue

Bartłomiej Dach · 2022-06-21 14:48:41 +02:00

da1814e7c3

Forward entire event to IModHotkeyHandler

Required for shift handling in the classic implementation.

Bartłomiej Dach · 2022-06-21 13:37:17 +02:00

234120ff43

Set up flow for switching between hotkey styles

Bartłomiej Dach · 2022-06-21 13:34:58 +02:00

658f5341c7

Encapsulate mod hotkey selection logic in strategy pattern

Bartłomiej Dach · 2022-06-21 12:49:01 +02:00

73124d2b1f

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Fix incorrect left/right clicking area of mod panels

Joseph Madamba · 2022-05-23 18:29:26 -07:00

ed0b841df0

Remove no-longer-necessary ModColumn.Filter

Bartłomiej Dach · 2022-05-11 22:31:26 +02:00

2266a5c9a0

Fix remaining column operations being coupled to drawables

Bartłomiej Dach · 2022-05-11 22:31:26 +02:00

1c0166367d

Fix select/deselect all toggle not working correctly after changes

Bartłomiej Dach · 2022-05-11 22:31:26 +02:00

b5a9f1310a

Fix not being able to set AvailableMods before loaded

Bartłomiej Dach · 2022-05-11 22:31:26 +02:00

52bbce12f1

Hoist reference replacement logic to overlay level

Bartłomiej Dach · 2022-05-11 22:26:47 +02:00

11ae1da65a

Hoist ModState to overlay level

Bartłomiej Dach · 2022-05-11 22:26:21 +02:00

05a21fbbe0

Hoist ModState to column level

Bartłomiej Dach · 2022-05-11 22:03:49 +02:00

e86444c4bf

Rename ModSelect{Screen -> Overlay} in place of removed old design

Bartłomiej Dach · 2022-05-10 22:56:50 +02:00

76c63f1d0a

Move alpha management closer to screen level

Felt bad messing with alpha at the column level.

Bartłomiej Dach · 2022-05-08 15:40:10 +02:00

6bdcf893b7

Hide mod columns if all mods within are filtered out

Bartłomiej Dach · 2022-05-08 14:53:59 +02:00

92ccec20d7

Add xmldoc for IsValidMod

Dean Herbert · 2022-05-08 01:49:29 +09:00

1d27ef18dc

Fix invalid IsLoaded check

Would fail when `availableMods` would be changed from a different thread
while the columns aren't loaded.

Bartłomiej Dach · 2022-05-07 15:44:22 +02:00

0c2b4a6c0b

Merge branch 'master' into change-mod-scroll-behaviour

Bartłomiej Dach · 2022-05-07 13:29:02 +02:00

fe69bd7ed9

Change mod scrolling behaviour to not scroll horizontally on columns/settings

Salman Ahmed · 2022-05-07 12:15:11 +03:00

8ee3fdd0aa

Reuse "select/deselect all" localisable string on column toggle

Bartłomiej Dach · 2022-05-07 10:56:03 +02:00

f761d4d4d4

Update mod columns even if they're not present/offscreen

Important to make "select/deselect all" operations work on all columns
simultaneously, even if they're offscreen. Unfortunately by the nature
of how the existing selection animation works, it is hard-tied to the
update loop, so we need to compensate.

Bartłomiej Dach · 2022-05-07 09:50:09 +02:00

18e4c3ed0f

Only load panels asynchronously outside of BDL

Bartłomiej Dach · 2022-05-07 09:50:09 +02:00

9514a5cef7

Remove schedule in panel load

It was causing selection/deselection of all mods to work improperly if a
select/deselect all operation was requested before the panel was
scrolled into view.

In general the schedule was an over-optimisation - the game-global set
of available mods shouldn't be changing so often as to warrant such an
aggressive debounce.

Bartłomiej Dach · 2022-05-07 09:50:09 +02:00

9f96dd47d1

81 Commits