933 Commits

• Limit maximum width of tooltips
  Dean Herbert · 2025-08-04 18:18:31 +09:00
  85aadedb2f
• Adjust appearance slightly to match leaderboard score tooltip
  Bartłomiej Dach · 2025-08-01 11:27:37 +02:00
  0d4a4f7414
• Show effect of beatmap attributes on gameplay metrics in osu!
  Bartłomiej Dach · 2025-08-01 11:07:48 +02:00
  655733c06d
• Allow showing additional metrics when hovering over beatmap attributes
  Bartłomiej Dach · 2025-08-01 11:06:40 +02:00
  c68cbc5360
• Move "attribute adjusted" tooltips to individual attribute displays

  Pre-requisite for displaying additional information regarding the impact
  of particular attributes on various beatmap metrics.

  Bartłomiej Dach · 2025-08-01 11:05:54 +02:00
  cb73717a34
• Rename property to reduce confusion

  Caused an actual bug in one of the replaced usages.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  cd2c5075df
• Migrate other usages of GetAdjustedDisplayDifficulty() to use GetBeatmapAttributesForDisplay() instead

  This ensures parity between all beatmap attribute displays that used the
  former method.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  a952e3704e
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Unify order of displaying map attributes on mod overlay with SongSelectV2
  Bartłomiej Dach · 2025-05-29 11:28:11 +02:00
  b20139e9dd
• Make BeatmapDifficultyCache's returned bindable non-nullable
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  6500be3f2d
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Update AdjustedAttributesTooltip.cs

  Mods don't necessarily have to change speed, to change beatmap attributes. Also, speed mods don't affect beatmap attributes in mania, making the text misleading.

  Marvefect · 2025-04-30 13:01:23 +03:00
  3f17d7227a
• Merge pull request #32847 from frenzibyte/song-select-v2-sheared-components-changes

  Fixes and improvements to existing sheared components

  Dean Herbert · 2025-04-30 14:25:28 +09:00
  c268dfd99a
• Fix sheared button alignment in preset popovers
  Salman Alshamrani · 2025-04-29 05:34:10 +03:00
  72987aa166
• Make mod preset shear buttons take up full width
  Dean Herbert · 2025-04-22 17:30:03 +09:00
  5e06b3d1b4
• Remove padding from ShearedButton for better sheared flow alignment
  Salman Alshamrani · 2025-04-18 07:23:39 -04:00
  62b96466c4
• Add beatmap title wedge
  Salman Alshamrani · 2025-04-18 06:41:51 -04:00
  04fa95d924
• Change global shear definition to be a Vector2

  Saves having this defined in 20+ places. If we ever make any changes to
  shear, it's 100% going to need to be applied to every usage (there will
  never be a case of multiple different shears in the game).
  
  Also fixes a mismatching definition in `ShearedNub`.

  Dean Herbert · 2025-04-16 18:01:08 +09:00
  7a8e96f322
• Refresh mod panel active states when recreated
  Dan Balasescu · 2025-03-27 19:05:26 +09:00
  dcb5389ab7
• Remove pointless left-over code
  Dean Herbert · 2025-03-25 16:43:22 +09:00
  1bb85bab89
• Add extra margin below description text
  Salman Alshamrani · 2025-03-23 13:46:19 -04:00
  54eb0b33b0
• Update mod preset tooltip design accordingly
  Salman Alshamrani · 2025-03-23 13:43:38 -04:00
  623e705704
• Add some lenience around mod customisation expanding overlay

  It was quite easy to dismiss by accident. I've added some positional and
  time based lenience with numbers that feel good to me. Open to
  discussion on whether both are required and if the numbers feel good.
  
  Going forward, at some point, we'll likely want to standardise this
  across to other expand-on-hover elements (like player load overlays).
  
  Addresses https://github.com/ppy/osu/discussions/32368.

  Dean Herbert · 2025-03-19 12:46:41 +09:00
  52dad654f7
• Highlight diff attribute changes in mod select
  Zihad · 2025-03-13 17:50:14 +06:00
  17b17f4d71
• Change ModSelectOverlay.ShowPresets to init
  Dean Herbert · 2025-03-04 22:32:13 +09:00
  dff354247e
• Update game ScrollContainer usage in line with framework changes

  See https://github.com/ppy/osu-framework/pull/6467.

  Dean Herbert · 2025-01-11 01:42:59 +09:00
  94ea003d90
• Adjust glow slightly
  Dean Herbert · 2024-10-22 17:16:09 +09:00
  13fba9f92e
• Add preselection indicator for better visibility what will be selected
  Bartłomiej Dach · 2024-10-18 13:23:37 +02:00
  05e2f6db8e
• Refactor a bit
  Dan Balasescu · 2024-10-18 18:40:25 +09:00
  083644b713
• Also handle full mod name (likely irrelevant but might as well)
  jhk2601 · 2024-10-17 17:11:01 -04:00
  9a0356919c
• Adds logic to prioritize selecting exact mod acronyms when they are searched
  jhk2601 · 2024-10-17 17:04:13 -04:00
  2ef8720590
• Fix delete dialogs having generic "Caution" header text

  Regressed in https://github.com/ppy/osu/pull/28363.

  Dean Herbert · 2024-10-07 16:46:53 +09:00
  11fc811e2f
• Reduce brightness of hover effect
  Dean Herbert · 2024-09-27 18:20:16 +09:00
  e7c4451206
• Changed ModCustomisationHeader to inherit from OsuClickableContainer.

  ModCustomisationHeader changes color depending on state.

  Fabep · 2024-09-04 15:29:48 +02:00
  17760afa60
• Revert "Woopsie! I accidentally added one too many semi-colons, so I moved it here into the commit instead ;"

  This reverts commit 582ffcfc97.
  
  Revert "Mod customisation header's color is now based on the state of the panel rather than the hover of the container."
  
  This reverts commit e3457d8501.

  Dean Herbert · 2024-09-04 17:25:41 +09:00
  86309f4b46
• Woopsie! I accidentally added one too many semi-colons, so I moved it here into the commit instead ;
  Fabep · 2024-09-02 19:17:07 +02:00
  582ffcfc97
• Mod customisation header's color is now based on the state of the panel rather than the hover of the container.
  Fabep · 2024-09-02 19:14:08 +02:00
  e3457d8501
• Fix mod customisation header being non-functional on mobile

  As expected the previous touch handling would prevent the header from
  working entirely when click handling was removed from the header.

  Bartłomiej Dach · 2024-09-02 11:33:43 +02:00
  5211e606b5
• Changed ModCustomisationPanelState names
  Fabep · 2024-08-28 10:09:47 +02:00
  6adaf6a41f
• Removed on click event for expanding the Mod Customisation Header.
  Fabep · 2024-08-28 09:51:17 +02:00
  be0e2efda2
• Merge if branches
  Salman Ahmed · 2024-08-22 05:40:43 +09:00
  1efa6b7221
• Alter NRT usage
  Salman Ahmed · 2024-08-22 05:39:57 +09:00
  fc02b4b942
• Keep mod customisation panel open when dragging a drawable
  Salman Ahmed · 2024-08-21 03:23:23 +09:00
  b7599dd1f8
• Get rid of weird method
  Bartłomiej Dach · 2024-08-07 14:07:20 +02:00
  f83d43c38b
• Remove weird Expanded / ExpandedState duality
  Bartłomiej Dach · 2024-08-07 14:01:30 +02:00
  518c1aa5a0
• Merge branch 'master' into hover-open-mod-customise
  Dean Herbert · 2024-08-06 18:35:35 +09:00
  9ccd8c906d
• Fix customise button on mod overlay initially showing flash layer indefinitely
  Joseph Madamba · 2024-08-02 10:19:59 -07:00
  4ef9f335ee
• Merge branch 'master' into hover-open-mod-customise
  Caiyi Shyu · 2024-08-02 19:07:27 +08:00
  c85dc40f91
• Fix mod panels overflowing into the column borders
  Dan Balasescu · 2024-08-02 18:59:21 +09:00
  64b7bab4fb