45 Commits

• Move key binding string retrieval to RealmKeyBindingStore
  Dean Herbert · 2025-04-09 15:23:55 +09:00
  9e90f80ab5
• Fix bindings being cleared if multiple bindings for same action have the same combination

  This actually seems to be the case in catch (dash is bound to shift
  twice). This is annoying but harmless, so let's work around it for now
  to avoid ruining users' configs.

  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  828cedea33
• Add migration to remove duplicate bindings
  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  9c6166ec3d
• Prevent ruleset input managers from reading duplicate bindings
  Bartłomiej Dach · 2023-10-16 21:02:24 +02:00
  639c96e60c
• Implement method to deduplicate keybindings
  Bartłomiej Dach · 2023-10-16 20:51:57 +02:00
  90c44cee54
• Add stub of method to deduplicate bindings (and failing test)
  Bartłomiej Dach · 2023-10-16 20:48:52 +02:00
  79273b88f6
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update remaining cases of clashing variable name in realm.Run(realm..
  Dean Herbert · 2022-01-25 13:04:05 +09:00
  e23b10e6a5
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Update all usages of CreateContext to use either Run or Write
  Dean Herbert · 2022-01-21 17:27:08 +09:00
  114c9e8c1f
• Avoid constructor overhead for realm RealmKeyBinding parameterless constructor
  Dean Herbert · 2022-01-20 17:29:07 +09:00
  70cc03fe43
• Refactor KeyBindingStore to clean up any excess bindings for individual actions

  While this isn't strictly required (outside of rulesets, potentially),
  I think it's best that we keep these counts in a sane state.
  
  Right now, it will remove any excess. Arguably, in the case an entry is
  found with too many, we should wipe all entries and re-populate the
  defaults. Interested in opinions on that before merging. See
  https://github.com/ppy/osu/discussions/15925 for an example where wiping
  may be the more appropriate behaviour.

  Dean Herbert · 2021-12-13 15:26:51 +09:00
  7318ff3f98
• Switch realm ruleset key bindings to use ruleset's ShortName as key
  Dean Herbert · 2021-11-22 18:52:30 +09:00
  d94b27a8a2
• Shorten variable names
  Dean Herbert · 2021-11-08 18:24:37 +09:00
  f5842e7587
• Change to use ReadableKeyCombinationProvider

  Changes all usages of `KeyCombination.ReadableString()` to
  `ReadableKeyCombinationProvider.GetReadableString()`.
  
  Subscribing to `KeymapChanged` is only required in `KeyButton`.
  All other places query `GetReadableString()` every time.

  Susko3 · 2021-11-08 06:55:26 +01:00
  c3069ad002
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Refine RealmContext implementation API
  Dean Herbert · 2021-09-30 23:56:38 +09:00
  9fa901f6aa
• Reduce startup overhead during default key binding handling
  Dean Herbert · 2021-09-07 15:19:23 +09:00
  5b13b566b5
• Add missing rulesetID check for global action matching
  Dean Herbert · 2021-06-18 17:12:01 +09:00
  d5a1524eb0
• Fix thread safety of KeyBindingStore.GetReadableKeyCombinationsFor
  Dean Herbert · 2021-06-18 17:11:39 +09:00
  d06e52505a
• Merge branch 'master' into realm-key-binding-store
  Dean Herbert · 2021-05-25 17:18:33 +09:00
  a249bb9e69
• Remove unused using statement
  Dean Herbert · 2021-04-26 17:45:43 +09:00
  253c66034d
• Move guid initialisation to database model itself
  Dean Herbert · 2021-04-26 17:06:03 +09:00
  8961203f08
• Use realm support for Guid
  Dean Herbert · 2021-01-19 18:22:36 +09:00
  68f2e7f61a
• Remove unnecessary Take() call and refactor default group logic naming
  Dean Herbert · 2021-01-14 16:36:24 +09:00
  f26c6210f3
• Fix transactions not actually being committed
  Dean Herbert · 2021-01-14 16:13:10 +09:00
  8a08d3f4ef
• Remove unused RealmBackedStore base class
  Dean Herbert · 2021-01-13 18:36:37 +09:00
  5fa3a22f28
• Rename realm persisted properties to avoid casting necessity
  Dean Herbert · 2021-01-13 18:36:37 +09:00
  fcb4a53f37
• Update write usages
  Dean Herbert · 2021-01-13 18:36:37 +09:00
  9086d75542
• Update existing usages to use the main realm context where applicable
  Dean Herbert · 2021-01-13 18:36:37 +09:00
  9d744d629f
• Remove unused event
  Dean Herbert · 2021-01-13 18:36:37 +09:00
  78707c3b06
• Update all read queries to use direct realm subscriptions/queries
  Dean Herbert · 2021-01-13 18:36:37 +09:00
  192e58e0c6
• Move ruleset key binding registration to an explicit method rather than the constructor
  Dean Herbert · 2021-01-12 15:21:02 +09:00
  a6997a6fc6
• Mark classes nullable
  Dean Herbert · 2021-01-12 15:21:02 +09:00
  ff16d2f490
• Remove unused EF class and unnecessary interface
  Dean Herbert · 2021-01-12 14:45:36 +09:00
  536e7229d0
• Make key binding update method support all kinds of realm object states
  Dean Herbert · 2021-01-12 14:45:36 +09:00
  406e640fa9
• Add full xmldoc to RealmKeyBindingStore
  Dean Herbert · 2021-01-11 16:31:36 +09:00
  6fd098ca7c
• Move public members up
  Dean Herbert · 2021-01-11 16:31:36 +09:00
  56d34432f9
• Remove unnecesssary local conversion method
  Dean Herbert · 2021-01-11 16:31:36 +09:00
  a1cb6d8c54
• Use IKeyBinding for all key binding usages (and add update flow via primary key)
  Dean Herbert · 2021-01-11 16:31:35 +09:00
  8765aaf9e6
• Store KeyBinding action to its own field in realm

  Also improve the Query method for action types by using generic field

  Dean Herbert · 2021-01-11 15:52:49 +09:00
  a77519c6bd
• Add and consume IKeyBindingStore interface
  Dean Herbert · 2021-01-11 15:52:49 +09:00
  43f417b53a
• Add missing implementation details to realm keybinding store
  Dean Herbert · 2021-01-11 15:52:49 +09:00
  391259c713
• Initialise new key bindings with a primary key
  Dean Herbert · 2021-01-11 15:52:49 +09:00
  ee6a26bd6e
• Add realm store / key binding implementations
  Dean Herbert · 2021-01-11 15:52:49 +09:00
  d5ac97ece8