48 Commits

• Fix external edit filename sanitising unintentionally dropping folder separators (#34945)

  * Add failing test coverage showing external edits not working with folders
  
  * Fix external edit filename sanitising unintentionally dropping folder separators
  
  Closes https://github.com/ppy/osu/issues/34929.

  Dean Herbert · 2025-09-07 21:47:20 +09:00
  645518f5bd
• Fix external edit operations failing due to invalid filenames
  Bartłomiej Dach · 2025-09-03 09:26:06 +02:00
  51e7593446
• Fix timeout during diffcalc causing batch import to bail

  Closes https://github.com/ppy/osu/discussions/32628.

  Dean Herbert · 2025-04-03 14:30:47 +09:00
  21c6756336
• Ensure cleanup tasks are run even on a cancelled / exceptioned import task
  Dean Herbert · 2024-11-18 16:51:46 +09:00
  ebc2cc3570
• Re-throw OperationCanceledException for consistency?

  Mostly to see if it breaks anything.

  Dean Herbert · 2024-11-14 13:14:35 +09:00
  2afd357901
• Merge branch 'master' into import-paused-visibility
  Dean Herbert · 2024-11-12 17:02:21 +09:00
  ce86208e09
• Prefer not deleted models when picking model instances for reuse when importing

  This fell out while investigating why the issue with online IDs
  mismatching in the `.osu` could be worked around by importing the map
  three times in total when starting from it not being available locally.
  
  Here follows an explanation of why that "helped".
  
  Import 1:
  - The beatmap set is imported normally.
  - Online metadata population sees the online ID mismatch and resets it
    on the problematic beatmap.
  
  Import 2:
  - The existing beatmap set is found, but deemed not reusable
    because of the single beatmap having its ID reset to -1.
  - The existing beatmap set is marked deleted, and all the IDs of
    its beatmaps are reset to -1.
  - The beatmap set is reimported afresh.
  - Online metadata population still sees the online ID mismatch
    and resets it on the problematic beatmap.
  
  Note that at this point the first import *is still physically present
  in the database* but marked deleted.
  
  Import 3:
  - When trying to find the existing beatmap set to see if it can be
    reused, *the one pending deletion and with its IDs reset -
    - the remnant from import 1 - is returned*.
  - Because of this, `validateOnlineIds()` resets online IDs
    *on the model representing the current reimport*.
  - The beatmap set is reimported yet again.
  - With the online ID reset, the online metadata population check for
    online ID mismatch does not run because *the IDs were reset to -1*
    earlier.
  
  Preferring undeleted models when picking the model instance for reuse
  prevents this scenario.

  Bartłomiej Dach · 2024-10-30 08:18:44 +01:00
  0e52797f29
• Make flow more async to avoid any chance of deadlocks
  Dean Herbert · 2024-10-24 17:56:51 +09:00
  61f0cfd688
• Update notification text when import is paused due to gameplay

  Addresses https://github.com/ppy/osu/discussions/30388.

  Dean Herbert · 2024-10-23 17:51:29 +09:00
  be5cb209e5
• Add note about using hard links in the future
  Dean Herbert · 2024-09-06 16:01:47 +09:00
  36a30cf077
• Add basic flow for mounting beatmaps for external editing
  Dean Herbert · 2024-07-10 18:29:51 +09:00
  d3c66e2404
• Remove unused method
  Dean Herbert · 2024-04-29 18:48:07 +08:00
  a3d239c11a
• Use new LINQ Order() instead of OrderBy() when possible
  Berkan Diler · 2024-02-08 18:01:00 +01:00
  6adf0ac01e
• Fix skin editor freezing game if opened during active gameplay
  Bartłomiej Dach · 2023-10-27 14:34:30 +02:00
  5ad962070c
• Merge branch 'master' into fix-batch-import-score-missing-notifications
  Bartłomiej Dach · 2023-09-27 17:06:47 +02:00
  0769d0f49f
• Don't show replay import "missing beatmap" notifications during stable import

  Closes https://github.com/ppy/osu/issues/24926.

  Dean Herbert · 2023-09-27 17:04:43 +09:00
  2481c0b64b
• Improve notification display when score import fails
  Dean Herbert · 2023-09-26 15:00:56 +09:00
  d1d82d2b49
• Delegate file deletion to ImportTask to allow overriding it
  Susko3 · 2023-01-22 22:19:04 +01:00
  f8537c1cbe
• Adjust english slightly
  Dean Herbert · 2023-01-10 22:27:36 +09:00
  a22b7298c6
• Display number of failing models during batch-import
  Salman Ahmed · 2023-01-10 13:32:10 +03:00
  0d6b9ebc0f
• Check cancellation token if importer was resumed while sleeping
  Salman Ahmed · 2023-01-09 20:07:46 +03:00
  8a05223591
• Specifiy importer name during pause/resume in logs
  Salman Ahmed · 2023-01-09 19:53:41 +03:00
  a1fbfe4b8b
• Don't use bindables to avoid potential cross-usage contamination
  Dean Herbert · 2023-01-10 01:10:20 +09:00
  811a562608
• Pause imports during active gameplay
  Dean Herbert · 2023-01-09 18:54:11 +09:00
  62ffb4fe78
• Move ImportParameters to better home
  Dean Herbert · 2022-12-13 21:41:26 +09:00
  b8904fe747
• Hook up ImportParameter flow with IModelImporter caller methods
  Dean Herbert · 2022-12-13 21:29:32 +09:00
  cb16d62700
• Hook up parameter with RealmFileStore to complete the chain
  Dean Herbert · 2022-12-13 19:55:18 +09:00
  1d4230993d
• Convert batchImport parameter to parameters class to allow further import configuration
  Dean Herbert · 2022-12-13 19:55:18 +09:00
  cf2719d4c0
• Reduce the scope of realm transactions during import operations
  Dean Herbert · 2022-10-11 21:58:28 +09:00
  390ff8b9da
• Improve performance when cancelling import with debugger attached
  Dan Balasescu · 2022-09-05 11:28:13 +09:00
  8cbd344330
• Add flow for bypassing local cache lookups when refreshing beatmap metadata
  Dean Herbert · 2022-07-28 16:33:51 +09:00
  c35da62224
• Add ImportAsUpdate method to IModelImporter to avoid otehr changes
  Dean Herbert · 2022-07-26 15:49:04 +09:00
  8370ca9765
• Ensure initial beatmap processing is done inside the import transaction
  Dean Herbert · 2022-07-11 02:51:54 +09:00
  8b6665cb5b
• Merge pull request #19029 from peppy/fix-skin-import-duplicate

  Fix skins potentially being duplicated on batch import

  Dan Balasescu · 2022-07-08 14:18:14 +09:00
  0bc332e90b
• Fix editor saving not updating BeatmapSetInfo's hash
  Dean Herbert · 2022-07-08 02:33:14 +09:00
  c53dd4a703
• Fix skins potentially being duplicated on batch import

  Resolves https://github.com/ppy/osu/discussions/19024#discussioncomment-3099200

  Dean Herbert · 2022-07-07 22:39:07 +09:00
  cf1da1dd18
• Include archive name in import log output
  Dean Herbert · 2022-06-27 15:24:25 +09:00
  da61d0547f
• Replace usages of string.To{Lower,Upper}()
  Bartłomiej Dach · 2022-06-24 11:57:45 +02:00
  26c5b59f6d
• Add PostImport method matching PreImport
  Dean Herbert · 2022-06-20 18:40:23 +09:00
  e732c5a2d7
• Remove default value of RealmArchiveModelImporter.HandledExtensions

  Not used anywhere and probably not wanted ever.

  Dean Herbert · 2022-06-20 18:40:23 +09:00
  45c5013f09
• PostImport -> PresentImport
  Dean Herbert · 2022-06-20 18:36:29 +09:00
  dbae4c6f5a
• Move nested task back outside try-catch to avoid double-error
  Dean Herbert · 2022-06-20 15:36:44 +09:00
  882e1c69e5
• Update xmldoc for importFromArchive method
  Dean Herbert · 2022-06-20 15:25:43 +09:00
  dd93c7359e
• Rename Import(TModel) to ImportModel to differentiate from other import methods
  Dean Herbert · 2022-06-20 15:18:07 +09:00
  92f1a2958c
• Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask)
  Dean Herbert · 2022-06-20 15:14:57 +09:00
  a6c8a832aa
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Combine BeatmapManager and BeatmapModelManager into one class
  Dean Herbert · 2022-06-16 18:07:04 +09:00
  1f3e1b2d97
• Move remaining realm classes out of Stores namespace
  Dean Herbert · 2022-06-15 21:56:00 +09:00
  f23ddfe6cc