osu-lazer

Fix comment

Co-authored-by: Dean Herbert <pe@ppy.sh>

Bartłomiej Dach · 2025-07-22 09:44:35 +02:00

5e0219c58f

Merge branch 'master' into store-pause-count

Bartłomiej Dach · 2025-07-22 08:44:16 +02:00

b08ba3c9e4

Add initial support for filtering by user tags in song select

The way that this works is that it plugs into the online request to
retrieve the beatmap set that the client is already performing, and
stores user tag data to the local realm database.

This means that for now user tags will only populate for beatmaps that
the user has displayed on song select which is obviously subpar. I plan
to follow this change up by adding user tag state dumps to `online.db`
and using that data for initial tag population to make the majority case
(ranked beatmaps) work.

Note that several decisions were made here that are potential discussion
points:

- `RealmPopulatingOnlineLookupSource` is set up such that it can be the
  middle man / redirection point for similar flows that we need and we
  are currently missing, such as storing guest difficulty information,
  or storing the user's current best score on a beatmap (handy for rank
  achieved sorting / filtering / etc.)

- The user tags are stored in `BeatmapMetadata` which breaks the
  longstanding assumption that you can arbitrarily pull out a metadata
  instance from any of the beatmaps in a set and get essentially the
  same object back.

  I've attempted to constrain this some by not adding user tags to
  the `IBeatmapMetadataInfo` interface through which `BeatmapSetInfo`
  exposes metadata further, but I warn in advance that this is
  a temporary state of affairs and I will make it worse in the future
  when `BeatmapMetadata.Author` becomes `Authors` plural in order to
  support guest mapper display (and direct guest difficulty submission).

- The syntax for searching via user tags is chosen to mostly match web -
  it's `tag=`, with support for all of the string matching modes song
  select already has (bare word for substring, `""` quotes for phrase
  isolated by whitespace, `""!` for exact full match).

Bartłomiej Dach · 2025-07-15 11:09:40 +02:00

8cb81974eb

Store score pause count to realm database

Bartłomiej Dach · 2025-07-07 11:00:31 +02:00

c83dcdc915

Fix dodgy threading

The fact that the stuff "just worked" previously due to one load-bearing
detach in a random location is really scary because a lot of this was
just not written the way it is supposed to be.

Bartłomiej Dach · 2025-06-30 14:17:27 +02:00

2e0e7ff3c2

Fix stable scores importing with a LegacyOnlineID of 0

Closes https://github.com/ppy/osu/issues/33435.

The root cause of the issue is that the user's database contained a
whole lot of scores with `LegacyOnlineID` of 0, which would trip up

	https://github.com/ppy/osu/blob/97e6187f0d7c3dbee896596a623e34627135bf0e/osu.Game/Extensions/ModelExtensions.cs#L128-L129

as that method would thus consider scores that are not the same as the
same because of the zero, which later trips up

	https://github.com/ppy/osu/blob/97e6187f0d7c3dbee896596a623e34627135bf0e/osu.Game/Screens/Ranking/SoloResultsScreen.cs#L79

which ends up inserting `Score` into the list several times, which
causes the crash.

You might remember that I tried to fix this once before in
https://github.com/ppy/osu/pull/24794. What I did not realise, however,
is that stable *can still produce replays* that have an online ID of
zero in them, because zero *is just `default(long)`*:

	https://github.com/peppy/osu-stable-reference/blob/7205341bb70000a87fa1bd54e7642772e2af85d7/osu!/GameplayElements/Scoring/Score.cs#L123
	https://github.com/peppy/osu-stable-reference/blob/7205341bb70000a87fa1bd54e7642772e2af85d7/osu!/GameplayElements/Scoring/Score.cs#L350

The alternative way of fixing this would be just to change
`MatchesOnlineID` to reject zeroes, but I think this is a saner overall
direction.

Bartłomiej Dach · 2025-06-10 11:54:11 +02:00

d4fc6693b4

Re-fetch status of any beatmaps stuck in qualified status

Best we do this rather than leaving it up to users to fix their broken
beatmaps.

https://github.com/ppy/osu/discussions/32406
https://github.com/ppy/osu/discussions/32431

Dean Herbert · 2025-03-19 14:35:43 +09:00

76f286a01b

Ensure realm database file is touched on startup

Closes https://github.com/ppy/osu/discussions/32304.

Dean Herbert · 2025-03-11 15:47:51 +09:00

75bd101c9e

Merge pull request #31509 from bdach/local-metadata-cache-corruption

Refetch local metadata cache if corruption is detected

Dean Herbert · 2025-01-23 02:43:14 +09:00

bf23c67603

Remove outdated ef related catch-when usage

Dean Herbert · 2025-01-22 17:04:30 +09:00

26ef23c9a9

Remove right click default for absolute scroll

Dean Herbert · 2025-01-21 17:24:41 +09:00

66be9f2d1b

Add migration

Dean Herbert · 2024-12-26 15:46:12 +09:00

2a374c0695

Add explanatory comment for schema version bump

Bartłomiej Dach · 2024-12-24 08:21:27 +01:00

d9be172647

Add migration to update users which have previous default bindings for beat snap

Dean Herbert · 2024-12-23 22:14:03 +09:00

9ff4a58fa3

Fix incorrect comment

Bartłomiej Dach · 2024-11-22 11:06:36 +01:00

ead7e99c59

Merge branch 'master' into beatmap-info-purge

Dean Herbert · 2024-11-22 18:47:32 +09:00

086a34f5c0

Don't delete scores when deleting beatmaps

The score model's spec allows for null `BeatmapInfo` so the reasoning of
the inline comment is no longer valid. We match based on hash these
days.

Dean Herbert · 2024-10-22 01:39:05 +09:00

cbaee98674

Fix migration not checking combination properly

Bartłomiej Dach · 2024-10-16 08:17:22 +02:00

f8a13b0beb

migrate clearance of conflicting ToggleFPSDisplay keybind

Leander Furumo · 2024-10-14 16:03:29 +02:00

035e5a9613

Rename and xmldoc RealmResetEmptySet

Dean Herbert · 2024-10-09 14:18:34 +09:00

d836dba982

Merge branch 'master' into beatmap-info-purge

Dean Herbert · 2024-09-15 04:53:35 +09:00

58fe502af4

Apply CodeFactor lint

clayton · 2024-08-07 15:02:53 -07:00

8e63c17536

Add realm migration to remap key bindings

clayton · 2024-08-07 14:36:04 -07:00

93e193d719

Merge branch 'master' into beatmap-info-purge

Dean Herbert · 2024-07-23 12:09:32 +09:00

d707e29ff7

Update HasFlag usages

Dean Herbert · 2024-07-03 00:19:04 +09:00

5350945340

Bump schema version

Bartłomiej Dach · 2024-06-13 09:30:08 +02:00

c67e2dc301

Fix total score without mods migration failing on custom ruleset scores when custom ruleset cannot be loaded

Closes https://github.com/ppy/osu/issues/28209.

Yes this means that such scores will have a zero total score without
mods in DB and thus might up getting their total recalculated to zero
when we try a mod multiplier rebalance (unless we skip scores with zero
completely I suppose). I also don't really care about that right now.

Bartłomiej Dach · 2024-05-19 09:43:33 +02:00

be642c8c42

Merge branch 'master' into pre-mod-multiplier-score

Bartłomiej Dach · 2024-05-08 13:39:44 +02:00

c9414da5d4

Move realm error handling to avoid triggering in test scenarios

Dean Herbert · 2024-04-30 14:09:29 +08:00

0bfad74907

Move exists check inside retry operation

Might help?

Dean Herbert · 2024-04-30 12:39:18 +08:00

a8416f3572

Add retry attempts to hopefully fix windows tests runs

Dean Herbert · 2024-04-29 14:17:48 +08:00

1c1ee22aa7

Use helper method for backup retry attempts

Dean Herbert · 2024-04-29 10:35:37 +08:00

a4bc5a8fc9

Check realm file can be written to before attempting further initialisation

Rather than creating a "corrupt" realm file in such cases, the game will
now refuse to start. This behaviour is usually what we want. In most
cases a second click on the game will start it successfully (the
previous instance's file handles are still doing stuff, or windows
defender is being silly).

Closes https://github.com/ppy/osu/issues/28018.

Dean Herbert · 2024-04-28 19:07:39 +08:00

b262497083

Export and import TotalScoreWithoutMods to replays (or recalculate if it missing)

Bartłomiej Dach · 2024-04-17 09:08:15 +02:00

2f1a4cdaa4

Add backmigration of TotalScoreWithoutMods for existing scores

Bartłomiej Dach · 2024-04-17 08:52:27 +02:00

6b0d577f0b

Add ScoreInfo.TotalScoreWithoutMods

Bartłomiej Dach · 2024-04-17 08:51:53 +02:00

a386068ed3

Use ObjectDisposedException.ThrowIf throw helper