553 Commits

• Make ruleset id non-nullable
  Dean Herbert · 2021-09-15 17:12:04 +09:00
  dcfe9c67e3
• Rename all databased setting classes to be specific to rulesets for now
  Dean Herbert · 2021-09-15 17:12:04 +09:00
  80ecf81be3
• Bring back SettingsStore to avoid changing ruleset API for now

  Also fixes some remaining test failures due to locally constructed
  rulesets that are not being tracked by the game.

  Dean Herbert · 2021-09-15 17:12:02 +09:00
  520e550764
• Remove unused SettingsStore
  Dean Herbert · 2021-09-15 16:31:13 +09:00
  ac377a2e3c
• Make settings works with current caching structure

  Will likely pull out that `RulesetConfigCache` next, but this is an
  "everything works" state.

  Dean Herbert · 2021-09-15 16:31:13 +09:00
  a2f1752344
• Begin migrating settings implementation across to realm
  Dean Herbert · 2021-09-15 16:22:14 +09:00
  187c557ea8
• Fix cache not actually caching anything
  Dean Herbert · 2021-09-09 14:56:39 +09:00
  41a2e6eeeb
• Use a more traditional method of caching
  Dean Herbert · 2021-09-08 23:18:17 +09:00
  a622a0b660
• Cache reflection portion of SettingSource lookups

  Fixes the mod-related overhead portion of https://github.com/ppy/osu/issues/14638. There's still a significant performance issue that will be addressed separately.

  Dean Herbert · 2021-09-08 13:26:11 +09:00
  81c9d831f4
• Add a note against OsuSetting
  Dean Herbert · 2021-08-16 16:59:59 +09:00
  71fab416d8
• Revert "Rename element in OsuSettings enum"

  This reverts commit c2bbe17562.

  Dean Herbert · 2021-08-16 16:56:48 +09:00
  fc89f2bac4
• Rename element in OsuSettings enum

  `ShowProgressGraph` -> `ShowDifficultyGraph`

  kj415j45 · 2021-08-14 22:35:15 +08:00
  c2bbe17562
• Update usages of IHasTooltip in line with framework localisation changes
  Bartłomiej Dach · 2021-06-25 19:10:04 +02:00
  50c27d2635
• Override CreateMenu instead of using a property
  aitani9 · 2021-06-24 14:32:43 -07:00
  93edb25ace
• Add inline comment explaining why the height is set lower
  Dean Herbert · 2021-06-23 14:07:37 +09:00
  bae42a8908
• Decrease the max height of dropdown menus in mod settings
  aitani9 · 2021-06-22 13:32:45 -07:00
  59928a7d91
• Remove unused RankingType enum

  We have `BeatmapLeaderboardScope` instead.

  Dean Herbert · 2021-06-14 11:27:46 +09:00
  17347401cf
• Rename configuration variables and refactor lots more
  Dean Herbert · 2021-06-11 16:37:31 +09:00
  20759657de
• Merge remote-tracking branch 'upstream/master' into chat-mention
  Craftplacer · 2021-06-05 11:18:06 +02:00
  39c3b08fc7
• add beatmap with storyboard source
  Nathan Alo · 2021-06-02 15:50:33 +08:00
  5b436ee436
• Update some out of date code pieces
  Dean Herbert · 2021-05-26 16:01:21 +09:00
  88bdd8a7b7
• Merge branch 'master' into chat-mention
  Dean Herbert · 2021-05-26 16:00:26 +09:00
  52ca2f4797
• Remove customisation of hit error via standard settings
  Dean Herbert · 2021-05-18 15:50:50 +09:00
  5acb708939
• Add back ctor doc
  smoogipoo · 2021-04-28 03:54:42 +09:00
  05bd6ee50c
• Fix up xmldoc
  smoogipoo · 2021-04-28 03:52:59 +09:00
  04454062b7
• Add support for custom controls to SettingSourceAttribute
  smoogipoo · 2021-04-28 02:51:24 +09:00
  4e3ee77396
• Setup configuration item for editor hit animations
  Dean Herbert · 2021-04-21 18:05:40 +09:00
  9d8f0c854d
• Fix duplicate code in setting default logic
  Dean Herbert · 2021-04-19 11:25:43 +09:00
  2b6caf9b65
• Implicitly set defaults when resetting values
  jvyden · 2021-04-17 08:47:27 -04:00
  6773162f17
• Revert back to hardcoded SessionStatics reset values
  jvyden · 2021-04-16 06:34:57 -04:00
  a4e3e53a63
• Apply peppy's suggestions
  jvyden · 2021-04-16 05:53:27 -04:00
  ec0211809f
• Reset SessionStatics on activity

  Closes #12424

  jvyden · 2021-04-16 05:01:58 -04:00
  7d23973ef8
• Merge pull request #12330 from Cublibre/master

  Send a warning notification if device is unplugged and at low battery

  Dean Herbert · 2021-04-15 19:21:04 +09:00
  5b06a68b93
• Remove unused using statement
  Dean Herbert · 2021-04-13 17:38:32 +09:00
  b41e3a2e7a
• Force the new default on update
  Dean Herbert · 2021-04-13 16:50:03 +09:00
  0932daeaa8
• Change default editor waveform opacity to 25%

  The previous setting felt way too high.

  Dean Herbert · 2021-04-13 16:48:06 +09:00
  5a06db8a11
• Remove empty <returns> xmldoc
  Dean Herbert · 2021-04-12 17:46:14 +09:00
  b5954a55ad
• Remove setters, cache CreatePowerStatus() and use a dummy LocalPowerStatus class in test scene
  Christine Chen · 2021-04-10 00:00:21 -04:00
  08311abc5e
• Send a warning notification if device is unplugged and low battery

  - Uses Xamarin.Essentials in osu.Game.PlayerLoader to check battery level
  - Encapsulated battery checking in the public BatteryManager class so battery level and plugged in status can be accessed and edited in TestPlayerLoader
  - When checking battery level, catch NotImplementedException thrown by Xamarin.Essentials.Battery on non-mobile platforms
  - Added visual unit tests for battery notification
    To mock battery status and level, we had to define a batteryManager object in TestPlayerLoader and add a new function ResetPlayerWithBattery()
  
  Co-Authored-By: Marlina José <marlina@umich.edu>

  Christine Chen · 2021-04-07 15:56:50 -04:00
  0a6baf670e
• Revert changes to SettingsSourceAttribute class
  Dean Herbert · 2021-03-18 21:16:50 +09:00
  c694deb7d6
• Merge branch 'update-config-usages' into input-handler-configuration
  Dean Herbert · 2021-03-17 18:08:13 +09:00
  e0c0107461
• Update usages of config with framework changes
  smoogipoo · 2021-03-17 16:10:16 +09:00
  7fa5fd5647
• Add the ability to not get controls for disabled bindables
  Dean Herbert · 2021-03-12 18:37:55 +09:00
  8635abbc4a
• Convert bindable names to human readable sentences
  Dean Herbert · 2021-03-12 18:34:22 +09:00
  4374e7da81
• Allow CreateSettingsControls to work with all bindables in target class
  Dean Herbert · 2021-03-12 18:34:22 +09:00
  a33ffd56b8
• Trim yet another array copy
  Bartłomiej Dach · 2021-02-27 15:46:18 +01:00
  7e17c5ab71
• Make SettingSourceAttribute implement IComparable
  Bartłomiej Dach · 2021-02-27 15:30:08 +01:00
  1e56d2cbba
• Fix multiple enumerations when ordering setting sources

  This was not spotted previously, because the base `Attribute` overrides
  `Equals()` to have semantics similar to structs (per-field equality) by
  using reflection. That masked the issue when strings were used, and
  migrating to `LocalisableString` revealed it, as that struct's
  implementation of equality currently uses instance checks.
  
  Whether `LocalisableString.Equals()` is the correct implementation may
  still be up for discussion, but allowing multiple enumeration is wrong
  anyway, since the underlying enumerables are live (one especially is a
  yield iterator, causing new object instances to be allocated).

  Bartłomiej Dach · 2021-02-27 14:58:01 +01:00
  528de5869e
• Fix failing tests doing reference comparisons between string and LocalisedString
  Dean Herbert · 2021-02-25 17:49:54 +09:00
  3802cb29a4
• Fix misordered hit error in score meter types
  Salman Ahmed · 2021-02-18 13:04:22 +03:00
  a01896a652