142 Commits

• Use more distinctive window title for tournament client

  This is in response to feedback in
  https://discord.com/channels/188630481301012481/1097318920991559880/1359117234257268747.
  The long and short of it is that without a unique title it's a bit hard
  to tell in software like OBS which window is the game and which window
  is the tournament client if wanting to run both, which I can agree with.

  Bartłomiej Dach · 2025-04-10 09:07:05 +02:00
  05dc113c70
• move to initialiser
  cdwcgt · 2023-07-30 02:41:45 +09:00
  bc2ca11bb0
• remove #nullable disable in tournament
  cdwcgt · 2023-07-29 22:25:06 +09:00
  8a06914438
• Remove fallbacks to empty APIBeatmap on population failure

  Was causing there to be two kinds of missing `TournamentBeatmap`s: one
  with missing `Beatmap == null`, and one with `Beatmap == new
  APIBeatmap()`. In particular, they would appear differently in UI
  (either as "unknown - unknown", or the intensely enigmatic " - ").

  Bartłomiej Dach · 2023-07-27 22:33:00 +02:00
  b7ddb5c946
• Fix startup tournament population not recovering from null beatmaps
  Dean Herbert · 2023-07-25 16:35:00 +09:00
  219ba00fb2
• Fix tournament bracket parsing regression

  Closes #24136.
  Regressed in #24037.

  Dean Herbert · 2023-07-06 17:17:17 +09:00
  b40532dde1
• Use GetResultSafely()
  cdwcgt · 2023-06-26 00:45:59 +09:00
  1b671b8c6e
• use BeatmapCache for populate beatmap information
  cdwcgt · 2023-06-25 22:57:39 +09:00
  14e26d2a85
• Fix tournament interface save button not usable after changing match progression/round
  Dean Herbert · 2023-03-23 14:01:19 +09:00
  540b38dc21
• Fix TournamentGameBase calling AddInternal
  Dean Herbert · 2023-01-20 23:53:30 +09:00
  154c258248
• Merge branch 'master' into tournament-always-use-production-endpoint
  Bartłomiej Dach · 2023-01-17 19:46:48 +01:00
  bb4d520500
• Merge branch 'master' into tournament-fix-save-changes-on-population
  Bartłomiej Dach · 2023-01-17 18:49:08 +01:00
  7dbbb7caa2
• Fix player rank data not being re-fetched after a tournament's ruleset is changed
  Dean Herbert · 2023-01-17 19:00:31 +09:00
  74bb44e05d
• Fix tournament client not saving changes after populating new data
  Dean Herbert · 2023-01-17 18:56:15 +09:00
  68636aeaaa
• Always use production (non-experimental) endpoints for tournament client
  Dean Herbert · 2023-01-17 18:46:06 +09:00
  26cd70f2bf
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Ensure seeding results get beatmaps populated if BeatmapIno model is null
  Dean Herbert · 2022-11-07 19:04:19 +09:00
  1e2e0dea74
• Rename MenuCursorContainer and clean up code
  Dean Herbert · 2022-07-26 14:11:52 +09:00
  ef10145d6f
• Replace default with CountryCode.Unknown
  Salman Ahmed · 2022-07-18 08:54:35 +03:00
  018da74fe8
• Country -> CountryCode
  Salman Ahmed · 2022-07-18 08:40:34 +03:00
  100c53f9ef
• Update tournament migration logic to check for null Country
  Salman Ahmed · 2022-07-16 05:04:24 +03:00
  b2b2a4adaf
• Disable tournament client "save changes" button when there's no changes to save
  Dean Herbert · 2022-07-13 17:46:09 +09:00
  11c8a2c16e
• Fix compile failures from framework breaking change
  Bartłomiej Dach · 2022-06-24 16:07:14 +02:00
  a83c45b50e
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Merge pull request #18751 from frenzibyte/tournament-beatmap

  Improve tournament beatmap JSON storage using lightweight model

  Dean Herbert · 2022-06-18 11:00:26 +09:00
  f3c9f9a216
• TournamentPlayer -> TournamentUser
  Salman Ahmed · 2022-06-18 02:33:26 +03:00
  4c47996130
• Standardise naming for online ID

  Rather than continuing with `ID` or `Id`, this should follow the new
  standards and use `OnlineID` instead. Only updating this since it's a
  newly introduced class.

  Salman Ahmed · 2022-06-18 01:48:16 +03:00
  60903be566
• Replace tournament beatmap storage type with lightweight model
  Salman Ahmed · 2022-06-18 01:34:09 +03:00
  9f97d1a7db
• Replace tournament player storage type with lightweight model
  Salman Ahmed · 2022-06-17 21:35:04 +03:00
  b977ce7995
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix tournament user stat population potentially using wrong ruleset

  `OsuGameBase.Ruleset` is bound
  [late](https://github.com/ppy/osu/blob/7d0470794bcd454d3a93954ec4fe3415933627ef/osu.Game.Tournament/TournamentGameBase.cs#L169)
  so we must use the ladder one during user retrieval.
  
  Closes https://github.com/ppy/osu/issues/18363.

  Dean Herbert · 2022-05-23 14:07:11 +09:00
  afbb1fa750
• Update unsafe file write usages
  Dean Herbert · 2022-05-16 18:05:27 +09:00
  218642c300
• Fix tournament bracket parsing's ruleset refetch logic not working correctly

  Due to equality being based on `ShortName`, it was feasible that the
  re-fetch exited early (in bindable shortcutting logic) causing the
  ruleset's `OnlineID` to remain `-1` or something equally wrong.
  
  Resolves issue pointed out at
  https://github.com/ppy/osu/discussions/17538#discussioncomment-2471746.

  Dean Herbert · 2022-03-31 18:41:00 +09:00
  a06b0a4966
• Add test coverage ensuring ruleset ID is correct after bracket read

  Historically, tournament client may have written incorrect `OnlineID`
  values. We wanted to use `ShortName` to re-fetch the ruleset. This test
  ensures this flow is working correctly.

  Dean Herbert · 2022-03-31 18:39:58 +09:00
  a7a7584d3e
• Add far too many fixes for ruleset non-nullable requirements
  Dean Herbert · 2022-01-12 23:24:11 +09:00
  b5f670cc5b
• Fix CI reported warnings
  Dean Herbert · 2022-01-12 22:39:00 +09:00
  51251e3204
• Avoid saving bracket if parsing failed, at all costs
  Dean Herbert · 2021-12-03 16:06:38 +09:00
  5158736839
• Centralise specification of bracket.json filename
  Dean Herbert · 2021-12-03 16:04:11 +09:00
  ba05a0a383
• Rename User to APIUser and move to correct namespace
  Dean Herbert · 2021-11-07 11:26:01 +09:00
  0ecf5f201c
• Merge pull request #15319 from peppy/beatmap-refactor/tournament

  Remove all usage of `BeatmapInfo` / `BeatmapSetInfo` from tournament mode

  Dan Balasescu · 2021-10-28 16:26:06 +09:00
  f9ca7f5df1
• Add mention of why the serialisation happens outside stream usage
  Dean Herbert · 2021-10-28 15:04:09 +09:00
  a6669a3892
• Fix serlialisation failure during ladder saving causing all existing file content to be deleted
  Dean Herbert · 2021-10-28 15:00:30 +09:00
  ef26b0ba8a
• Rename all usages of APIBeatmap to beatmap in tournament namespace
  Dean Herbert · 2021-10-27 18:42:48 +09:00
  f1499641f3
• Change repopulation rules to cover the fact that the serisalisation model has changed

  This also adds a progress display to show how repopulation is going. It
  can take a while on a large bracket.

  Dean Herbert · 2021-10-27 18:42:48 +09:00
  5448b94039
• Fix PopulateUser not populating immediately when immediate is specified (due to scheduling)
  Dean Herbert · 2021-10-27 18:26:44 +09:00
  35168948fe
• Update tournament components to use APIBeatmap directly
  Dean Herbert · 2021-10-27 18:26:44 +09:00
  3130616300
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Fix tournament client silently failing on error during parsing
  Dean Herbert · 2021-10-25 16:49:33 +09:00
  7111f58bfe
• Rename APIRequest.Result to Response
  Dean Herbert · 2021-10-05 14:28:56 +09:00
  b41fa41c85
• Rename all remaining cases
  Dean Herbert · 2021-10-03 00:55:29 +09:00
  ec61c3c5ee