10447 Commits

• Address review comments
  Tom Martin · 2025-06-11 04:34:13 +01:00
  33905f2e70
• Remove shear on update button to match non-sheared panel design
  Dean Herbert · 2025-06-10 14:01:49 +09:00
  8afac6a00d
• Merge pull request #33581 from bdach/disallow-placing-gameplay-leaderboard-outside-gameplay

  Disallow placing gameplay leaderboard in skins outside player

  Dean Herbert · 2025-06-10 13:21:16 +09:00
  cb5b85b705
• Allow changing difficulties using up and down arrows when sets are grouped
  Dean Herbert · 2025-06-10 13:06:30 +09:00
  cc150faf81
• Fix intermittent online play mod select tests
  Dan Balasescu · 2025-06-09 23:15:48 +09:00
  55a3ec5026
• Merge pull request #33584 from smoogipoo/fix-flaky-collections-test

  Fix flaky collections test

  Dan Balasescu · 2025-06-09 22:47:29 +09:00
  34cbfca157
• Fix flaky collections test
  Dan Balasescu · 2025-06-09 21:53:19 +09:00
  83ce468c57
• Disallow placing gameplay leaderboard in skins outside player

  Closes https://github.com/ppy/osu/issues/33542.
  
  For a diff this simple this took much more hemming and hawing because
  things are a bit annoying here from a few angles:
  
  - The only way that is considered idiomatic right now for a skin
    component to not be applicable to a screen is to require a dependency
    from DI that is only provided by applicable screens.
    `DrawableGameplayLeaderboard` has a few of those dependencies, but the
    scope of all the usages makes it so that the only really viable one to
    use here is `IGameplayLeaderboardProvider` itself (see: visual tests,
    and also the usage of multiplayer spectator, where the leaderboard is
    *not* under a player instance).
  
  - The smelly part of this is that the `Player` inheritance hierarchy
    must ensure that *every* non-abstract class has an
    `IGameplayLeaderboardProvider` cached. It is not trivial - if not
    straight up impossible - to force this via some `Player` level
    abstract method, because such a method would need to somehow
    accommodate all possible leaderboard providers. That however also
    means that every possible future `Player` implementor *must inherently
    know* to also cache a leaderboard provider lest it die at runtime. I
    don't love that, but I also don't see better alternatives.
  
  - Speaking of which, I also noticed that solo spectator and playlists
    don't have gameplay leaderboards. At all. Which I don't believe to be
    something that I broke with the leaderboard work - I'm pretty sure
    that was the pre-existing state - however I don't see any reason why
    they *couldn't* receive gameplay leaderboards. I'm not doing that
    here, though, just leaving TODOs for later.

  Bartłomiej Dach · 2025-06-09 13:11:29 +02:00
  6416f59c7b
• Fix oversight in other test
  Bartłomiej Dach · 2025-06-09 11:01:45 +02:00
  348c727264
• Add failing test coverage
  Bartłomiej Dach · 2025-06-09 10:52:10 +02:00
  9707fd43f4
• Merge branch 'master' into fix-drag-delete-bug
  Bartłomiej Dach · 2025-06-09 09:17:52 +02:00
  44563c03f0
• Fix up test

  - Use constraints for better assert messages
  - Use `Editor.Undo()` rather than manual input manager synthesizing
    ctrl-z (ctrl-z is not a platform agnostic binding, see macOS)

  Bartłomiej Dach · 2025-06-09 09:16:19 +02:00
  35ff330e85
• Add failing test cases
  Salman Alshamrani · 2025-06-09 09:47:31 +03:00
  fa402fe084
• Always allow a map's user-tags to be read
  Tom Martin · 2025-06-07 22:51:13 +01:00
  934e529eca
• SongSelectV2: Add back highlighting friend scores on the leaderboard
  Bartłomiej Dach · 2025-06-06 13:53:32 +02:00
  90084e27e5
• Merge pull request #33498 from bdach/ssv2-leaderboard-cut-off

  Fix several issues with leaderboard score display

  Dean Herbert · 2025-06-06 19:43:27 +09:00
  3335b99064
• Fix several issues with leaderboard score display

  - Enforces minimum width on accuracy / max combo displays which could
    previously look broken in CJK languages, thus fixing
    https://github.com/ppy/osu/issues/33434. Minimum sizes were chosen to
    accomodate what could be considered reasonably possible with some
    leeway on top.
  
  - Fixes hilariously broken logic that was supposed to highlight perfect
    / FC / max combo scores in green but instead did nothing due to two
    disparate bugs in a single line of code.
  
  - Extends the highlighting logic to also apply to 100% accuracy because
    web does this and I think it's nice.

  Bartłomiej Dach · 2025-06-06 11:25:02 +02:00
  b61688596b
• Fix general confusion in which combo should be read on which gameplay leaderboard

  Closes https://github.com/ppy/osu/issues/33455.
  
  The fundamental misunderstanding and source of confusion in
  https://github.com/ppy/osu/pull/33062 is that solo wants to show
  *maximum combo*, and multiplayer wants to show *current combo*, for
  their own, valid reasons. Which is spelled out explicitly in this
  change.

  Bartłomiej Dach · 2025-06-06 10:08:01 +02:00
  a92a659662
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• better comment, fix typo in test case
  Chris Ehmann · 2025-06-05 18:28:17 -07:00
  5e3eb70829
• Add test for undoing after quick deleting an object while it is dragged.
  Chris Ehmann · 2025-06-05 17:46:31 -07:00
  3af348c6eb
• Merge pull request #33418 from minetoblend/feature/ssv2-animated-ghost

  SongSelectV2: Animate placeholder ghost

  Dean Herbert · 2025-06-05 16:12:49 +09:00
  278a372a90
• Merge branch 'master' into feature/ssv2-animated-ghost
  maarvin · 2025-06-04 21:15:24 +02:00
  14cd6eac87
• Add test coverage of editor flow from song select
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  bb49bb5e23
• Add back more song select navigation tests
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  118583bf21
• Merge pull request #33413 from bdach/update-framework

  Update framework

  Dean Herbert · 2025-06-05 03:15:27 +09:00
  6d5bf22a71
• Add ghost drawable
  marvin · 2025-06-04 19:58:04 +02:00
  7ecf81d3a0
• Add failing test showing recommended selection occurring on already selected set
  Dean Herbert · 2025-06-04 21:19:51 +09:00
  7e922763c1
• Fix cursor test
  Bartłomiej Dach · 2025-06-04 13:34:21 +02:00
  68795255ee
• Mark test scene class partial
  Bartłomiej Dach · 2025-06-04 11:23:10 +02:00
  2cd923ba26
• Add back test covering immediate exit song select
  Dean Herbert · 2025-06-04 17:59:08 +09:00
  7d8df1d8d4
• Fix audio not correctly continuing on resuming from gameplay
  Dean Herbert · 2025-06-04 17:39:22 +09:00
  f086be9c18
• Add failing test coverage showing bad selection logic
  Dean Herbert · 2025-06-04 15:45:36 +09:00
  b42b8ba0de
• Merge pull request #33373 from peppy/song-select-v2-more-sane-input-padding

  SongSelectV2: Store input padding adjustments in `CarouselItem` to allow more reliable inflation

  Bartłomiej Dach · 2025-06-04 07:41:18 +02:00
  3624c251a2
• Mark some more recent flaky tests
  Dean Herbert · 2025-06-03 16:23:31 +09:00
  ef29eda3e0
• Store input padding adjustments in CarouselItem to allow more reliable inflation
  Dean Herbert · 2025-06-02 19:11:47 +09:00
  90b9fb0809
• Merge branch 'master' into song-select-v2-fix-random-difficulty-filtered
  Bartłomiej Dach · 2025-06-02 09:57:05 +02:00
  d819dfc180
• Disable broken tests temporarily
  Dean Herbert · 2025-06-02 16:55:21 +09:00
  a0eb39d26d
• Add failing test showing random selecting filtered-away difficulties
  Dean Herbert · 2025-06-01 00:58:56 +09:00
  0fc129fbac
• SongSelectV2: Fix input gap between last beatmap panel in set and next set panel
  Bartłomiej Dach · 2025-05-30 19:13:42 +02:00
  f462c683ee
• Fix missing ConfigureAwait causing Items to potentially be copied on non-update thread
  Dean Herbert · 2025-05-30 19:39:49 +09:00
  7025c2cf2f
• Add test showing carousel never loading under high beatmap churn
  Dean Herbert · 2025-05-30 19:39:48 +09:00
  671c08df8e
• Merge pull request #33332 from peppy/song-select-v2-fix-double-filter

  SongSelectV2: Fix carousel filtering twice on entering song select

  Bartłomiej Dach · 2025-05-30 12:29:32 +02:00
  559ddd1ec9
• Merge pull request #33335 from bdach/song-select-v2-single-items-arent-shown
  Dean Herbert · 2025-05-30 19:29:15 +09:00
  8cea1e2e1d
• Merge branch 'master' into song-select-v2-fix-incorrect-gameplay-start
  Bartłomiej Dach · 2025-05-30 11:40:28 +02:00
  74c7d6603c
• Merge branch 'master' into song-select-v2-single-items-arent-shown
  Bartłomiej Dach · 2025-05-30 11:38:06 +02:00
  e4cd8bcc59
• Add failing test case
  Bartłomiej Dach · 2025-05-30 11:20:00 +02:00
  68504e9639
• Use nullable Criteria instead of ctor flag
  Dean Herbert · 2025-05-30 18:15:27 +09:00
  5bf235f2dc
• Merge branch 'master' into song-select-v2-polish-2
  Bartłomiej Dach · 2025-05-30 11:07:11 +02:00
  4915e4d266
• Fix test being sensitive to selected tab on new song select
  Bartłomiej Dach · 2025-05-30 10:02:40 +02:00
  9d0d3bb97a