41 Commits

• Address review comments
  Tom Martin · 2025-06-11 04:34:13 +01:00
  33905f2e70
• Fix crashes in statistics panel test scene
  Bartłomiej Dach · 2025-04-07 14:49:55 +02:00
  9643beafa7
• Move the extra tag selector out of popover
  Bartłomiej Dach · 2025-03-28 14:05:35 +01:00
  1d44d5e100
• Remove unused local
  Dean Herbert · 2025-03-26 19:10:14 +09:00
  90bc2318e1
• Allow tagging already played beatmaps without playing another time

  Addresses
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12610577.
  
  No changes in criteria (yet?), just allowing locally imported plays to
  count the same way as full beatmap completion does.
  
  The test scene is a bit rough / semi-manual but dealing with score
  imports is a bit of a pain in general. The way to semi-manually test
  with the test scene is to import a subset of scores, then recreate the
  statistics panel, and observe behaviour. I'm not sure it's worth it to
  be putting subscriptions in there, so the full recreation of the panel
  is necessary.

  Bartłomiej Dach · 2025-03-25 14:16:26 +01:00
  40d20f4e10
• Add visual test coverage for no convert conditional
  Bartłomiej Dach · 2025-03-20 10:32:40 +01:00
  36ba9dbc8c
• Fix test
  Bartłomiej Dach · 2025-03-13 12:06:27 +01:00
  723a22130d
• Require high enough score rank for tagging beatmap
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  5b1a4c8ed1
• Simplify boolean flags
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  f78e371b1b
• Add visual test coverage of user tag control on results
  Bartłomiej Dach · 2025-03-12 12:20:37 +01:00
  6f74d8ad50
• Remove inheritance in StatisticsPanel
  Bartłomiej Dach · 2025-03-12 12:17:38 +01:00
  5f0451eb79
• Rewrite OverallRanking to interface directly with UserStatisticsWatcher
  Bartłomiej Dach · 2025-03-12 12:17:02 +01:00
  0ffb233796
• Decouple game-wide ruleset bindable and refactor LocalUserStatisticsProvider

  This also throws away the logic of updating
  `API.LocalUser.Value.Statistics`. Components should rely on
  `LocalUserStatisticsProvider` instead for proper behaviour and ability
  to update on statistics updates.

  Salman Alshamrani · 2024-11-17 18:13:37 -05:00
  4a628287e2
• Add failing test case
  Bartłomiej Dach · 2024-09-24 17:51:54 +02:00
  555d4ffe89
• Move away from Solo namespace
  Salman Ahmed · 2024-02-29 01:21:17 +03:00
  8f97f0503f
• Rename {Solo -> User}StatisticsWatcher et al.

  The "solo" prefix is a bit unbecoming now. The updates are not only
  for solo.

  Bartłomiej Dach · 2024-02-22 20:36:24 +01:00
  eac4c5f69d
• Show user statistics after completing a playlists / multiplayer score
  Bartłomiej Dach · 2024-02-22 20:35:50 +01:00
  1e53503608
• Disable new rider EAP inspection in test class
  Dean Herbert · 2023-11-12 17:21:17 +09:00
  31feeb5ddc
• Add actual statistics changes to better visualise layout
  Dean Herbert · 2023-07-13 18:12:46 +09:00
  654a7057fc
• Show online stats on TestSceneStatisticsPanel

  Fix test regression

  Dean Herbert · 2023-07-13 18:12:37 +09:00
  aebbffacf2
• Add full statistics score to TestSceneResultsScreen
  Dean Herbert · 2023-07-13 18:12:35 +09:00
  b7ab46d87b
• Change order and test population in TestSceneStatisticsPanel to give better visible results
  Dean Herbert · 2023-07-13 18:12:19 +09:00
  6529c810fa
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix unobserved exceptions due to unimplemented beatmap converter

  `TestSceneStatisticsPanel` intends to check the operation of statistics
  panels using dummy ruleset classes. However, `StatisticsPanel` relies on
  being able to retrieve the playable beatmap, which requires a converter.
  One was not provided by the dummy rulesets, therefore the retrieval
  would fail with an unobserved exception.
  
  To fix, add a barebones converter implementation that is enough for the
  test to pass.

  Bartłomiej Dach · 2022-05-28 14:10:57 +02:00
  e18fec3d89
• Add test cases for manual testing
  Henry Lin · 2022-02-03 17:00:40 +08:00
  a27d0572ed
• Simplify usages where the ruleset being used is osu! ruleset
  Dean Herbert · 2021-12-13 16:37:20 +09:00
  99ac71c1fe
• Move test ScoreInfo creation to TestResources

  The main goal here is to remove the inheritance, since realm doesn't
  like that. Unfortunate that we can't use object initialisers in a few of
  these places, but no real way around that.

  Dean Herbert · 2021-12-13 16:34:50 +09:00
  b0d14526ea
• Make method private
  Bartłomiej Dach · 2020-11-11 22:41:25 +01:00
  1426530496
• Reduce amount of casting
  Bartłomiej Dach · 2020-11-11 22:40:52 +01:00
  1984a9f70d
• Reference constant through base class
  Bartłomiej Dach · 2020-11-11 22:37:15 +01:00
  423f0fbda7
• Fix formatting
  kamp · 2020-11-11 21:52:43 +01:00
  8341d3ad74
• Add test for accuracy heatmap to TestCaseStatisticsPanel
  kamp · 2020-11-11 20:20:29 +01:00
  85017a0094
• Fix possible nullref
  smoogipoo · 2020-06-19 22:48:21 +09:00
  037bd3b463
• Move timing distribution graph to osu.Game
  smoogipoo · 2020-06-19 20:03:18 +09:00
  1cbbd6b442
• Move hit events to the ScoreProcessor
  smoogipoo · 2020-06-19 19:58:35 +09:00
  eab00ec9d9
• Display placeholder if no statistics available
  smoogipoo · 2020-06-18 22:21:30 +09:00
  ecdfcb1955
• Rework score processor to provide more generic events
  smoogipoo · 2020-06-18 22:11:03 +09:00
  20db5b33ab
• Improve test scene
  smoogipoo · 2020-06-16 17:49:37 +09:00
  808e216059
• Fix test name
  smoogipoo · 2020-06-16 16:08:41 +09:00
  a65c1a9abd