osu-lazer

Add test for scores with long score/combo numbers

Salman Alshamrani · 2025-08-18 13:46:51 +03:00

bb5933ef80

Add ability to resize leaderboard in tests

Salman Alshamrani · 2025-08-13 12:51:09 +03:00

62803af1de

Remove bindable added only for tests

Dean Herbert · 2025-08-11 21:07:55 +09:00

e93d15ef0e

Add back comment regarding bad bindable casting

Dean Herbert · 2025-08-11 20:57:01 +09:00

9d6a0208f1

Rewrite gameplay leaderboard test scene to be usable

At some point during the leaderboard data refactor, this test scene
became completely unusable. This change rewrites it to use
`SoloGameplayLeaderboardProvider` to be able to witness the user score
being resorted and advancing through the leaderboard.

Salman Alshamrani · 2025-07-22 23:58:06 +03:00

84a36b1bfa

Combine two similar flags into one

Dean Herbert · 2025-06-12 17:27:23 +09:00

ebfc3c9ccf

Fix test not showing immediately useful state

Also standardises the testing leaderboard provider component for
(immediate) future use.

Dean Herbert · 2025-05-13 15:53:47 +09:00

1d7f922068

Fix gameplay leaderboard not always being expanded in gameplay leaderboard

I'd have preferred a `get; init;` property but tests were also attached
at the hip to the public bindable. Without some extra composition this
is the best that I can do.

Bartłomiej Dach · 2025-05-07 12:09:26 +02:00

8cc2af4060

Merge branch 'master' into gameplay-leaderboard-skinnable

Bartłomiej Dach · 2025-05-07 10:45:51 +02:00

5b61761bbd

Remove failing test

The sorting logic is now exercised in
`TestSceneSoloGameplayLeaderboardProvider`. Trying to work around
it with local test classes would mean that the test would be covering
test code, i.e. complete nonsense and having a green test for the sake
of having a green test.

Bartłomiej Dach · 2025-04-28 12:32:41 +02:00

c1fbf50622

Use actual score positions in gameplay leaderboard

Intends to close https://github.com/ppy/osu/issues/32859.

The difference between this and https://github.com/ppy/osu/pull/32942 is
that this PR takes the approach of completely moving the score sorting
behaviour to `IGameplayLeaderboardProvider` implementations.

This is going to be helpful for further work - to be precise, I am
looking to add a leaderboard position indicator in the bottom right of
multiplayer player to match stable, and having the position in the
provider will make the implementation of that *much* easier.

Bartłomiej Dach · 2025-04-25 12:40:55 +02:00

06dc4235f0

Delete no-longer-relevant test

Bartłomiej Dach · 2025-04-24 14:50:09 +02:00

242f1bf68f

Remove unnecessary interface

Bartłomiej Dach · 2025-04-18 12:12:21 +02:00

6d258d4ed5

Add failing test for incorrect score position treatment

Bartłomiej Dach · 2025-04-18 12:01:04 +02:00

39f9eabf40

Fix code quality

Bartłomiej Dach · 2025-04-18 09:09:57 +02:00

2c690ae94c

Separate gameplay leaderboard data management from display

This is a prerequisite for supporting skinning of leaderboards.

- New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
  interfaces are introduced. They are strictly concerned with supplying
  leaderboard data.

- Logic of managing display, which was previously jammed into the
  inheritance hierarchy of `GameplayLeaderboard`, is now moved into
  `IGameplayLeaderboardProvider` implementations. Solo play,
  multiplayer, and multiplayer spectator get their own implementation of
  the interface.

- The inheritance hierarchy of `GameplayLeaderboard` and per-player
  overriding of the implementation of the gameplay leaderboard is gone.
  Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
  allowed to display the leaderboards, across all modes of play.

Bartłomiej Dach · 2025-04-16 14:46:55 +02:00

c231571f06

remove CreateAPIRelationFromAPIUser

cdwcgt · 2024-11-01 19:24:58 +08:00

1a92e5ad19

add test

cdwcgt · 2024-11-01 14:05:24 +08:00

0b2f4facac

Fix TestFriendScore intermittently failing due to randomness

If `createRandomScore()` happened to randomly pick the highest total
score when called with `friend` as the sole argument, that particular
score would not be pink.

`GetScoreByUsername()` would arbitrarily pick the first score for the
user, so in this particular case where a friend had the number 1 score,
the test would wrongly fail.

Fix by checking whether any of the 3 added friend scores have received
the pink colour. Because there is more than 1 friend score in the test,
doing so ensures that at least one of those should eventually become
pink (because, obviously, you can't have two scores at number 1).

Bartłomiej Dach · 2023-09-21 21:12:44 +02:00

e45d456324

Rewrite TestFriendScore assertions to constraint model

Allows to clearly see what the failure is:

	TearDown : System.TimeoutException : "friend score is pink" timed out: Expected: some item equal to "#FF549A"
	  But was:  < "#FFFFFF", "#7FCC33", "#444444" >

The #7FCC33 colour is used for the first score on the leaderboard.

Bartłomiej Dach · 2023-09-21 21:05:41 +02:00

9301a1907a

Tidy up test

Dean Herbert · 2023-09-07 14:50:22 +09:00

87ec33bb66

color friend score to pink

cdwcgt · 2023-09-06 22:58:03 +09:00

68752f95e5

Partial everything