289 Commits

• Adjust some formatting to read better
  Dean Herbert · 2025-08-04 18:20:56 +09:00
  af290ddc0c
• Fix oversight from refactoring
  Bartłomiej Dach · 2025-08-01 13:27:58 +02:00
  db05adbdc0
• Clarify comment further
  Bartłomiej Dach · 2025-08-01 12:18:16 +02:00
  2f5d89590f
• Simplify redundant code
  Bartłomiej Dach · 2025-08-01 12:12:20 +02:00
  b22ca878ba
• Adjust displayed precision to match stable
  Bartłomiej Dach · 2025-08-01 12:00:25 +02:00
  21ef184ae3
• Show effect of beatmap attributes on gameplay metrics in osu!
  Bartłomiej Dach · 2025-08-01 11:07:48 +02:00
  655733c06d
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Initial Implementation (working, unsafe handling of cursor position)
  jhk2601 · 2024-10-11 18:38:53 -04:00
  0794fc61a0
• Ensure columns collapse into one correctly if no space
  Bartłomiej Dach · 2024-10-03 15:01:23 +02:00
  1bab2236fe
• Redo the layout of sections based on discord feedback

  See
  https://discord.com/channels/188630481301012481/188630652340404224/1291358770064130140
  and everything after.

  Bartłomiej Dach · 2024-10-03 13:53:21 +02:00
  99eb26b7d5
• Add property EditorShowScrollSpeed to Ruleset
  OliBomby · 2024-08-22 19:53:34 +02:00
  998b5fdc12
• Remove setup screen controls that do nothing useful

  Before I go with a hammer to redesign these, I want to remove stuff that
  does nothing first.
  
  Hard-breaks API to allow rulesets to specify an enumerable of custom
  sections rather than two specific weird ones.
  
  For specific rulesets:
  
  - osu!:
    - Stack leniency slider merged into difficulty section.
  - osu!taiko:
    - Approach rate and circle size sliders removed.
    - Colours section removed.
  - osu!catch:
    - No functional changes.
  - osu!mania:
    - Special style toggle merged into difficulty section.
    - Colours section removed.

  Bartłomiej Dach · 2024-07-10 14:53:16 +02:00
  c8a64c5950
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Update triangles skin judgment display
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  107b37494e
• Make slider ends show on results screen again
  Dean Herbert · 2024-01-02 17:01:32 +09:00
  94531807e4
• Merge branch 'master' into depth-mod
  Andrei Zavatski · 2023-12-23 22:09:12 +03:00
  e470a42da0
• Use classic HP values for non-classic osu! HP drain
  Dan Balasescu · 2023-12-22 02:16:46 +09:00
  3f6dad5502
• Change osu ruleset to use new HP algorithm by default
  Dan Balasescu · 2023-12-17 19:33:04 +09:00
  4b9aefa6f2
• Use HitWindows data directly for computing effective OD
  Bartłomiej Dach · 2023-12-14 20:41:12 +01:00
  0f4d054bfe
• Extract preempt durations to shared constants
  Bartłomiej Dach · 2023-12-14 20:41:12 +01:00
  605269f65f
• Use IBeatmapDifficultyInfo.(Inverse)DifficultyRange() instead of local reimplementations

  Also adds explicit references to places from where the magic constants
  were lifted.

  Bartłomiej Dach · 2023-12-14 20:41:12 +01:00
  fd1c72bf74
• Tidy up GetRateAdjustedDisplayDifficulty implemetations
  Dean Herbert · 2023-12-13 17:13:21 +09:00
  9a982a9564
• Merge branch 'master' into arod_rate_adjust
  Givikap120 · 2023-12-10 01:49:18 +02:00
  faf54bca43
• Implement OsuModDepth
  Andrei Zavatski · 2023-12-03 04:58:17 +03:00
  dc588e6d56
• Rename method and adjust xmldoc to be very explicit about how wrong this is
  Dean Herbert · 2023-11-17 17:04:20 +09:00
  9172632b0b
• Make osu ruleset use the new health processor
  Dan Balasescu · 2023-11-13 13:12:56 +09:00
  7713da499f
• Apply various inspections
  Dean Herbert · 2023-11-12 16:24:35 +09:00
  a04f9aaef7
• Merge branch 'master' into arod_rate_adjust
  Dean Herbert · 2023-11-12 15:49:07 +09:00
  6bd5eda2a0
• Delete util functions from rulesets
  Givikap120 · 2023-11-09 18:23:53 +02:00
  e451b2197c
• fixed bug in AR formula
  Givikap120 · 2023-11-04 18:01:10 +02:00
  5597e819be
• Improve code quality
  Givikap120 · 2023-11-04 17:25:09 +02:00
  57170501cd
• Added BeatmapAttributesDisplay support
  Givikap120 · 2023-09-12 16:44:44 +03:00
  1a70110a4e
• Split legacy scoring attributes into a separate object
  Dan Balasescu · 2023-09-07 21:10:38 +09:00
  2334be1987
• fixed stated problems

  removed functions from `Ruleset.cs` and added a `GetEffectiveDifficulty()` instead

  Givikap120 · 2023-08-26 02:13:14 +03:00
  290f8db341
• Fixed "works only for std" problem

  1) Now it use AR/OD calculation from Ruleset class
  2) Implemented needed functions in each of default rulesets

  Givikap120 · 2023-08-25 00:58:26 +03:00
  17b9b1649a
• Merge branch 'master' into results-screen-component-metrics
  Bartłomiej Dach · 2023-07-13 19:53:52 +02:00
  d5912165e9
• Add missing heading for statistics section in results screen
  Dean Herbert · 2023-07-13 18:50:52 +09:00
  9ad63bae37
• Adjust metrics of SimpleStatisticTable
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  947b40149f
• Implement back-and-forth conversion of ModScoreV2 and LegacyMods
  Bartłomiej Dach · 2023-07-09 16:15:21 +02:00
  7be5e0e978
• ILegacyScoreProcessor -> ILegacyScoreSimulator
  Dean Herbert · 2023-07-04 17:32:54 +09:00
  1629024111
• Move Ruleset method to ILegacyRuleset interface
  Dan Balasescu · 2023-06-29 17:24:37 +09:00
  c6ad184d94
• Refactoring
  Dan Balasescu · 2023-06-28 16:14:32 +09:00
  09bc8e45de
• Initial conversion of scores
  Dan Balasescu · 2023-06-26 22:19:01 +09:00
  a9c65d200a
• Merge branch 'master' into snap-colour-mod
  Dean Herbert · 2023-06-19 20:01:36 +09:00
  aa96fefae2
• Added recommendations from bdach:

  Fixed null checking in ApplyToDrawableHitObject
  Renamed mod to "Synesthesia"
  Moved to the "Fun" mod category

  John Biddle · 2023-06-08 00:52:28 -07:00
  d07437f810
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Initial commit for the snap colour mod. Implements basic functionality.
  John · 2023-05-12 19:07:25 -07:00
  e5884016ab
• Merge branch 'master' into bubble_mod_implementation_clean
  MK56 · 2023-01-27 11:58:56 +01:00
  c50604f701