31 Commits

• Fix edge case allowing almost-zero-length sliders to be placed during distance snapping
  Dean Herbert · 2025-03-11 16:17:44 +09:00
  23891b1994
• Fix possible crash when scaling objects in editor

  The specific fail case here is when `s.{X,Y}` is 0, and
  `s{Lower,Upper}Bound` is `Infinity`. Because IEEE math is IEEE math,
  `0 * Infinity` is `NaN`.
  
  `MathHelper.Clamp()` is written the following way:
  
  	https://github.com/ppy/osuTK/blob/af742f1afd01828efc7bc9fe77536b54aab8b419/src/osuTK/Math/MathHelper.cs#L284-L306
  
  `Math.{Min,Max}` are both documented as reporting `NaN` when any of
  their operands are `NaN`:
  
  	https://learn.microsoft.com/en-us/dotnet/api/system.math.min?view=net-8.0#system-math-min(system-single-system-single)
  	https://learn.microsoft.com/en-us/dotnet/api/system.math.max?view=net-8.0#system-math-max(system-single-system-single)
  
  which means that if a `NaN` happens to sneak into the bounds, it will
  start spreading outwards in an uncontrolled manner, and likely crash
  things.
  
  In contrast, the standard library provided `Math.Clamp()` is written
  like so:
  
  	https://github.com/dotnet/runtime/blob/577c36cee56480dec4d4610b35605b5d5836888b/src/libraries/System.Private.CoreLib/src/System/Math.cs#L711-L729
  
  With this implementation, if either bound is `NaN`, it will essentially
  not be checked (because any and all comparisons involving `NaN` return
  false). This prevents the spread of `NaN`s, all the way to positions
  of hitobjects, and thus fixes the crash.

  Bartłomiej Dach · 2025-02-28 13:34:00 +01:00
  ffef6ae185
• Rename methods to fit new changes better
  Bartłomiej Dach · 2024-10-11 15:03:30 +02:00
  d1da1d4079
• Add more comments
  OliBomby · 2024-10-03 11:49:45 +02:00
  19d8be4890
• fix scale clamp computation and code cleanup
  OliBomby · 2024-10-01 16:45:39 +02:00
  08e1698bb6
• compute lower bound in clamp scale
  OliBomby · 2024-10-01 16:45:27 +02:00
  0677430975
• Merge branch 'master' into selection-center
  Bartłomiej Dach · 2024-09-27 09:30:36 +02:00
  fa90b43233
• Use scale origin when scaling sliders
  Marvin Schürz · 2024-09-20 17:19:38 +02:00
  8ceea9a5f7
• use minimum enclosing circle selection centre in scale
  OliBomby · 2024-09-20 01:07:54 +02:00
  8e11cda41a
• fix rotated scale bounds again
  OliBomby · 2024-07-14 16:58:05 +02:00
  58eb7f6fe1
• Revert "fix incorrect rotated bound checking"

  This reverts commit 4165ded813.

  OliBomby · 2024-07-14 15:46:40 +02:00
  ae38002777
• fix incorrect rotated bound checking
  OliBomby · 2024-07-03 19:03:15 +02:00
  4165ded813
• fix warning
  OliBomby · 2024-07-03 16:41:57 +02:00
  0797d942ae
• simplify code
  OliBomby · 2024-07-03 16:41:41 +02:00
  979a5e9f3e
• scale along rotated axis
  OliBomby · 2024-07-03 16:23:19 +02:00
  d0715c5f12
• Fix crashes when opening scale/rotation popovers during selection box operations
  Bartłomiej Dach · 2024-06-25 15:20:59 +02:00
  2fda45cad4
• Rename another method
  Bartłomiej Dach · 2024-05-29 09:43:09 +02:00
  4a8273b6ed
• disable playfield centre origin when scaling slider and simplify logic
  OliBomby · 2024-05-28 18:27:01 +02:00
  9a18ba2699
• refactor CanScaleFromPlayfieldOrigin and GetClampedScale to derived class
  OliBomby · 2024-05-28 17:12:16 +02:00
  d143a697d2
• remove redundant CanScaleFromSelectionOrigin
  OliBomby · 2024-05-28 16:19:57 +02:00
  8eb23f8a60
• rename CanScaleSelectionOrigin/PlayfieldOrigin to make clear its not the origin being scaled
  OliBomby · 2024-05-28 16:14:16 +02:00
  a89ba33b47
• Enable scale buttons at the correct times
  OliBomby · 2024-05-25 20:35:06 +02:00
  37530eebcc
• calculate max scale bounds for scale slider
  OliBomby · 2024-05-25 20:17:27 +02:00
  4eeebdf60c
• Remove leftover log

  whooops.

  Bartłomiej Dach · 2024-05-23 15:13:42 +02:00
  d8ba95f877
• Bring back clamping in osu! scale handler

  Being able to flip doesn't really feel all that good and `master` was
  already clamping, so let's just bring that back for now. Flipping can be
  reconsidered in a follow-up if it actually can be made to behave well.

  Bartłomiej Dach · 2024-05-23 15:01:29 +02:00
  3e34b2d37e
• Simplify original state management in osu! scale handler
  Bartłomiej Dach · 2024-05-23 15:01:29 +02:00
  f7bcccacb0
• fix adjust axes detection
  OliBomby · 2024-01-20 15:39:38 +01:00
  9b9485f656
• fix imports
  OliBomby · 2024-01-20 15:15:49 +01:00
  1596776a81
• fix possible NaN in clamped scale
  OliBomby · 2024-01-20 14:49:47 +01:00
  e1f3f7d988
• refactor CanScale properties
  OliBomby · 2024-01-20 01:13:01 +01:00
  a4f771ec08
• Refactor scale handling in editor to facilitate reuse
  OliBomby · 2024-01-20 00:22:53 +01:00
  26c0d1077a