250 Commits

• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b
• Clarify "invert" mod cannot possibly play sliding samples
  Salman Alshamrani · 2025-08-04 12:27:57 +03:00
  6d43ae8ac1
• Fix "no release" mod not playing sliding samples in converted beatmaps
  Salman Alshamrani · 2025-08-04 12:27:57 +03:00
  d216256fdf
• Merge pull request #30506 from smoogipoo/mania-key-mod-multiplier

  Add default multiplier for mania key mods

  Dean Herbert · 2025-07-16 17:20:30 +09:00
  7e373f6410
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Fix mania Hard Rock & Easy mods not matching stable

  The implementation in `master` was presuming that Hard Rock and Easy
  worked the same way across all rulesets, but actually, in stable mania,
  the two mods have special treatment as per
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L147-L150
  
  The open question here would be what this means for existing scores set
  on lazer using this mod.

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  8e53f47e78
• Support mania-specific hit window quirks

  The quirks in question being that lazer's hit windows in mania preceding
  this change are used in stable *if and only if* Score V2 is active. If
  Score V2 is *not* active, stable has two disparate other sets of hit
  window ranges, dependent on whether the beatmap is a convert or not.
  
  With this commit, those hit windows are used in lazer when the Classic
  mod is active.
  
  Open points for discussion would be:
  
  - What does this mean for plays already set on lazer using the Classic
    mod? Are there even enough of them to care about? Also, on `master`
    the Classic mod does precisely nothing, so maybe such scores should
    just have Classic mod stripped from them?
  
  - What does this mean for the mod multiplier of Classic in mania? (I don't
    expect an answer to this one.)

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  6afdf99df8
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Rename mod setting

  Just feels better?

  Bartłomiej Dach · 2025-05-08 07:47:24 +02:00
  1e61abde74
• Added blank line
  fredzio2006 · 2025-05-02 04:35:29 +02:00
  843c48c4f8
• Only allow perfect hits in mania option for Perfect Mod
  fredzio2006 · 2025-05-02 03:54:32 +02:00
  930267a8d0
• Merge branch 'master' into freestyle-mods
  Bartłomiej Dach · 2025-04-23 13:49:32 +02:00
  6da4e09717
• Minor fix to the description text
  Shavixinio · 2025-04-22 19:49:34 +02:00
  3b2382ceb0
• Remove no longer relevant comments
  Dan Balasescu · 2025-04-17 18:25:01 +09:00
  5bda93aac6
• Adjust property name
  Dan Balasescu · 2025-04-14 19:34:33 +09:00
  35ee4b6f24
• Disallow mania cover mod
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  cf8a7cbbe8
• Allow specifying mod compatibility with freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  ef0cf5143d
• Remove end note conversion in mania invert mod
  Nuno · 2025-03-13 01:02:34 +00:00
  a075a5641a
• Revert unnecessary inheritance

  Everyone is right, too much inheritance and polymorphism backfires very badly.

  Salman Alshamrani · 2025-01-25 19:12:37 -05:00
  8151c3095d
• Fix failing tests

  - Caches `DrawableRuleset` in editor compose screen for mania playfield adjustment container (because it's used to wrap the blueprint container as well)
  - Fixes `ManiaModWithPlayfieldCover` performing a no-longer-correct direct cast with a naive-but-working approach.

  Salman Alshamrani · 2025-01-12 22:56:40 -05:00
  c1ac27d658
• Make mania judgements relative to the hit target position

  This improves display in portrait screen, where the stage is scaled up.

  Salman Alshamrani · 2024-12-31 12:25:58 -05:00
  1e08b3dbda
• Add default multiplier for mania key mods
  Dan Balasescu · 2024-11-05 14:16:36 +09:00
  1d232dca8d
• Make "Hold Off" and "No Release" mod incompatible
  Dean Herbert · 2024-07-19 14:08:39 +03:00
  f500abd4f7
• Rewrite no release mod

  Per the request of spaceman_atlas, the No Release mod is rewritten to
  avoid modifications to DrawableHoldNoteTail. The approach is based
  on that of the Strict Tracking mod for the osu!(standard) ruleset,
  injecting the mod behavior by replacing the normal hold note with
  the mod's variant. The variant inherits most bevaior from the normal
  hold note, but when creating nested hitobjects, it creates its own
  hold note tail variant instead, which in turn is used to instantiate
  the mod's variant of DrawableHoldNoteTail with a new behavior.
  
  The time a judgement is awarded is changed from the end of its
  Perfect window to the time of the tail itself.

  Nathan Du · 2024-07-01 20:29:30 +08:00
  1eb10e029c
• Initial implemention of the No Release mod

  This commit adds a new osu!mania mod No Release that relaxes tail
  judgements. The current implementation automatically awards Perfect
  (or Meh if the hold note is broken midway) for a hold note tail at
  the end of its Perfect window, as long as it is held by then.
  
  Tests are pending for the next commit.

  Nathan Du · 2024-06-28 22:21:08 +08:00
  960d552dc1
• Fix missing event unbinds
  Dan Balasescu · 2024-03-07 21:10:11 +09:00
  ca92a31cf9
• Add break support
  Dan Balasescu · 2024-02-15 22:05:25 +09:00
  878fb2d10d
• Adjust tests
  Dan Balasescu · 2024-02-15 21:25:40 +09:00
  d1a51b474c
• Fix resolution scaling
  Dan Balasescu · 2024-02-15 20:07:55 +09:00
  755bc7c050
• Fix legacy coverage metrics
  Dan Balasescu · 2024-02-08 00:20:32 +09:00
  8f995a30af
• Fix coordinate space
  Dan Balasescu · 2024-02-07 00:25:22 +09:00
  af20eacc82
• Add ManiaModCover to take over old roles of the mods
  Dan Balasescu · 2024-02-07 00:15:14 +09:00
  69db1b2778
• Add progressive cover to mania HD and FI mods
  Dan Balasescu · 2024-02-06 23:47:20 +09:00
  5bc7befbd4
• Make coverage into a bindable
  Dan Balasescu · 2024-02-06 23:33:00 +09:00
  5265d33c12
• Annotate mods that give pp
  Bartłomiej Dach · 2024-01-31 14:59:35 +01:00
  f89923aeae
• Fix mania "Great" hits failing with perfect mod
  Dan Balasescu · 2023-12-22 16:19:36 +09:00
  93efa98d9b
• Remove mania mod multiplier for DT/NC
  Dan Balasescu · 2023-12-20 22:28:50 +09:00
  bff08d124b
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Merge branch 'master' into mania-edit-disable-sv
  Dean Herbert · 2023-09-20 14:23:07 +09:00
  c5397bdbb3
• Merge branch 'master' into mania-edit-disable-sv
  Dean Herbert · 2023-09-01 19:08:48 +09:00
  0f5eff1230
• Adjust mania hit windows with gameplay rate
  Dan Balasescu · 2023-08-24 11:17:41 +09:00
  c8f42f73e8
• Allow toggling SVs in the editor
  Dan Balasescu · 2023-08-18 18:55:24 +09:00
  a2fd7707a1
• Fix test + cleanup
  Dan Balasescu · 2023-08-15 19:42:32 +09:00
  5678db4e70
• Disable hold end conversion for mania HoldOff mod
  Dan Balasescu · 2023-08-15 19:30:40 +09:00
  e34a9a0001
• Remove overrides on DC/NC mods
  Dan Balasescu · 2023-04-10 17:49:29 +09:00
  ad51f880e0
• Add progressive score multiplier for HT
  Dan Balasescu · 2023-04-10 13:35:48 +09:00
  15f6bc155e
• Add progressive score multiplier for DT
  Dan Balasescu · 2023-04-10 13:31:48 +09:00
  c923482976
• code quality
  Dylan Nantz · 2023-01-11 14:28:11 -05:00
  e23c565c84
• add mania FadeIn mod configuration
  Dylan Nantz · 2023-01-11 14:13:29 -05:00
  1f4e0303f7
• Rename variables and avoid the need for a property
  Dean Herbert · 2023-01-09 16:49:38 +09:00
  efded323e4