Bartłomiej Dach
74a9899fc0
Fix doubled-up enabled state management of commit button
2024-09-30 14:05:26 +02:00
Bartłomiej Dach
155d6e57be
Isolate tests properly
2024-09-30 14:05:20 +02:00
Bartłomiej Dach
11fc1f9a1c
Fix distance snap grid using wrong colour when reference object is unsnapped
2024-09-30 13:36:51 +02:00
Bartłomiej Dach
75fc57c34b
Fix distance spacing grid displaying incorrectly for unsnapped objects with duration
2024-09-30 13:36:16 +02:00
Bartłomiej Dach
4723efaf41
Add failing test coverage for incorrect distance snapping
2024-09-30 13:36:05 +02:00
Bartłomiej Dach
e91c8fb4bd
Properly disable comment box on beatmaps that cannot be commented on
...
Closes https://github.com/ppy/osu/issues/30052 .
Compare:
- 83816dbe24/resources/js/components/comment-editor.tsx (L54-L60)83816dbe24/resources/js/components/comment-editor.tsx (L47-L52)
2024-09-30 11:02:00 +02:00
Dean Herbert
7d756d0de2
Merge pull request #30056 from bdach/speed-change-hotkeys-lose-pitch
...
Fix rate change hotkeys sometimes losing track of adjust pitch setting
2024-09-30 16:38:42 +09:00
Bartłomiej Dach
31d1ba4949
Remove unused member
2024-09-30 09:30:06 +02:00
Bartłomiej Dach
5e5bb49cd8
Fix rate change hotkeys sometimes losing track of adjust pitch setting
...
Fixes https://osu.ppy.sh/community/forums/topics/1983327 .
The cause of the bug is a bit convoluted, and stems from the fact that
the mod select overlay controls all of the game-global mod instances if
present. `ModSpeedHotkeyHandler` would store the last spotted instance
of a rate adjust mod - which in this case is a problem, because on
deselection of a mod, the mod select overlay resets its settings to
defaults:
a258059d43/osu.Game/Overlays/Mods/ModSelectOverlay.cs (L424-L425)
2024-09-30 08:47:02 +02:00
Bartłomiej Dach
23b8354af4
Add more test steps demonstrating another failure case
2024-09-30 08:46:45 +02:00
Bartłomiej Dach
3fac9baa9f
Add test steps demonstrating failure case
2024-09-30 08:46:33 +02:00
Dean Herbert
a258059d43
Merge pull request #29918 from bdach/control-drag
...
Add to existing selection when dragging with control pressed
2024-09-30 14:00:36 +09:00
Dean Herbert
71a5cd182a
Merge pull request #30040 from EVAST9919/file-popover-border
...
Fix text in `FormFileSelector` bleeding through the border
2024-09-30 11:07:39 +09:00
Andrei Zavatski
f473f4398c
Fix text in FormFileSelector bleeding through the border
2024-09-28 22:37:16 +03:00
OliBomby
1912b1fcf3
Revert "Add tooltip to rounded button"
...
This reverts commit 3e4cd0aeac
2024-09-28 17:33:24 +02:00
OliBomby
4568af8fda
Combine drag and clicky interactions
2024-09-28 17:26:39 +02:00
OliBomby
3e4cd0aeac
Add tooltip to rounded button
2024-09-28 17:04:20 +02:00
OliBomby
1c6e42671a
return grid placement tool to right toolbox
2024-09-28 17:04:11 +02:00
OliBomby
b1e381a391
Update tooltip for drag
2024-09-28 15:59:07 +02:00
OliBomby
4e2bc0d1bd
place grid with drag instead
2024-09-28 15:56:37 +02:00
Dean Herbert
c46d787f1e
Merge pull request #29949 from minetoblend/feature/scale-around-center
...
Support scaling around center when scaling with select box
2024-09-28 21:37:39 +09:00
Finadoggie
9b1ae2fe26
fix the code such that it actually works when testing it
2024-09-27 14:21:15 -07:00
Finadoggie
7a849c7e20
Fix formatting
2024-09-27 14:11:12 -07:00
Fina
132931f605
Create variable to check if using slideracc
2024-09-27 14:04:48 -07:00
Dean Herbert
9647a1be7d
Ensure editor timestamp args are URL decoded
2024-09-27 20:08:38 +09:00
Dean Herbert
f6c5f975ee
Add failing test showing url decoding is not being performed
2024-09-27 20:08:26 +09:00
Bartłomiej Dach
c1e51e05df
Merge pull request #29704 from Fabep/ModCustomisationHeaderColor
...
Mod customisation header color
2024-09-27 12:40:35 +02:00
Bartłomiej Dach
d607331755
Fix control-drag selection expansion deselecting object if control is released over one of the blueprints
2024-09-27 12:15:08 +02:00
Bartłomiej Dach
eb725ec1fb
Nudge test coverage to also cover discovered fail case
2024-09-27 12:13:11 +02:00
Bartłomiej Dach
b45fedc356
Merge branch 'master' into control-drag
2024-09-27 11:39:50 +02:00
Dean Herbert
a358731af5
Merge pull request #29913 from Joehuu/fix-romanised-searching
...
Fix searching by clicking title/artist in beatmap overlay not following original language setting
2024-09-27 18:39:33 +09:00
Dean Herbert
e7c4451206
Reduce brightness of hover effect
2024-09-27 18:20:16 +09:00
Dean Herbert
64c1ced80d
Merge branch 'master' into ModCustomisationHeaderColor
2024-09-27 18:15:30 +09:00
Dean Herbert
d9de2ad97b
Merge pull request #29899 from bdach/mania-selection-dropped
...
Ensure selection is preserved when moving selection between columns
2024-09-27 18:11:23 +09:00
Bartłomiej Dach
a00ed8dd77
Merge pull request #29914 from peppy/fix-judgement-counter-sync
...
Fix judgement counter not showing correct counts when spectating user mid-play
2024-09-27 10:57:26 +02:00
Bartłomiej Dach
33593280d8
Merge pull request #29938 from OliBomby/selection-center
...
Use minimum enclosing circle as selection centre for scale and rotate
2024-09-27 10:46:32 +02:00
Dean Herbert
371cee1617
Consume framework change to avoid weird unbind flow
2024-09-27 17:41:55 +09:00
Dean Herbert
92ee86e3dd
Update framework
2024-09-27 17:40:06 +09:00
Dean Herbert
048e3c2505
Merge branch 'master' into fix-romanised-searching
2024-09-27 17:40:03 +09:00
Bartłomiej Dach
89f47c4654
Fix random mod needlessly trying to fix nested object positions on its own
2024-09-27 10:28:32 +02:00
Bartłomiej Dach
1c23fd31d7
Ensure Slider.updateNestedPositions() actually updates the position of all nesteds
2024-09-27 10:27:54 +02:00
Bartłomiej Dach
766d2d2ad2
Merge pull request #29950 from minetoblend/feature/freeze-select-box-buttons
...
Freeze select box buttons position on press
2024-09-27 10:13:06 +02:00
Dan Balasescu
eb8cc7fbb2
Merge pull request #30019 from smoogipoo/fix-ios-ci-build
...
Fix iOS CI build
2024-09-27 16:58:47 +09:00
Dan Balasescu
73a9b03401
Merge pull request #30018 from peppy/add-missing-shader-preload
...
Update shader preloader with missing shader usages
2024-09-27 16:58:15 +09:00
Dean Herbert
1dd6082aa9
Rename method to be more appropriate
2024-09-27 16:56:22 +09:00
Dean Herbert
9a39b80a4d
Merge pull request #29970 from bdach/volume-aware-sample-equality-pitfall
...
Fix argon volume-aware hitsounds not correctly playing immediately after object placement
2024-09-27 16:38:35 +09:00
Dean Herbert
19a96bcc50
Merge pull request #29967 from bdach/storyboard-full-dim
...
Continue displaying storyboard even if fully dimmed in specific circumstances
2024-09-27 16:33:58 +09:00
Bartłomiej Dach
fa90b43233
Merge branch 'master' into selection-center
2024-09-27 09:30:36 +02:00
Dan Balasescu
cb51e12d13
Fix iOS CI build
2024-09-27 16:26:11 +09:00
Bartłomiej Dach
21796900e2
Fix code quality naming issue
2024-09-27 09:26:08 +02:00
