Salman Ahmed
4f0f07d55a
Remove placeholder classes and inline everything
2024-02-12 21:30:10 +03:00
tsunyoku
cc733ea809
add inline comment for supposedly backwards ternary
2024-02-12 18:00:05 +00:00
tsunyoku
2a02566283
refactor down and wasLeft management into respective PressHandler classes
2024-02-12 17:45:00 +00:00
Bartłomiej Dach
5d81d83fb2
Merge branch 'master' into alias-author-creator
2024-02-12 18:02:42 +01:00
Bartłomiej Dach
96711eb185
Add test coverage
2024-02-12 18:02:34 +01:00
tsunyoku
581ae2f679
handle key presses when watching legacy relax replays
2024-02-12 12:51:35 +00:00
cdwcgt
1944a12634
allow ModMuted to ranked when setting adjusted
2024-02-12 21:18:31 +09:00
Bartłomiej Dach
e5e0b0e385
Add test coverage for correct setting of beatmap set status
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
138fea8c38
Only apply set-level metadata after all difficulties have been processed
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
133e61a1b2
Add another test for even more failure
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
87702b3312
Only check online matching when determining whether to save online metadata
...
After https://github.com/ppy/osu/pull/23362 I'm not sure the
`LocallyModified` check is doing anything useful. It was confusing me
really hard when trying to parse this logic, and it can misbehave (as
`None` will also pass the check).
2024-02-12 12:07:20 +01:00
Bartłomiej Dach
4f0ae4197a
Refuse to apply online metadata in the most dodgy scenarios
2024-02-12 11:43:41 +01:00
Bartłomiej Dach
834db989f7
Add more test coverage for more failure
2024-02-12 11:43:41 +01:00
Bartłomiej Dach
80b14f1aae
Add test coverage for beatmap confusion scenarios
2024-02-12 11:43:15 +01:00
Salman Ahmed
2ae616a88e
Combine other cases of displaying dash in scores PP
2024-02-12 12:29:33 +03:00
Bartłomiej Dach
36005a5449
Fix selected legacy skins crashing on zero-length hold notes
...
Closes https://github.com/ppy/osu/issues/27134 .
2024-02-12 08:33:08 +01:00
Stoppedpuma
ca0819cf7a
Alias "mapper" as well
2024-02-11 20:28:16 +01:00
Dean Herbert
7bc571dd51
Merge pull request #27132 from EVAST9919/beatmap-panel-texture-alloc
...
Fix huge allocation overhead during beatmap texture creation in song-select screen
2024-02-12 01:43:31 +08:00
Andrei Zavatski
5e692345de
Don't convert pixel data to array
2024-02-11 17:44:54 +03:00
Dean Herbert
33d4e8f821
Merge pull request #23822 from bdach/refactor-metadata-lookup-sources
...
Refactor metadata lookup flows
2024-02-11 20:37:45 +08:00
Dean Herbert
1df38b54a1
Merge branch 'master' into refactor-metadata-lookup-sources
2024-02-11 20:10:41 +08:00
Dean Herbert
7dba21fdac
Move init method to bottom of file
2024-02-11 20:05:58 +08:00
Dan Balasescu
2ab318771e
Merge pull request #27117 from tsunyoku/remove-linq-from-difficulty-hit-object
...
Replace linq usage in `Previous` and `Next` on `DifficultyHitObject` with more direct computation
2024-02-11 18:13:58 +09:00
Dean Herbert
b0420f7ed9
Merge pull request #27115 from bdach/contributing-guidelines-do-not-release-ever
...
Add note to never run release config to contributing guidelines
2024-02-10 23:45:24 +08:00
tsunyoku
901b82384d
replace linq usage in Previous and Next with more direct computation
2024-02-10 15:42:55 +00:00
Bartłomiej Dach
bd04377643
Tell people to not run in release harder
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-02-10 16:42:19 +01:00
tsunyoku
c5f392c17d
only compute flashlight in osu! difficulty calculations when required
2024-02-10 15:25:03 +00:00
Bartłomiej Dach
4b847b68a2
Merge pull request #27056 from kongehund/deselect-slider-adds-control-point-bug
...
Fix deselecting slider adding control points
2024-02-10 16:01:27 +01:00
Bartłomiej Dach
d991873028
Add note to never run release config to contributing guidelines
...
See https://discord.com/channels/188630481301012481/188630652340404224/1205886296439136286
for the latest instance of this, but this really keeps happening. Maybe
someone will read this and stop themselves from making the same mistake.
One can dream.
2024-02-10 15:57:12 +01:00
Bartłomiej Dach
6954a185c4
Merge branch 'master' into deselect-slider-adds-control-point-bug
2024-02-10 15:35:03 +01:00
Bartłomiej Dach
6894f17b23
Add test coverage
2024-02-10 15:34:12 +01:00
Dean Herbert
32bfd875d9
Merge pull request #26930 from Susko3/suggest-update-only-if-available
...
Suggest to update only if the latest release is available for the current platform
2024-02-10 22:08:56 +08:00
Bartłomiej Dach
4a516cbccd
Merge pull request #27077 from peppy/log-fire-and-forget-better
...
Improve exception logging of unobserved exceptions via `FireAndForget`
2024-02-10 13:43:50 +01:00
Bartłomiej Dach
bd226859fb
Merge pull request #27106 from Joehuu/match-profile-icons
...
Fix profile current location and interests icons not matching web
2024-02-10 13:36:05 +01:00
Bartłomiej Dach
c3f0d3ad5c
Merge branch 'master' into match-profile-icons
2024-02-10 13:08:42 +01:00
Bartłomiej Dach
ae5f108f01
Add visual test coverage of user profile info section
2024-02-10 13:08:26 +01:00
Andrei Zavatski
5fa54c8c63
Fix remaining use cases
2024-02-10 14:16:45 +03:00
Dean Herbert
90854b5961
Merge pull request #27113 from smoogipoo/room-score-metadata
...
Add additional gameplay metadata to room score request
2024-02-10 16:59:02 +08:00
Dan Balasescu
bfeb90c1b6
Add additional gameplay metadata to room score request
2024-02-10 17:20:17 +09:00
Stoppedpuma
7c04e8bfba
Alias author to creator
...
Allows "author" to show the results of "creator"
2024-02-10 07:48:24 +01:00
Dean Herbert
01501f3b82
Merge branch 'master' into refactor-metadata-lookup-sources
2024-02-10 14:43:51 +08:00
Joseph Madamba
7b0b39dbaa
Fix total play time tooltip area including label
2024-02-09 16:06:16 -08:00
Joseph Madamba
ffd0d9bb39
Add highest rank tooltip to global rank display
2024-02-09 16:06:16 -08:00
Joseph Madamba
ae89b89928
Centralise global rank display logic to new class
2024-02-09 16:06:16 -08:00
Joseph Madamba
8d1d65a469
Add ContentTooltipText to ProfileValueDisplay
2024-02-09 16:06:16 -08:00
Joseph Madamba
c9c39ecb2f
Add RankHighest to APIUser
2024-02-09 16:06:16 -08:00
Joseph Madamba
ed2362b63d
Fix icon family and weight not transferring to text conversion
2024-02-09 14:31:38 -08:00
Joseph Madamba
666c57da50
Fix profile current location and interests icons not matching web
2024-02-09 14:31:37 -08:00
Andrei Zavatski
c500264306
Cache created judgement in HitObject
2024-02-09 23:20:31 +03:00
Dean Herbert
0ebea77392
Merge pull request #27095 from turbedi/net_8-order
...
Use new LINQ Order{Descending} instead of OrderBy{Descending} when possible
2024-02-09 11:15:37 +08:00
