157 Commits

• Add test coverage of ruleset being marked unavailable if methods are throwing
  Dean Herbert · 2022-08-29 14:28:55 +09:00
  892f43da43
• Add test coverage for outdated ruleset
  Dean Herbert · 2022-08-29 14:26:12 +09:00
  5ff4e6a4fe
• Add more missing realm Refresh() calls to new beatmap import tests

  As noticed at https://github.com/ppy/osu/runs/7605101313?check_suite_focus=true

  Dean Herbert · 2022-08-01 17:06:46 +09:00
  ee68113913
• Merge branch 'master' into collections-track-beatmap-updates
  Dan Balasescu · 2022-07-28 22:05:34 +09:00
  a59d7f6710
• Adjust comment
  Dan Balasescu · 2022-07-28 16:56:11 +09:00
  6d4023b933
• Add realm Refresh calls to ensure tests are stable
  Dean Herbert · 2022-07-28 15:18:04 +09:00
  67c44552cb
• Add realm refresh calls to fix intermittent test failures on new update tests
  Dean Herbert · 2022-07-28 15:15:41 +09:00
  485d140a21
• Add test coverage of beatmap updates transferring collection hashes
  Dean Herbert · 2022-07-28 15:02:58 +09:00
  2ae5a34c0e
• Fix potential test failure if scores are added to the beatmap which is subsequently removed
  Dean Herbert · 2022-07-27 16:27:10 +09:00
  494486ad09
• Merge branch 'master' into beatmap-update-test
  Dean Herbert · 2022-07-26 17:27:36 +09:00
  7f75184a01
• Add test coverage of no online ID scenario
  Dean Herbert · 2022-07-26 17:27:23 +09:00
  ee694c1257
• Add comprehensive test coverage of update scenarios
  Dean Herbert · 2022-07-26 17:22:52 +09:00
  1221cb1a42
• Refactor new tests to not suck as much as the old importer tests
  Dean Herbert · 2022-07-26 16:33:00 +09:00
  846291d203
• Add ImportAsUpdate method to IModelImporter to avoid otehr changes
  Dean Herbert · 2022-07-26 15:49:04 +09:00
  8370ca9765
• Fix left over resource file which isn't actually imported
  Dean Herbert · 2022-07-26 15:08:18 +09:00
  ac553d22ea
• Avoid leaving left-over files after test run completes
  Dean Herbert · 2022-07-26 15:08:18 +09:00
  59d3cc52c4
• Move tests to own class
  Dean Herbert · 2022-07-26 14:53:20 +09:00
  7d8a78ef01
• Fix test nullability assertions
  Dean Herbert · 2022-07-25 20:06:37 +09:00
  9c411c2250
• Add test coverage of actual update flow
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  92dd1bcddb
• Centralise calls to reset online info of a BeatmapInfo
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  6a3e8e31de
• Add basic coverage of current behaviour of beatmap reimport
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  ec477a3ebf
• Add test coverage
  Dean Herbert · 2022-07-21 18:20:46 +09:00
  1374738a0d
• Add test coverage of nested rollback for good measure
  Dean Herbert · 2022-07-07 18:19:01 +09:00
  bf10f2db2e
• Fix transaction not being disposed
  Dean Herbert · 2022-07-07 18:15:38 +09:00
  ac216d94a8
• Add automatic transaction handling to realm helper methods
  Dean Herbert · 2022-07-07 17:36:25 +09:00
  5197d0fa9e
• Add more verbose logging to realm blocking process
  Dean Herbert · 2022-07-02 12:36:56 +09:00
  4fd47b5fa0
• Merge pull request #18835 from peppy/beatmap-update-flow

  Split out beatmap update tasks to `BeatmapUpdater` and invoke from editor save flow

  Dan Balasescu · 2022-07-01 20:28:04 +09:00
  3b1842a2c2
• Merge branch 'master' into realm-fix-async-write-after-disposal
  Dean Herbert · 2022-06-30 19:07:15 +09:00
  447b496eff
• Merge branch 'master' into beatmap-update-flow
  Dean Herbert · 2022-06-30 16:44:17 +09:00
  98938821e5
• Add reproduction of transaction not being exited correctly
  Dean Herbert · 2022-06-30 15:15:09 +09:00
  0abb400f64
• Merge branch 'master' into realm-fix-async-write-after-disposal
  Dean Herbert · 2022-06-29 22:39:05 +09:00
  a3b4a515fc
• Add test coverage of async writes during a blocking operation
  Dean Herbert · 2022-06-28 17:07:49 +09:00
  d64959ad0c
• Add test coverage of realm async writes
  Dean Herbert · 2022-06-27 19:38:14 +09:00
  6203885040
• Remove unnecessary Task.Run workaround in tests
  Dean Herbert · 2022-06-27 19:21:05 +09:00
  1fc4fa6820
• Remove unused using statement
  Dean Herbert · 2022-06-27 18:04:52 +09:00
  5af1106fa5
• Update rollback test expectations

  I can't find a better way to do this. It's very hard to trigger an
  actual failure in the import process these days. For now I've just made
  this work with the new assumptions. May be worth removing the test in
  the future if this ever backfires.

  Dean Herbert · 2022-06-27 17:04:35 +09:00
  8c3c1f095e
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Move beatmap processing tasks to new BeatmapUpdater class
  Dean Herbert · 2022-06-24 21:02:37 +09:00
  06d59b717c
• Add timeout for all ManualResetEventSlim.Wait invocations

  Timeout values were taken as best-guesses of upper values we'd expect
  from sane execution.

  Dean Herbert · 2022-06-23 14:46:00 +09:00
  7ef8b7df5f
• Merge pull request #18777 from peppy/output-directory-on-import-failure

  Silence exception and provide more log output when import fails due to empty `.osu` files

  Dan Balasescu · 2022-06-20 17:36:21 +09:00
  c402e90598
• Add test coverage of import throwing when no valid .osu files are found
  Dean Herbert · 2022-06-20 16:06:22 +09:00
  e82d948acc
• Rename Import(TModel) to ImportModel to differentiate from other import methods
  Dean Herbert · 2022-06-20 15:18:07 +09:00
  92f1a2958c
• Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask)
  Dean Herbert · 2022-06-20 15:14:57 +09:00
  a6c8a832aa
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove RealmArchiveModelManager from hierarchy
  Dean Herbert · 2022-06-16 18:53:13 +09:00
  f3984d98e6
• Update usages of BeatmapModelManager which only require importing to use BeatmapImporter
  Dean Herbert · 2022-06-16 17:59:24 +09:00
  84dba36cf5
• Move remaining realm classes out of Stores namespace
  Dean Herbert · 2022-06-15 21:56:00 +09:00
  f23ddfe6cc
• Merge pull request #18689 from peppy/quick-import-only-on-batch

  Always perform full consistency checks for single imports

  Dean Herbert · 2022-06-15 17:06:06 +09:00
  080f2859ef
• Fix test files stream not disposed after creation
  Salman Ahmed · 2022-06-15 08:24:20 +03:00
  3d638abc52
• Add failing test case
  Salman Ahmed · 2022-06-15 07:33:21 +03:00
  ee8045d507