Dean Herbert
1045742321
Merge pull request #28421 from bdach/mania-editor-flip-controls
...
Implement flip operations in mania editor
2024-06-08 00:10:16 +09:00
Dean Herbert
030acb153a
Merge pull request #24475 from nanashi-1/add-rank-display
...
Add skinnable rank display
2024-06-07 18:33:27 +09:00
Dean Herbert
9c6e707f00
Adjust transitions
2024-06-07 17:04:16 +08:00
Dean Herbert
366ef64a2c
Apply NRT to UpdateableRank
2024-06-07 16:54:12 +08:00
Bartłomiej Dach
72890bb9ac
Add stable-like animation legacy rank display
...
Just substituting the sprite felt pretty terrible.
2024-06-07 09:56:10 +02:00
Bartłomiej Dach
199d31c0f4
Fix test not compiling
...
A little ugly but maybe it'll do...
2024-06-07 09:54:00 +02:00
Bartłomiej Dach
4cd1ccc4d4
Merge branch 'master' into add-rank-display
2024-06-07 09:33:03 +02:00
Bartłomiej Dach
f787a29f49
Add test coverage
2024-06-07 09:19:17 +02:00
Bartłomiej Dach
629e7652c0
Implement flip operations in mania editor
2024-06-07 09:01:41 +02:00
Bartłomiej Dach
e13e9abda9
Disallow running save-related operations concurrently
...
Closes https://github.com/ppy/osu/issues/25426 .
Different approach to prior ones, this just disables the relevant
actions when something related to save/export is going on. Still ends up
being convoluted because many things you wouldn't expect to touch save
do touch save, so it's not just a concern between export and save
specifically.
2024-06-07 08:13:51 +02:00
Bartłomiej Dach
a6d0cd56b0
Merge pull request #28399 from matheus-cesquim/total-playlist-duration-not-considering-altered-song-durations-from-speed-changing-mods-#28398
...
Fix playlist total time not considering rate adjust mods
2024-06-07 07:24:55 +02:00
Dean Herbert
7cbe93efc3
Refactor latest changes to avoid unnecessary call when mods not present
2024-06-07 10:37:27 +08:00
Xesquim
6e3bea938e
Instancing a Ruleset only when it's necessary to
2024-06-06 13:26:52 -03:00
Dean Herbert
dd3f4bcdab
Fix code quality and null handling
2024-06-07 00:01:50 +08:00
Xesquim
860afb8123
Creating method in ModUtils to calculate the rate for the song
2024-06-06 10:06:07 -03:00
OliBomby
e873698221
Add some in-depth xmldoc to GetSamples
2024-06-06 14:57:25 +02:00
OliBomby
fcc8671cbd
undo useless change
2024-06-06 14:50:24 +02:00
OliBomby
ba78b8759e
Merge branch 'edit-nodesample' of https://github.com/OliBomby/osu into edit-nodesample
2024-06-06 14:48:18 +02:00
OliBomby
71ce400359
Fix wasteful recreating of container
2024-06-06 14:48:17 +02:00
Bartłomiej Dach
dd9c77d248
Fix obsoletion warning
2024-06-06 13:50:31 +02:00
Bartłomiej Dach
7a8a37dae6
Use established constants
2024-06-06 13:42:31 +02:00
Bartłomiej Dach
86b13074a0
Merge branch 'master' into edit-nodesample
2024-06-06 13:42:25 +02:00
OliBomby
4f8c167cf9
clean up to match logic in CircularDistanceSnapGrid
2024-06-05 18:56:18 +02:00
OliBomby
fe738a0951
Fix missing container inject
2024-06-05 18:12:02 +02:00
Xesquim
7dd18a84f6
Fixing the GetTotalDuration in PlaylistExtesions
2024-06-05 12:25:33 -03:00
OliBomby
d8994786f6
Merge remote-tracking branch 'upstream/master' into grids-2
2024-06-05 17:18:48 +02:00
Dean Herbert
318598730b
Merge pull request #26309 from OliBomby/grids-1
...
Add ability to change position, spacing, and rotation of the positional snap grid in the editor
2024-06-05 23:36:45 +09:00
Dean Herbert
212be6b9a7
Merge branch 'master' into grids-1
2024-06-05 15:20:04 +09:00
Dean Herbert
058d7aa7c1
Merge pull request #28388 from bdach/disable-primary-constructors
...
Disable primary constructor related inspections
2024-06-05 01:13:49 +09:00
Bartłomiej Dach
442b61da84
Disable primary constructor related inspections
...
I'm not actually sure whether the editorconfig incantation does anything
but it's the one official sources give:
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0290
2024-06-04 15:14:56 +02:00
Dean Herbert
9f6ff48833
Merge pull request #28387 from bdach/taiko-selection-handler-is-slow
...
Fix performance overhead from ternary state bindable callbacks when selection is changing
2024-06-04 18:51:10 +09:00
Bartłomiej Dach
ecfcf7a2c0
Add xmldoc mention about performance overhead of PerformOnSelection()
2024-06-04 10:36:30 +02:00
Bartłomiej Dach
f13ca28d5e
Fix performance overhead from ternary state bindable callbacks when selection is changing
...
Closes https://github.com/ppy/osu/issues/28369 .
The reporter of the issue was incorrect; it's not the beat snap grid
that is causing the problem, it's something far stupider than that.
When the current selection changes,
`EditorSelectionHandler.UpdateTernaryStates()` is supposed to update the
state of ternary bindables to reflect the reality of the current
selection. This in turn will fire bindable change callbacks for said
ternary toggles, which heavily use `EditorBeatmap.PerformOnSelection()`.
The thing about that method is that it will attempt to check whether any
changes were actually made to avoid producing empty undo states, *but*
to do this, it must *serialise out the entire beatmap to a stream* and
then *binary equality check that* to determine whether any changes were
actually made:
7b14c77e43/osu.Game/Screens/Edit/EditorChangeHandler.cs (L65-L69)
2024-06-04 10:32:12 +02:00
Bartłomiej Dach
4fcb902341
Merge branch 'master' into grids-1
2024-06-03 12:33:51 +02:00
Bartłomiej Dach
7b14c77e43
Merge pull request #28383 from peppy/fix-main-menu-test-fail
...
Fix occasional test failures on new menu content tests
2024-06-03 10:29:18 +02:00
Dean Herbert
96514132c1
Fix occasional test failures on new menu content tests
...
Scheduled data transfer could still overwrite test data.
2024-06-03 12:24:56 +09:00
Dan Balasescu
8296e6318a
Merge pull request #28380 from peppy/ruleset-store-unavailable-but-why
...
Fix `AssemblyRulesetStore` not marking rulesets as available
2024-06-02 20:28:28 +09:00
Dean Herbert
091104764e
Fix AssemblyRulesetStore not marking rulesets as available
2024-06-02 17:33:06 +09:00
Dean Herbert
f1689d542e
Merge pull request #28371 from smoogipoo/fix-collections-menu-drag
...
Fix unable to drag-scroll on collections right-click menu
2024-06-01 19:16:14 +09:00
Dan Balasescu
e3205fce47
Fix unable to drag-scroll on collections right-click menu
2024-06-01 14:29:23 +09:00
Dean Herbert
4162d0babe
Merge pull request #28297 from Hecatia-Lapislazuli/near-straight-slider-crash-fix
...
Fix for nearly straight sliders causing a crash
2024-05-31 20:00:47 +09:00
Bartłomiej Dach
b76ec9654d
Merge pull request #28363 from peppy/external-link-open-trusted
...
Bypass external link dialog for links on the trusted osu! domain
2024-05-31 09:11:49 +02:00
Bartłomiej Dach
69990c35cb
Add commentary on presence of IsPresent override
2024-05-31 08:47:19 +02:00
Dean Herbert
c6a7082034
Fix incorrect prefix check
2024-05-31 15:38:26 +09:00
Aurelian
9111da81d2
Updated comments
2024-05-31 08:20:19 +02:00
Bartłomiej Dach
1a26a5dbda
Fix mismatching localisation key prefix
...
The `Strings` suffix is not supposed to be in here, judging by other
localisation classes.
2024-05-31 08:09:25 +02:00
Bartłomiej Dach
cb72630ce1
Fix compile failures
2024-05-31 08:09:06 +02:00
Dean Herbert
5dfeaa3c4a
Move dialog strings to more common class name
2024-05-31 11:46:32 +09:00
Dean Herbert
e52f524ea2
Use common header text
2024-05-31 11:44:53 +09:00
Dean Herbert
474ff5b99d
Use question mark for more grammatical correctness
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2024-05-31 10:46:30 +09:00
