Dean Herbert
5dfeaa3c4a
Move dialog strings to more common class name
2024-05-31 11:46:32 +09:00
Dean Herbert
e52f524ea2
Use common header text
2024-05-31 11:44:53 +09:00
Dean Herbert
474ff5b99d
Use question mark for more grammatical correctness
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2024-05-31 10:46:30 +09:00
Dean Herbert
53b7c29488
Add test coverage of menu banner link opening
2024-05-31 03:15:26 +09:00
Dean Herbert
ed64bfff8d
Bypass external link dialog for links on the trusted osu! domain
2024-05-31 02:44:51 +09:00
Dean Herbert
87a331fdde
Improve text on external link warning dialog
2024-05-31 02:44:45 +09:00
Dean Herbert
8196c0026d
Merge pull request #28337 from bdach/catch-conversion-my-old-friend-ive-come-to-talk-to-you-again
...
Remove rounding of slider velocity multiplier on juice streams
2024-05-30 22:16:54 +09:00
Dean Herbert
b46222db19
Merge pull request #28359 from smoogipoo/autopilot-resume-overlay
...
Use delayed resume overlay for autopilot
2024-05-30 19:52:58 +09:00
Dan Balasescu
3c2599c50f
Merge pull request #27977 from DavidBeh/magnetised-judgements
...
Make judgements follow hitcircles and enable them in magnetised, repel and depth
2024-05-30 19:21:20 +09:00
Dan Balasescu
f6a59bee9a
Use delayed resume overlay for autopilot
2024-05-30 19:17:18 +09:00
Dan Balasescu
981b69de2f
Merge pull request #28357 from peppy/dont-fail-acks
...
Avoid `ChatAckRequest` failures flooding console in `OsuGameTestScene`s
2024-05-30 18:15:25 +09:00
Dean Herbert
f37546cc77
Merge pull request #28358 from bdach/fix-main-menu-button-bg
...
Fix main menu button backgrounds not covering their entire width sometimes
2024-05-30 17:57:53 +09:00
Dean Herbert
f3bc944ac8
Remove using statement
2024-05-30 17:45:32 +09:00
Bartłomiej Dach
50bd0897f6
Fix main menu button backgrounds not covering their entire width sometimes
...
I thought I had fixed this already once but it still looks broken.
Basically when hovering over main menu buttons every now and then it
will look like their backgrounds are not covering their entire width
when they expand.
The removed X position set looks wrong to me when inspecting the draw
visualiser with the element because the element looks to be off centre
horizontally, and removing it fixes that.
2024-05-30 10:38:22 +02:00
Dean Herbert
36d7775032
Fix typo in IAPIProvider
xmldoc
2024-05-30 17:38:05 +09:00
Dean Herbert
2f2bc8e52e
Avoid ChatAckRequest
failures flooding console in OsuGameTestScene
s
2024-05-30 17:37:55 +09:00
Bartłomiej Dach
8916f08f86
Only take initial judgement position from object instead of following
...
Looks less bad with mods like depth active.
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-05-30 09:03:02 +02:00
Givikap120
f5d2c549cb
Update CatchPerformanceCalculator.cs
2024-05-29 19:25:58 +03:00
Dan Balasescu
0a7336ef17
Merge pull request #28349 from bdach/do-not-hardcode-api-version
...
Derive API response version from game version
2024-05-29 21:35:19 +09:00
Bartłomiej Dach
ab01fa6d45
Add xmldoc to APIAccess.APIVersion
2024-05-29 14:10:07 +02:00
Bartłomiej Dach
cc13655617
Derive API response version from game version
...
(Or local date, in the case of non-deployed builds).
Came up when I was looking at https://github.com/ppy/osu-web/pull/11240
and found that we were still hardcoding this.
Thankfully, this *should not* cause issues, since there don't seem to be
any (documented or undocumented) API response version checks for
versions newer than 20220705 in osu-web master.
For clarity and possible debugging needs, the API response version is
also logged.
2024-05-29 14:10:01 +02:00
Bartłomiej Dach
a6c776dac8
Use hopefully safer implementation of anchoring judgements to objects
2024-05-29 11:11:43 +02:00
Dan Balasescu
fa1da193ff
Merge pull request #28339 from bdach/fix-legacy-body-piece-animation-not-resetting-sometimes
...
Fix legacy mania note body animation not resetting sometimes
2024-05-29 18:04:39 +09:00
Bartłomiej Dach
22a2adb5e6
Revert unrelated changes
2024-05-29 10:57:30 +02:00
Bartłomiej Dach
9fb7cc5900
Merge branch 'master' into magnetised-judgements
2024-05-29 10:56:53 +02:00
Bartłomiej Dach
bf7dc715de
Merge pull request #28309 from OliBomby/scale-tool
...
Add precise scaling control to osu! editor
2024-05-29 10:52:00 +02:00
Bartłomiej Dach
84513343d6
Remove unused fields
2024-05-29 10:18:22 +02:00
Bartłomiej Dach
7b7e439d03
Merge branch 'master' into scale-tool
2024-05-29 10:15:48 +02:00
Bartłomiej Dach
9477e3b67d
Change editor scale hotkey to Ctrl-E
...
Forgot that Ctrl-T was taken by the game-global toolbar already, so it
wasn't working.
2024-05-29 10:14:47 +02:00
Bartłomiej Dach
9bd4b0d613
Rename method
2024-05-29 10:04:51 +02:00
Bartłomiej Dach
ba40737356
Simplify logic
2024-05-29 10:01:04 +02:00
Bartłomiej Dach
96a8bdf920
Use more generic tooltip copy
2024-05-29 09:59:19 +02:00
Bartłomiej Dach
bd5060965f
Simplify toolbox button enable logic
2024-05-29 09:49:16 +02:00
Bartłomiej Dach
4a8273b6ed
Rename another method
2024-05-29 09:43:09 +02:00
Bartłomiej Dach
4c881b5633
Use better name if we're renaming
2024-05-29 09:40:29 +02:00
Aurelian
542809a748
Reduced subpoints limit to be a more practical value
2024-05-29 09:39:46 +02:00
Dan Balasescu
ba3880ad54
Merge pull request #28343 from Hecatia-Lapislazuli/reworked-slider-ball-rotation
...
Always compute slider ball rotation based on tangent
2024-05-29 14:23:19 +09:00
Dan Balasescu
98ad8f807a
Merge pull request #24138 from tybug/negative-frame-handling
...
Handle replay frames with negative time delta appropriately
2024-05-29 13:46:24 +09:00
Dan Balasescu
655b0f5343
Merge branch 'master' into negative-frame-handling
2024-05-29 13:14:59 +09:00
Aurelian
b74f66e335
SliderBall's rotation updates based on CurvePositionAt
2024-05-28 19:38:33 +02:00
OliBomby
9a18ba2699
disable playfield centre origin when scaling slider and simplify logic
2024-05-28 18:27:01 +02:00
OliBomby
9548585b15
fix axis checkboxes being disabled in playfield origin scale
2024-05-28 17:24:31 +02:00
OliBomby
d143a697d2
refactor CanScaleFromPlayfieldOrigin and GetClampedScale to derived class
2024-05-28 17:12:16 +02:00
OliBomby
7cdc755c16
Bind axis checkbox disabled state to CanScaleX/Y
2024-05-28 16:57:24 +02:00
Bartłomiej Dach
4828215674
Merge pull request #28338 from peppy/update-framework
...
Update framework
2024-05-28 16:46:24 +02:00
OliBomby
8eb23f8a60
remove redundant CanScaleFromSelectionOrigin
2024-05-28 16:19:57 +02:00
OliBomby
a89ba33b47
rename CanScaleSelectionOrigin/PlayfieldOrigin to make clear its not the origin being scaled
2024-05-28 16:14:16 +02:00
OliBomby
36453f6215
Change scale hotkey to Ctrl+T
2024-05-28 15:56:59 +02:00
Bartłomiej Dach
bf0040447c
Fix legacy mania note body animation not resetting sometimes
...
Hopefully closes https://github.com/ppy/osu/issues/28284 .
As far as I can tell this is a somewhat difficult one to reproduce
because it relies on a specific set of circumstances (at least the
reproduction case that I found does). The reset to frame 0 would
previously be called explicitly when `isHitting` changed:
182ca145c7/osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyBodyPiece.cs (L144)
However, it can be the case that `bodyAnimation` is not loaded at the
point of this call. This is significant because
`SkinnableTextureAnimation` contains this logic:
182ca145c7/osu.Game/Skinning/LegacySkinExtensions.cs (L192-L211)
which cannot be moved any earlier (because any earlier the `Clock` may
no longer be correct), and also causes the animation to be seeked
forward while it is stopped.
I can't figure out a decent way to layer this otherwise (by scheduling
or whatever), so this commit is just applying the nuclear option of just
seeking back to frame 0 on every update frame in which the body piece is
not being hit.
2024-05-28 15:29:15 +02:00
Dean Herbert
c2e7cdfdcc
Update framework
2024-05-28 21:29:29 +09:00